You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by LantaoJin <gi...@git.apache.org> on 2018/09/30 10:11:52 UTC
[GitHub] spark pull request #22595: [SPARK-25577][Web UI] Add an on-off switch to dis...
GitHub user LantaoJin opened a pull request:
https://github.com/apache/spark/pull/22595
[SPARK-25577][Web UI] Add an on-off switch to display the executor additional columns
## What changes were proposed in this pull request?
[SPARK-17019](https://issues.apache.org/jira/browse/SPARK-17019) Expose off-heap memory usage in WebUI. But it makes this additional columns hidden by default. If we want to see them, we need change the css code to rebuild a spark-core.jar. It's very inconvenient.
```
.on_heap_memory, .off_heap_memory {
display: none;
}
```
So I add an on-off switch to show those additional columns. And in future, we don't afraid to add more columns.
## How was this patch tested?
<img width="693" alt="screen shot 2018-09-30 at 5 45 56 pm" src="https://user-images.githubusercontent.com/1853780/46256353-3a042700-c4dc-11e8-8b0f-305281d1fd17.png">
<img width="743" alt="screen shot 2018-09-30 at 5 46 06 pm" src="https://user-images.githubusercontent.com/1853780/46256356-3f617180-c4dc-11e8-9d24-679db52343fe.png">
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/LantaoJin/spark SPARK-25577
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/22595.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #22595
----
commit c758db01da06d0bc5f4466bab10a330ef812bcc6
Author: LantaoJin <ji...@...>
Date: 2018-09-30T10:08:32Z
[SPARK-25577][Web UI] Add an on-off switch to display the executor additional columns
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22595: [SPARK-25577][Web UI] Add an on-off switch to display th...
Posted by LantaoJin <gi...@git.apache.org>.
Github user LantaoJin commented on the issue:
https://github.com/apache/spark/pull/22595
Gently ping @jerryshao @cloud-fan . Do you have a chance to review?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22595: [SPARK-25577][Web UI] Add an on-off switch to display th...
Posted by LantaoJin <gi...@git.apache.org>.
Github user LantaoJin commented on the issue:
https://github.com/apache/spark/pull/22595
cc @dongjoon-hyun @srowen
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22595: [SPARK-25577][Web UI] Add an on-off switch to display th...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22595
Not sure about this. It's not clear why the checkbox is there, what columns it controls. I don't perceive the UI as a problem right now.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22595: [SPARK-25577][Web UI] Add an on-off switch to display th...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22595
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22595: [SPARK-25577][Web UI] Add an on-off switch to display th...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22595
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22595: [SPARK-25577][Web UI] Add an on-off switch to display th...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22595
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22595: [SPARK-25577][Web UI] Add an on-off switch to display th...
Posted by gengliangwang <gi...@git.apache.org>.
Github user gengliangwang commented on the issue:
https://github.com/apache/spark/pull/22595
I read the original PR https://github.com/apache/spark/pull/14617, and it is wired that the two columns are hidden in the very beginning.
Also the screenshot in PR description doesn't match the code changes.
Ping @jerryshao
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22595: [SPARK-25577][Web UI] Add an on-off switch to display th...
Posted by LantaoJin <gi...@git.apache.org>.
Github user LantaoJin commented on the issue:
https://github.com/apache/spark/pull/22595
If this PR could be merged, #22578 could be added as an additional column as well.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22595: [SPARK-25577][Web UI] Add an on-off switch to display th...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22595
CC @jerryshao for https://github.com/apache/spark/pull/14617 where this was added. It looks like the display is on purpose, but can you clarify?
I don't think a "show additional columns" box stuck under the title is the right UI but I haven't looked closely at it. We have a different way of managing extra columns in the Jobs/Stage page for example.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22595: [SPARK-25577][Web UI] Add an on-off switch to display th...
Posted by LantaoJin <gi...@git.apache.org>.
Github user LantaoJin commented on the issue:
https://github.com/apache/spark/pull/22595
@srowen The checkbox is what I add in this PR to display/hidden the columns which have been hidden always. These columns are on heap memory, off heap memory. If we want to display them in executor page, we have to change the css file and rebuild the spark-core.jar file. Besides, there should be more and more columns being added in future. Ref [SPARK-23206](https://issues.apache.org/jira/browse/SPARK-23206), [SPARK-23206](https://issues.apache.org/jira/browse/SPARK-23206). If all of them are visible all the time, this page won't be brief like this. So we can simply add a checkbox to let user display them on demand and hidden by default.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org