You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by "taskain7 (via GitHub)" <gi...@apache.org> on 2023/08/04 11:00:43 UTC
[GitHub] [fineract] taskain7 commented on a diff in pull request #3342: [FINERACT-1678] Configuration for enabling/disabling Loan COB
taskain7 commented on code in PR #3342:
URL: https://github.com/apache/fineract/pull/3342#discussion_r1284284534
##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/jobs/service/JobRegisterServiceImpl.java:
##########
@@ -118,6 +120,8 @@ public void executeJob(final ScheduledJobDetail scheduledJobDetail, String trigg
scheduler.addJob(jobDetail, true);
scheduler.triggerJob(jobKey, jobDataMap);
}
+ } catch (JobIsNotFoundOrNotEnabledException e) {
+ throw e;
Review Comment:
It is not, because below that we turn every Exception into PlatformInternalServerException, but I didn't want to do this with this exception.
Log has been added though
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org