You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by "Dave Johnson (JIRA)" <ji...@apache.org> on 2008/06/18 22:27:45 UTC
[jira] Created: (SHINDIG-394) Make it easier to extend
DataRequestHandler
Make it easier to extend DataRequestHandler
-------------------------------------------
Key: SHINDIG-394
URL: https://issues.apache.org/jira/browse/SHINDIG-394
Project: Shindig
Issue Type: Improvement
Components: RESTful API (Java)
Environment: any/all
Reporter: Dave Johnson
I'd like plugin my own DataRequestHandlers, but the DataRequestHandler class seems to be designed to prevent subclassing. Would you consider changing or accepting a patch to make the package protected methods into protected methods so the class can be extended? I will attach a patch.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SHINDIG-394) Make it easier to extend
DataRequestHandler
Posted by "Cassie Doll (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Cassie Doll resolved SHINDIG-394.
---------------------------------
Resolution: Fixed
Assignee: Cassie Doll
> Make it easier to extend DataRequestHandler
> -------------------------------------------
>
> Key: SHINDIG-394
> URL: https://issues.apache.org/jira/browse/SHINDIG-394
> Project: Shindig
> Issue Type: Improvement
> Components: RESTful API (Java)
> Environment: any/all
> Reporter: Dave Johnson
> Assignee: Cassie Doll
> Attachments: shindig-394.patch
>
> Original Estimate: 0.08h
> Remaining Estimate: 0.08h
>
> I'd like plugin my own DataRequestHandlers, but the DataRequestHandler class seems to be designed to prevent subclassing. Would you consider changing or accepting a patch to make the package protected methods into protected methods so the class can be extended? I will attach a patch.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-394) Make it easier to extend
DataRequestHandler
Posted by "Cassie Doll (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12606096#action_12606096 ]
Cassie Doll commented on SHINDIG-394:
-------------------------------------
You forgot the test usage but I fixed that up for you :)
Committing now.
> Make it easier to extend DataRequestHandler
> -------------------------------------------
>
> Key: SHINDIG-394
> URL: https://issues.apache.org/jira/browse/SHINDIG-394
> Project: Shindig
> Issue Type: Improvement
> Components: RESTful API (Java)
> Environment: any/all
> Reporter: Dave Johnson
> Attachments: shindig-394.patch
>
> Original Estimate: 0.08h
> Remaining Estimate: 0.08h
>
> I'd like plugin my own DataRequestHandlers, but the DataRequestHandler class seems to be designed to prevent subclassing. Would you consider changing or accepting a patch to make the package protected methods into protected methods so the class can be extended? I will attach a patch.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-394) Make it easier to extend
DataRequestHandler
Posted by "Dave Johnson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dave Johnson updated SHINDIG-394:
---------------------------------
Attachment: shindig-394.patch
Makes key methods in DataRequestHandler protected so the class can be extended.
> Make it easier to extend DataRequestHandler
> -------------------------------------------
>
> Key: SHINDIG-394
> URL: https://issues.apache.org/jira/browse/SHINDIG-394
> Project: Shindig
> Issue Type: Improvement
> Components: RESTful API (Java)
> Environment: any/all
> Reporter: Dave Johnson
> Attachments: shindig-394.patch
>
> Original Estimate: 0.08h
> Remaining Estimate: 0.08h
>
> I'd like plugin my own DataRequestHandlers, but the DataRequestHandler class seems to be designed to prevent subclassing. Would you consider changing or accepting a patch to make the package protected methods into protected methods so the class can be extended? I will attach a patch.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.