[GitHub] [ignite] alex-plekhanov commented on a change in pull request #7966: IGNITE-13148 .NET: Add Thin Client Continuous Query

[GitBox <gi...@apache.org>]

alex-plekhanov commented on a change in pull request #7966:
URL: https://github.com/apache/ignite/pull/7966#discussion_r456435091



##########
File path: modules/platforms/dotnet/Apache.Ignite.Core/Client/Cache/Query/Continuous/ContinuousQueryDisconnectedEventArgs.cs
##########
@@ -0,0 +1,45 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */namespace Apache.Ignite.Core.Client.Cache.Query.Continuous

Review comment:
       NL

##########
File path: modules/core/src/main/java/org/apache/ignite/internal/processors/platform/client/cache/ClientCacheQueryContinuousRequest.java
##########
@@ -0,0 +1,147 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.processors.platform.client.cache;
+
+import javax.cache.configuration.Factory;
+import javax.cache.configuration.FactoryBuilder;
+import javax.cache.event.CacheEntryEventFilter;
+import org.apache.ignite.IgniteCache;
+import org.apache.ignite.binary.BinaryObject;
+import org.apache.ignite.cache.CacheEntryEventSerializableFilter;
+import org.apache.ignite.cache.query.ContinuousQuery;
+import org.apache.ignite.cache.query.QueryCursor;
+import org.apache.ignite.internal.binary.BinaryObjectImpl;
+import org.apache.ignite.internal.binary.BinaryRawReaderEx;
+import org.apache.ignite.internal.binary.GridBinaryMarshaller;
+import org.apache.ignite.internal.processors.platform.PlatformContext;
+import org.apache.ignite.internal.processors.platform.PlatformJavaObjectFactoryProxy;
+import org.apache.ignite.internal.processors.platform.client.ClientConnectionContext;
+import org.apache.ignite.internal.processors.platform.client.ClientPlatform;
+import org.apache.ignite.internal.processors.platform.client.ClientResponse;
+import org.apache.ignite.internal.processors.platform.client.ClientStatus;
+import org.apache.ignite.internal.processors.platform.client.IgniteClientException;
+import org.apache.ignite.internal.processors.platform.utils.PlatformUtils;
+
+/**
+ * Continuous query request.
+ */
+@SuppressWarnings({"rawtypes", "unchecked"})
+public class ClientCacheQueryContinuousRequest extends ClientCacheRequest {
+    /** Query. */
+    private final ContinuousQuery qry;
+
+    /** */
+    private final Object filter;
+
+    /** */
+    private final byte filterPlatform;
+
+    /**
+     * Ctor.
+     *
+     * @param reader Reader.
+     */
+    public ClientCacheQueryContinuousRequest(BinaryRawReaderEx reader) {
+        super(reader);
+
+        int pageSize = reader.readInt();
+        long timeInterval = reader.readLong();
+        boolean includeExpired = reader.readBoolean();
+
+        filter = reader.readObjectDetached();
+        filterPlatform = filter == null ? 0 : reader.readByte();
+
+        qry = new ContinuousQuery();
+
+        qry.setPageSize(pageSize)
+           .setTimeInterval(timeInterval)
+           .setIncludeExpired(includeExpired);
+    }
+
+    /** {@inheritDoc} */
+    @Override public ClientResponse process(ClientConnectionContext ctx) {
+        qry.setRemoteFilterFactory(getFilterFactory(ctx));
+
+        ctx.incrementCursors();
+
+        try {
+            IgniteCache cache = filterPlatform == ClientPlatform.JAVA && !isKeepBinary()
+                    ? rawCache(ctx)
+                    : cache(ctx);
+
+            ClientCacheQueryContinuousHandle handle = new ClientCacheQueryContinuousHandle(ctx);
+            qry.setLocalListener(handle);
+
+            QueryCursor cur = cache.query(qry);
+            long cursorId = ctx.resources().put(handle);
+            handle.setCursor(cur);
+
+            return new ClientCacheQueryContinuousResponse(requestId(), handle, cursorId);
+        }
+        catch (Exception e) {
+            ctx.decrementCursors();
+            throw e;
+        }
+    }
+
+    /**
+     * Gets the filter factory.
+     *
+     * @param ctx Connection context.
+     * @return Filter factory or null.
+     */
+    private Factory<? extends CacheEntryEventFilter> getFilterFactory(ClientConnectionContext ctx) {
+        if (filter == null)
+            return null;
+
+        if (!(filter instanceof BinaryObject))
+            throw new IgniteClientException(ClientStatus.FAILED,
+                    "Filter must be a BinaryObject: " + filter.getClass());
+
+        BinaryObjectImpl bo = (BinaryObjectImpl) filter;
+
+        switch (filterPlatform) {
+            case ClientPlatform.JAVA: {
+                if (bo.typeId() == GridBinaryMarshaller.PLATFORM_JAVA_OBJECT_FACTORY_PROXY) {
+                    PlatformJavaObjectFactoryProxy prx = bo.deserialize();
+
+                    CacheEntryEventSerializableFilter rmtFilter =
+                            (CacheEntryEventSerializableFilter) prx.factory(ctx.kernalContext()).create();
+
+                    return FactoryBuilder.factoryOf(rmtFilter);
+                }
+
+                return bo.deserialize();
+            }
+
+            case ClientPlatform.DOTNET: {
+                PlatformContext platformCtx = ctx.kernalContext().platform().context();
+
+                String curPlatform = platformCtx.platform();
+
+                if (!PlatformUtils.PLATFORM_DOTNET.equals(curPlatform))
+                    throw new IgniteClientException(ClientStatus.FAILED, "ScanQuery filter platform is " +

Review comment:
       `ScanQuery` -> `ContinuousQuery`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org