You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/02/19 14:32:13 UTC
[GitHub] [flink] azagrebin commented on a change in pull request #11073:
[FLINK-15672][build] Migrate to log4j2
azagrebin commented on a change in pull request #11073: [FLINK-15672][build] Migrate to log4j2
URL: https://github.com/apache/flink/pull/11073#discussion_r380559317
##########
File path: flink-connectors/flink-connector-elasticsearch5/pom.xml
##########
@@ -270,17 +222,6 @@ under the License.
<exclude>META-INF/maven/org.y*/**</exclude>
</excludes>
</filter>
- <!--
- Since we relocate the dependency, the paths specified in the providers file
- will be incorrect. We exclude it here, and re-package a new providers file
- with the correct re-located paths.
- -->
- <filter>
- <artifact>org.apache.logging.log4j:log4j-to-slf4j</artifact>
- <excludes>
- <exclude>META-INF/log4j-provider.properties</exclude>
Review comment:
since `log4j-to-slf4j` is not needed anymore, can its config file `META-INF/log4j-provider.properties`, adjusted for shading, be deleted?
There are also some comments in `ElasticsearchSinkITCase` classes with probably old mentioning of `log4j-to-slf4j` which are not relevant or even correct anymore
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services