You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "stevomitric (via GitHub)" <gi...@apache.org> on 2024/03/12 13:18:48 UTC
[PR] [SPARK-47349][SQL] Test refactor for string functions `startsWith` and `endsWith` [spark]
stevomitric opened a new pull request, #45477:
URL: https://github.com/apache/spark/pull/45477
### What changes were proposed in this pull request?
Refactored tests inside `CollationSuite` by migrating `startsWith` and `endsWith` tests into new `UTF8StringWithCollationSuite` suite that does unit string-level tests. Changes originally proposed in [this PR](https://github.com/apache/spark/pull/45421#discussion_r1519451854).
### Why are the changes needed?
Removes cluttering of `CollationSuite`.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Test suite proposed in this PR
### Was this patch authored or co-authored using generative AI tooling?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47349][SQL][TESTS] Refactor string function `startsWith` and `endsWith` tests [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #45477:
URL: https://github.com/apache/spark/pull/45477#issuecomment-1992753988
Thank you, @stevomitric and @uros-db .
Merged to master for Apache Spark 4.0.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47349][SQL][TESTS] Refactor string function `startsWith` and `endsWith` tests [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #45477: [SPARK-47349][SQL][TESTS] Refactor string function `startsWith` and `endsWith` tests
URL: https://github.com/apache/spark/pull/45477
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47349][SQL] Test refactor for string functions `startsWith` and `endsWith` [spark]
Posted by "uros-db (via GitHub)" <gi...@apache.org>.
uros-db commented on code in PR #45477:
URL: https://github.com/apache/spark/pull/45477#discussion_r1521492841
##########
common/unsafe/src/test/java/org/apache/spark/unsafe/types/UTF8StringWithCollationSuite.java:
##########
@@ -0,0 +1,87 @@
+package org.apache.spark.unsafe.types;
Review Comment:
add apache header
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org