[GitHub] [pulsar] liudezhi2098 commented on a change in pull request #13498: Optimize the debug log that affects performance, and unify the style

[GitBox <gi...@apache.org>]

liudezhi2098 commented on a change in pull request #13498:
URL: https://github.com/apache/pulsar/pull/13498#discussion_r775129571



##########
File path: pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/windowing/WindowManager.java
##########
@@ -105,7 +105,9 @@ public void add(T event, long ts, Record<?> record) {
     public void add(Event<T> windowEvent) {
         // watermark events are not added to the queue.
         if (windowEvent.isWatermark()) {
-            log.debug(String.format("Got watermark event with ts %d", windowEvent.getTimestamp()));
+            if (log.isDebugEnabled()) {
+                log.debug(String.format("Got watermark event with ts %d", windowEvent.getTimestamp()));

Review comment:
       yes , I will delete




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org