You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/05/16 12:41:43 UTC
[GitHub] [shardingsphere] longtai-cn opened a new pull request, #17712: Use caffeine instead of guava cache
longtai-cn opened a new pull request, #17712:
URL: https://github.com/apache/shardingsphere/pull/17712
Fixes #17684.
Changes proposed in this pull request:
- Use caffeine instead of guava cache.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] linghengqian commented on a diff in pull request #17712: Use caffeine instead of guava cache
Posted by GitBox <gi...@apache.org>.
linghengqian commented on code in PR #17712:
URL: https://github.com/apache/shardingsphere/pull/17712#discussion_r873793868
##########
pom.xml:
##########
@@ -735,6 +736,12 @@
<artifactId>freemarker</artifactId>
<version>${freemarker.version}</version>
</dependency>
+
+ <dependency>
+ <groupId>com.github.ben-manes.caffeine</groupId>
+ <artifactId>caffeine</artifactId>
+ <version>${caffeine.version}</version>
+ </dependency>
Review Comment:
Because Caffine 3.1.0 requires the project's JDK build version to be greater than or equal to `11`. Refer to https://github.com/ben-manes/caffeine#download .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu merged pull request #17712: Use caffeine instead of guava cache
Posted by GitBox <gi...@apache.org>.
terrymanu merged PR #17712:
URL: https://github.com/apache/shardingsphere/pull/17712
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu commented on a diff in pull request #17712: Use caffeine instead of guava cache
Posted by GitBox <gi...@apache.org>.
terrymanu commented on code in PR #17712:
URL: https://github.com/apache/shardingsphere/pull/17712#discussion_r873743109
##########
pom.xml:
##########
@@ -735,6 +736,12 @@
<artifactId>freemarker</artifactId>
<version>${freemarker.version}</version>
</dependency>
+
+ <dependency>
+ <groupId>com.github.ben-manes.caffeine</groupId>
+ <artifactId>caffeine</artifactId>
+ <version>${caffeine.version}</version>
+ </dependency>
Review Comment:
Why not use the newest version?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org