You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2023/01/11 11:47:49 UTC
[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1474: MINIFICPP-2008 Differentiate successful onTriggers from throwing onTr…
szaszm commented on code in PR #1474:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1474#discussion_r1062426632
##########
libminifi/include/CronDrivenSchedulingAgent.h:
##########
@@ -45,8 +45,6 @@ class CronDrivenSchedulingAgent : public ThreadedSchedulingAgent {
: ThreadedSchedulingAgent(controller_service_provider, std::move(repo), std::move(flow_repo), std::move(content_repo), std::move(configuration), thread_pool) {
}
- CronDrivenSchedulingAgent(const CronDrivenSchedulingAgent& parent) = delete;
- CronDrivenSchedulingAgent& operator=(const CronDrivenSchedulingAgent& parent) = delete;
Review Comment:
Do you want to make this copyable, or rely on some other way of disabling copy? Why?
##########
libminifi/include/SchedulingAgent.h:
##########
@@ -90,14 +86,15 @@ class SchedulingAgent {
logger_->log_trace("Destroying scheduling agent");
}
- // onTrigger, return whether the yield is need
- bool onTrigger(core::Processor* processor, const std::shared_ptr<core::ProcessContext> &processContext, const std::shared_ptr<core::ProcessSessionFactory> &sessionFactory);
- // start
+ nonstd::expected<void, std::exception_ptr> onTrigger(core::Processor* processor,
+ const std::shared_ptr<core::ProcessContext>& process_context,
+ const std::shared_ptr<core::ProcessSessionFactory>& session_factory);
Review Comment:
I'm not a fan of aligned continuations. It's wasting a lot of space, and automated refactor/renaming messes it up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org