You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/02/21 23:57:29 UTC
[GitHub] [incubator-superset] ktmud opened a new pull request #9189: Upgrade
typescript to 3.7.5
ktmud opened a new pull request #9189: Upgrade typescript to 3.7.5
URL: https://github.com/apache/incubator-superset/pull/9189
### CATEGORY
Choose one
- [ ] Bug Fix
- [ ] Enhancement (new features, refinement)
- [ ] Refactor
- [ ] Add tests
- [x] Build / Development Environment
- [ ] Documentation
### SUMMARY
- Upgrade Typescript to 3.7.5 and fix minor linting issues.
- Change webpack stats to "minimal" so build errors are more readable.
- Move .gitignore for frontend code to its own subfolder.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
### TEST PLAN
All CI/CD should pass.
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
### REVIEWERS
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] etr2460 commented on a change in pull request
#9189: Upgrade typescript to 3.7.5
Posted by GitBox <gi...@apache.org>.
etr2460 commented on a change in pull request #9189: Upgrade typescript to 3.7.5
URL: https://github.com/apache/incubator-superset/pull/9189#discussion_r383015088
##########
File path: superset-frontend/.gitignore
##########
@@ -0,0 +1,4 @@
+coverage/*
+cypress/screenshots
+cypress/videos
+src/temp
Review comment:
looks like this needs a newline
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] etr2460 merged pull request #9189: build:
upgrade typescript to 3.8.2
Posted by GitBox <gi...@apache.org>.
etr2460 merged pull request #9189: build: upgrade typescript to 3.8.2
URL: https://github.com/apache/incubator-superset/pull/9189
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on a change in pull request
#9189: Upgrade typescript to 3.8.2
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #9189: Upgrade typescript to 3.8.2
URL: https://github.com/apache/incubator-superset/pull/9189#discussion_r383439344
##########
File path: superset-frontend/package-lock.json
##########
@@ -24712,9 +24712,9 @@
"integrity": "sha1-hnrHTjhkGHsdPUfZlqeOxciDB3c="
},
"typescript": {
- "version": "3.5.3",
- "resolved": "https://registry.npmjs.org/typescript/-/typescript-3.5.3.tgz",
- "integrity": "sha512-ACzBtm/PhXBDId6a6sDJfroT2pOWt/oOnk4/dElG5G33ZL776N3Y6/6bKZJBFpd+b05F3Ct9qDjMeJmRWtE2/g==",
+ "version": "3.8.2",
Review comment:
Fixed. They must've released a new version since I started working on this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on issue #9189: Upgrade
typescript to 3.7.5
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #9189: Upgrade typescript to 3.7.5
URL: https://github.com/apache/incubator-superset/pull/9189#issuecomment-589902784
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9189?src=pr&el=h1) Report
> Merging [#9189](https://codecov.io/gh/apache/incubator-superset/pull/9189?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/3efdfc53456aa702d01fee90c17b79ba9531c9b8?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9189?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9189 +/- ##
=======================================
Coverage 59.13% 59.13%
=======================================
Files 372 372
Lines 11938 11938
Branches 2925 2925
=======================================
Hits 7059 7059
Misses 4699 4699
Partials 180 180
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9189?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9189?src=pr&el=footer). Last update [3efdfc5...48ae364](https://codecov.io/gh/apache/incubator-superset/pull/9189?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on a change in pull request
#9189: Upgrade typescript to 3.8.2
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #9189: Upgrade typescript to 3.8.2
URL: https://github.com/apache/incubator-superset/pull/9189#discussion_r383439910
##########
File path: superset-frontend/spec/javascripts/utils/safeStringify_spec.ts
##########
@@ -19,7 +19,7 @@
import { safeStringify } from '../../../src/utils/safeStringify';
class Noise {
- public next: Noise;
+ public next!: Noise;
Review comment:
Thanks! I was new to typescript and was not really about the difference between "?:" and "!:". Just followed one of the suggested fixes from tslint (which is now deprecated I guess).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] etr2460 commented on a change in pull request
#9189: Upgrade typescript to 3.7.5
Posted by GitBox <gi...@apache.org>.
etr2460 commented on a change in pull request #9189: Upgrade typescript to 3.7.5
URL: https://github.com/apache/incubator-superset/pull/9189#discussion_r383015209
##########
File path: superset-frontend/package-lock.json
##########
@@ -24712,9 +24712,9 @@
"integrity": "sha1-hnrHTjhkGHsdPUfZlqeOxciDB3c="
},
"typescript": {
- "version": "3.5.3",
- "resolved": "https://registry.npmjs.org/typescript/-/typescript-3.5.3.tgz",
- "integrity": "sha512-ACzBtm/PhXBDId6a6sDJfroT2pOWt/oOnk4/dElG5G33ZL776N3Y6/6bKZJBFpd+b05F3Ct9qDjMeJmRWtE2/g==",
+ "version": "3.8.2",
Review comment:
your PR title says this upgrades to 3.7.5, but it looks like it's actually upgrading to 3.8.2. i assume this isn't a problem, but you might want to update the title
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] etr2460 commented on a change in pull request
#9189: Upgrade typescript to 3.7.5
Posted by GitBox <gi...@apache.org>.
etr2460 commented on a change in pull request #9189: Upgrade typescript to 3.7.5
URL: https://github.com/apache/incubator-superset/pull/9189#discussion_r383015431
##########
File path: superset-frontend/spec/javascripts/utils/safeStringify_spec.ts
##########
@@ -19,7 +19,7 @@
import { safeStringify } from '../../../src/utils/safeStringify';
class Noise {
- public next: Noise;
+ public next!: Noise;
Review comment:
Looks like this should actually be a `?` since in the test, Noise types don't always have a next set
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on a change in pull request
#9189: Upgrade typescript to 3.7.5
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #9189: Upgrade typescript to 3.7.5
URL: https://github.com/apache/incubator-superset/pull/9189#discussion_r382888530
##########
File path: superset-frontend/.eslintignore
##########
@@ -25,5 +25,6 @@ stylesheets/*
vendor/*
docs/*
src/dashboard/deprecated/*
+src/temp/*
Review comment:
adding this when someone wants to manually create a soft link.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #9189:
Upgrade typescript to 3.8.2
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9189: Upgrade typescript to 3.8.2
URL: https://github.com/apache/incubator-superset/pull/9189#issuecomment-589902784
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9189?src=pr&el=h1) Report
> Merging [#9189](https://codecov.io/gh/apache/incubator-superset/pull/9189?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/3efdfc53456aa702d01fee90c17b79ba9531c9b8?src=pr&el=desc) will **decrease** coverage by `0.19%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9189?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9189 +/- ##
=========================================
- Coverage 59.13% 58.93% -0.2%
=========================================
Files 372 372
Lines 11938 11987 +49
Branches 2925 2936 +11
=========================================
+ Hits 7059 7065 +6
- Misses 4699 4742 +43
Partials 180 180
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9189?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...uperset-frontend/src/views/chartList/ChartList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9189/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL2NoYXJ0TGlzdC9DaGFydExpc3QudHN4) | `63.39% <0%> (-11.1%)` | :arrow_down: |
| [...frontend/src/views/dashboardList/DashboardList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9189/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL2Rhc2hib2FyZExpc3QvRGFzaGJvYXJkTGlzdC50c3g=) | `59.34% <0%> (-10.38%)` | :arrow_down: |
| [...rset-frontend/src/components/ListView/ListView.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9189/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvTGlzdFZpZXcudHN4) | `86.02% <0%> (-6.39%)` | :arrow_down: |
| [superset-frontend/src/components/ListView/utils.ts](https://codecov.io/gh/apache/incubator-superset/pull/9189/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvdXRpbHMudHM=) | `94.44% <0%> (-4.02%)` | :arrow_down: |
| [superset-frontend/src/components/Menu/Menu.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9189/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9NZW51LmpzeA==) | `87.5% <0%> (ø)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9189?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9189?src=pr&el=footer). Last update [3efdfc5...904ea19](https://codecov.io/gh/apache/incubator-superset/pull/9189?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org