You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by twomz <gi...@git.apache.org> on 2014/09/15 23:19:42 UTC

[GitHub] cordova-plugin-statusbar pull request: ios 8 landscape issue

GitHub user twomz opened a pull request:

    https://github.com/apache/cordova-plugin-statusbar/pull/15

    ios 8 landscape issue

    When starting an app in landscape mode in ios 8 and then calling StatusBar.overlaysWebView(false), the screen would be pushed down all the way.  Changing the orientation did not fix the issue, leaving the page pushed down the width of the device.
    
    We found that excluding the changes above in ios 8 fixed the issue, although it's possible that this is hiding a landscape orientation bug in ios 8 that may get fixed later.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/twomz/cordova-plugin-statusbar patch-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-statusbar/pull/15.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #15
    
----
commit 0151e4f2f69a4507845512f14ea7f0bbdfb543b2
Author: twomz <wi...@gmail.com>
Date:   2014-09-15T21:19:20Z

    ios 8 landscape issue
    
    When starting an app in landscape mode in ios 8 and then calling StatusBar.overlaysWebView(false), the screen would be pushed down all the way.  Changing the orientation did not fix the issue, leaving the page pushed down the width of the device.
    
    We found that excluding the changes above in ios 8 fixed the issue, although it's possible that this is hiding a landscape orientation bug in ios 8 that may get fixed later.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-plugin-statusbar pull request: ios 8 landscape issue

Posted by laucel <gi...@git.apache.org>.
Github user laucel commented on the pull request:

    https://github.com/apache/cordova-plugin-statusbar/pull/15#issuecomment-56926813
  
    @knight9999  I'm having a different behavior (on an iOS 8 device), quite the opposite:
    With Xcode 6.0.1, the status bar works well.
    With Xcode 5.1.1, it is oversized
    on an iOS 7 device works as expected in both cases



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-plugin-statusbar pull request: ios 8 landscape issue

Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the pull request:

    https://github.com/apache/cordova-plugin-statusbar/pull/15#issuecomment-57195875
  
    Are you able to take a video?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-plugin-statusbar pull request: ios 8 landscape issue

Posted by laucel <gi...@git.apache.org>.
Github user laucel commented on the pull request:

    https://github.com/apache/cordova-plugin-statusbar/pull/15#issuecomment-57901925
  
    @shazron I will test the patch first thing on Monday and let you know, I haven't an iOS 8 device with me right now. Thanks again for your support :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-plugin-statusbar pull request: ios 8 landscape issue

Posted by laucel <gi...@git.apache.org>.
Github user laucel commented on the pull request:

    https://github.com/apache/cordova-plugin-statusbar/pull/15#issuecomment-57277138
  
    @shazron check your email, please. Hope this helps.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-plugin-statusbar pull request: ios 8 landscape issue

Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the pull request:

    https://github.com/apache/cordova-plugin-statusbar/pull/15#issuecomment-55830633
  
    Patched: https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-statusbar.git;h=921dacc
    please close this PR. thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-plugin-statusbar pull request: ios 8 landscape issue

Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the pull request:

    https://github.com/apache/cordova-plugin-statusbar/pull/15#issuecomment-57597281
  
    I can't repro it here on landscape on my iPhone6+ at home, I will have to wait till I get to work tomorrow to try on the iPad where I could repro your bug, and see if my proposed fix works.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-plugin-statusbar pull request: ios 8 landscape issue

Posted by laucel <gi...@git.apache.org>.
Github user laucel commented on the pull request:

    https://github.com/apache/cordova-plugin-statusbar/pull/15#issuecomment-56636148
  
    @shazron this patch is not fixing the issue for me, still having the status bar with wrong size.  These are my preferences:
         <preference name="StatusBarOverlaysWebView" value="false" />
         <preference name="StatusBarBackgroundColor" value="#00000" />
         <preference name="StatusBarStyle" value="lightcontent" />


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-plugin-statusbar pull request: ios 8 landscape issue

Posted by knight9999 <gi...@git.apache.org>.
Github user knight9999 commented on the pull request:

    https://github.com/apache/cordova-plugin-statusbar/pull/15#issuecomment-56963381
  
    Fmmm.
    I tested using cordova 3.5.0 and Xcode 6.0.1 / Xcode 5.1.1 and an iOS 8.0.1 iPhone 5S.
    on an iOS7 it works well in both cases.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-plugin-statusbar pull request: ios 8 landscape issue

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/cordova-plugin-statusbar/pull/15


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-plugin-statusbar pull request: ios 8 landscape issue

Posted by laucel <gi...@git.apache.org>.
Github user laucel commented on the pull request:

    https://github.com/apache/cordova-plugin-statusbar/pull/15#issuecomment-57426739
  
    @shazron same here, as I wrote in the comment above :) @knight9999 although seems to have a different situation


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-plugin-statusbar pull request: ios 8 landscape issue

Posted by knight9999 <gi...@git.apache.org>.
Github user knight9999 commented on the pull request:

    https://github.com/apache/cordova-plugin-statusbar/pull/15#issuecomment-57972576
  
    The StatusBarTest works well in my environment (Xcode 6, iOS8, iPhone 5S). Thanks.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-plugin-statusbar pull request: ios 8 landscape issue

Posted by laucel <gi...@git.apache.org>.
Github user laucel commented on the pull request:

    https://github.com/apache/cordova-plugin-statusbar/pull/15#issuecomment-57595459
  
    @shazron I don't know if the detection method is the issue. Correct me if I'm wrong:
     on iOS 8 device (iOS 7 sdk) the plugin (correctly?) enters the else part of `setStatusBarOverlaysWebView`(row 212) and I'm having the same  behavior on iOS 8  device (iOS 8 sdk)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-plugin-statusbar pull request: ios 8 landscape issue

Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the pull request:

    https://github.com/apache/cordova-plugin-statusbar/pull/15#issuecomment-56724224
  
    @laucel it should work. Try in a new project, and make sure you have the correct statusbar plugin installed, it should be the latest code from github. In any case, the latest code has been published to the plugin registry as well.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-plugin-statusbar pull request: ios 8 landscape issue

Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the pull request:

    https://github.com/apache/cordova-plugin-statusbar/pull/15#issuecomment-57393404
  
    Aha I finally cracked it :)
    If you use Xcode 6 and the iOS 8 SDK to deploy to an iOS 8 device, you won't see this.
    
    You will only see this if you mix environments.
    
    1. Build the StatusBar test project on Xcode 5.1.1 (iOS 7 SDK)
    2. Deploy to an iOS 8 device
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-plugin-statusbar pull request: ios 8 landscape issue

Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the pull request:

    https://github.com/apache/cordova-plugin-statusbar/pull/15#issuecomment-57029693
  
    I just tried it on Xcode 6.0.1 (8.0 SDK) on all devices available, and Xcode 5.1.1 (7.1 SDK) on all devices available. This issue is fixed. I created a new project and installed the statusbar plugin from the registry, and set the pref to false. Turned on all orientations and tested orientation change by rotating it.
    
    Not sure what's going on with your setup. Try with the project I used: https://github.com/shazron/StatusBarTest


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-plugin-statusbar pull request: ios 8 landscape issue

Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the pull request:

    https://github.com/apache/cordova-plugin-statusbar/pull/15#issuecomment-57593830
  
    My suspicion is the IsAtLeastiOSVersion(@"8.0") macro returns NO when the iOS 7 SDK compiled app is running on an iOS 8 Device, that's why the bug is there in this particular situation.
    
    We will have to do an alternate detection method. The pre-iOS 8.0 frame will always be (width < height - Portrait) no matter the orientation. For iOS >= 8.0, in landscape, (width > height - Landscape). This assumes of course, no (future) iOS devices with square screens like the BlackBerry Passport.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-plugin-statusbar pull request: ios 8 landscape issue

Posted by laucel <gi...@git.apache.org>.
Github user laucel commented on the pull request:

    https://github.com/apache/cordova-plugin-statusbar/pull/15#issuecomment-57980576
  
    StatusBarTest works as expected on iOS8 device both on Xcode 5.1.1 and Xcode 6.0.1, thanks @shazron!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-plugin-statusbar pull request: ios 8 landscape issue

Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the pull request:

    https://github.com/apache/cordova-plugin-statusbar/pull/15#issuecomment-57383201
  
    Thanks @laucel. I've viewed the video. Seems like the difference is you start out at landscape orientation, and I haven't been able to replicate this bug using the Simulator. I'll have to flash an iPad to the latest iOS 8 and will re-test, probably won't have time to have results until tomorrow.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-plugin-statusbar pull request: ios 8 landscape issue

Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the pull request:

    https://github.com/apache/cordova-plugin-statusbar/pull/15#issuecomment-57898119
  
    Re-opened https://issues.apache.org/jira/browse/CB-7549, see the latest comment. 
    I have updated https://github.com/shazron/StatusBarTest with the patch, please pull the changes and test before I update the plugin.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-plugin-statusbar pull request: ios 8 landscape issue

Posted by laucel <gi...@git.apache.org>.
Github user laucel commented on the pull request:

    https://github.com/apache/cordova-plugin-statusbar/pull/15#issuecomment-57136002
  
    @shazron I'm having the exact same problem with your test project. I really don't know why it is not working properly, maybe some strange unlucky coincidence. Anyway, thanks for your time and support.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-plugin-statusbar pull request: ios 8 landscape issue

Posted by laucel <gi...@git.apache.org>.
Github user laucel commented on the pull request:

    https://github.com/apache/cordova-plugin-statusbar/pull/15#issuecomment-56787435
  
    @shazron Although I have installed the latest version, I've removed and re-installed it. I've also tried in a new project, same result. I'm using cordova 3.5.0 and Xcode 5.1.1 and an iOS 8 iPad mini. I'm setting StatusBarOverlaysWebView to false in config-xml via preference. Thanks for your support


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-plugin-statusbar pull request: ios 8 landscape issue

Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the pull request:

    https://github.com/apache/cordova-plugin-statusbar/pull/15#issuecomment-55829982
  
    https://issues.apache.org/jira/browse/CB-7549



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-plugin-statusbar pull request: ios 8 landscape issue

Posted by knight9999 <gi...@git.apache.org>.
Github user knight9999 commented on the pull request:

    https://github.com/apache/cordova-plugin-statusbar/pull/15#issuecomment-56924904
  
    With Xcode 6.0.1, the status bar disappears in landscape.
    With Xcode 5.1.1, it seems to work well.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-plugin-statusbar pull request: ios 8 landscape issue

Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the pull request:

    https://github.com/apache/cordova-plugin-statusbar/pull/15#issuecomment-58101393
  
    Great, I will pull it in. Thanks for testing everyone!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org