[GitHub] [incubator-pegasus] acelyc111 commented on pull request #587: fix(pegasus-server): Load options from file when open an exist DB

[GitBox <gi...@apache.org>]

acelyc111 commented on pull request #587:
URL: https://github.com/apache/incubator-pegasus/pull/587#issuecomment-680980326


   > If store usage scenario into meta column family, we need to open DB with default options and then read
   meta data and set options, that would also lead to unexpected flushs and compactions.
   
   Sure, usage scenario stored in meta column family is not used to initialize options to open db, but I think it's worthy to initialize member variable `_usage_scenario`, which is not well initialized currently, and it's an empty string after constructing. If restore it from meta CF, we can prevent calling `set_options` which may cause flush and compaction by https://github.com/apache/incubator-pegasus/blob/ea1689f5ca46dbdc27a15054d73e2a9a5ae0a37e/src/server/pegasus_server_impl.cpp#L2453


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org