You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2019/02/11 19:14:08 UTC
Review Request 69944: Made the code more robust related to sendfile.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69944/
-----------------------------------------------------------
Review request for mesos, Andrei Budnik, Gilbert Song, and James Peach.
Repository: mesos
Description
-------
It's possible that sendfile returns less bytes written than requested.
Previously, we simply return an error in that case. This patch makes it
more robust by retrying sendfile if less bytes were written than
requested.
Diffs
-----
src/linux/memfd.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/69944/diff/1/
Testing
-------
sudo make check
Thanks,
Jie Yu
Re: Review Request 69944: Made the code more robust related to
sendfile.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69944/#review212710
-----------------------------------------------------------
Ship it!
Ship It!
- Gilbert Song
On Feb. 11, 2019, 11:14 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69944/
> -----------------------------------------------------------
>
> (Updated Feb. 11, 2019, 11:14 a.m.)
>
>
> Review request for mesos, Andrei Budnik, Gilbert Song, and James Peach.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> It's possible that sendfile returns less bytes written than requested.
> Previously, we simply return an error in that case. This patch makes it
> more robust by retrying sendfile if less bytes were written than
> requested.
>
>
> Diffs
> -----
>
> src/linux/memfd.cpp PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/69944/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Jie Yu
>
>