You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/05/07 07:35:24 UTC

[GitHub] [flink] lamber-ken commented on a change in pull request #8306: [FLINK-12342] Add fast-heartbeat-delay yarn config for jobs with large number of containers

lamber-ken commented on a change in pull request #8306: [FLINK-12342] Add fast-heartbeat-delay yarn config for  jobs with large number of containers
URL: https://github.com/apache/flink/pull/8306#discussion_r281505022
 
 

 ##########
 File path: flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManager.java
 ##########
 @@ -514,8 +514,7 @@ private void requestYarnContainer() {
 		resourceManagerClient.addContainerRequest(getContainerRequest());
 
 		// make sure we transmit the request fast and receive fast news of granted allocations
-		resourceManagerClient.setHeartbeatInterval(FAST_YARN_HEARTBEAT_INTERVAL_MS);
-
+		resourceManagerClient.setHeartbeatInterval(containerRequestHeartbeatIntervalMillis);
 
 Review comment:
   Hi, @tillrohrmann  @HuangZhenQiu, `resourceManagerClient.setHeartbeatInterval(containerRequestHeartbeatIntervalMillis);` need set the value when `requestYarnContainer` called each time?  thanks.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services