[GitHub] [hadoop] ZanderXu commented on a diff in pull request #5123: HDFS-16837. [RBF SBN] ClientGSIContext should merge RouterFederatedStates to get the max state id for each namespaces

[GitBox <gi...@apache.org>]

ZanderXu commented on code in PR #5123:
URL: https://github.com/apache/hadoop/pull/5123#discussion_r1021133501


##########
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/ClientGSIContext.java:
##########
@@ -77,11 +83,51 @@ public void updateResponseState(RpcResponseHeaderProto.Builder header) {
   @Override
   public synchronized void receiveResponseState(RpcResponseHeaderProto header) {
     if (header.hasRouterFederatedState()) {
-      routerFederatedState = header.getRouterFederatedState();
+      routerFederatedState = mergeRouterFederatedState(header.getRouterFederatedState());
     } else {
       lastSeenStateId.accumulate(header.getStateId());
     }
   }
+  /**
+   * Utility function to parse routerFederatedState field in RPC headers.
+   */
+  public static Map<String, Long> getRouterFederatedStateMap(ByteString byteString) {
+    if (byteString == null) {
+      return Collections.emptyMap();
+    }
+
+    RouterFederatedStateProto federatedState;
+    try {
+      federatedState = RouterFederatedStateProto.parseFrom(byteString);
+    } catch (InvalidProtocolBufferException e) {
+      throw new RuntimeException(e);
+    }
+    return federatedState.getNamespaceStateIdsMap();
+  }
+
+  /**
+   * Merge the local FederatedState and RemoteFederateState to get the max value for each namespace.
+   * @param remoteState the remote RouterFederatedState.
+   * @return one ByteString object which contains the max value of each namespace.
+   */
+  private ByteString mergeRouterFederatedState(ByteString remoteState) {
+    Map<String, Long> localMapping = new HashMap<>(
+        getRouterFederatedStateMap(this.routerFederatedState));
+    Map<String, Long> remoteMapping = getRouterFederatedStateMap(remoteState);
+    remoteMapping.forEach((k, v) -> {
+      long localValue = localMapping.getOrDefault(k, 0L);
+      localMapping.put(k, Math.max(v, localValue));
+    });
+
+    for (String ns : remoteMapping.keySet()) {

Review Comment:
   Thanks, sir. Updated



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org