You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Michael Park <mc...@gmail.com> on 2014/12/05 09:57:50 UTC

Re: Review Request 28722: Modify libprocess configure.ac to set $with_svn to `brew --prefix subversion` for OS X. Fixes MESOS-2113.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28722/
-----------------------------------------------------------

(Updated Dec. 5, 2014, 8:57 a.m.)


Review request for mesos and Timothy Chen.


Bugs: MESOS-2113
    https://issues.apache.org/jira/browse/MESOS-2113


Repository: mesos-git


Description
-------

Modify libprocess configure.ac to set `$with_svn` to `brew --prefix subversion` for OS X. Fixes MESOS-2113.


Diffs
-----

  3rdparty/libprocess/configure.ac 314c8b842d07e1344659449866f7e85c48854204 

Diff: https://reviews.apache.org/r/28722/diff/


Testing
-------

`../configure && make && make check` on Ubuntu and OS X


Thanks,

Michael Park


Re: Review Request 28722: Modify libprocess configure.ac to set $with_svn to `brew --prefix subversion` for OS X. Fixes MESOS-2113.

Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28722/#review64094
-----------------------------------------------------------

Ship it!



3rdparty/libprocess/configure.ac
<https://reviews.apache.org/r/28722/#comment106517>

    See my comments on https://reviews.apache.org/r/28721/


- Till Toenshoff


On Dec. 5, 2014, 8:57 a.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28722/
> -----------------------------------------------------------
> 
> (Updated Dec. 5, 2014, 8:57 a.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Bugs: MESOS-2113
>     https://issues.apache.org/jira/browse/MESOS-2113
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Modify libprocess configure.ac to set `$with_svn` to `brew --prefix subversion` for OS X. Fixes MESOS-2113.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/configure.ac 314c8b842d07e1344659449866f7e85c48854204 
> 
> Diff: https://reviews.apache.org/r/28722/diff/
> 
> 
> Testing
> -------
> 
> `../configure && make && make check` on Ubuntu and OS X
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Re: Review Request 28722: Modify libprocess configure.ac to set $with_svn to `brew --prefix subversion` for OS X. Fixes MESOS-2113.

Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28722/#review64122
-----------------------------------------------------------


Patch looks great!

Reviews applied: [28722]

All tests passed.

- Mesos ReviewBot


On Dec. 5, 2014, 10:05 p.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28722/
> -----------------------------------------------------------
> 
> (Updated Dec. 5, 2014, 10:05 p.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Bugs: MESOS-2113
>     https://issues.apache.org/jira/browse/MESOS-2113
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Modify libprocess configure.ac to set `$with_svn` to `brew --prefix subversion` for OS X. Fixes MESOS-2113.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/configure.ac 314c8b842d07e1344659449866f7e85c48854204 
> 
> Diff: https://reviews.apache.org/r/28722/diff/
> 
> 
> Testing
> -------
> 
> `../configure && make && make check` on Ubuntu and OS X
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Re: Review Request 28722: Modify libprocess configure.ac to set $with_svn to `brew --prefix subversion` for OS X. Fixes MESOS-2113.

Posted by Michael Park <mc...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28722/
-----------------------------------------------------------

(Updated Dec. 5, 2014, 10:05 p.m.)


Review request for mesos and Timothy Chen.


Bugs: MESOS-2113
    https://issues.apache.org/jira/browse/MESOS-2113


Repository: mesos-git


Description
-------

Modify libprocess configure.ac to set `$with_svn` to `brew --prefix subversion` for OS X. Fixes MESOS-2113.


Diffs (updated)
-----

  3rdparty/libprocess/configure.ac 314c8b842d07e1344659449866f7e85c48854204 

Diff: https://reviews.apache.org/r/28722/diff/


Testing
-------

`../configure && make && make check` on Ubuntu and OS X


Thanks,

Michael Park


Re: Review Request 28722: Modify libprocess configure.ac to set $with_svn to `brew --prefix subversion` for OS X. Fixes MESOS-2113.

Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28722/#review63980
-----------------------------------------------------------


Patch looks great!

Reviews applied: [28722]

All tests passed.

- Mesos ReviewBot


On Dec. 5, 2014, 8:57 a.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28722/
> -----------------------------------------------------------
> 
> (Updated Dec. 5, 2014, 8:57 a.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Bugs: MESOS-2113
>     https://issues.apache.org/jira/browse/MESOS-2113
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Modify libprocess configure.ac to set `$with_svn` to `brew --prefix subversion` for OS X. Fixes MESOS-2113.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/configure.ac 314c8b842d07e1344659449866f7e85c48854204 
> 
> Diff: https://reviews.apache.org/r/28722/diff/
> 
> 
> Testing
> -------
> 
> `../configure && make && make check` on Ubuntu and OS X
> 
> 
> Thanks,
> 
> Michael Park
> 
>