[GitHub] [incubator-superset] kovrus commented on a change in pull request #7057: feat: use strict ISO8601 datetime format in postgres engine spec

[GitBox <gi...@apache.org>]

kovrus commented on a change in pull request #7057: feat: use strict ISO8601 datetime format in postgres engine spec
URL: https://github.com/apache/incubator-superset/pull/7057#discussion_r267652370
 
 

 ##########
 File path: superset/db_engine_specs.py
 ##########
 @@ -535,6 +535,10 @@ def get_timestamp_column(expression, column_name):
             return f'"{column_name}"'
         return column_name
 
+    @classmethod
+    def convert_dttm(cls, target_type, dttm):
+        return "'{}'".format(dttm.strftime('%Y-%m-%dT%H:%M:%S'))
 
 Review comment:
   No, this one has the time designator, the parent's class method has whitespace instead. Please see a bit more detailed explanation in the PR description.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org