You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomee.apache.org by GitBox <gi...@apache.org> on 2019/06/18 21:09:35 UTC
[GitHub] [tomee] cesarhernandezgt commented on a change in pull request
#488: Performance tests for XA example
cesarhernandezgt commented on a change in pull request #488: Performance tests for XA example
URL: https://github.com/apache/tomee/pull/488#discussion_r295000246
##########
File path: examples/xa-datasource/src/main/webapp/WEB-INF/resources.xml
##########
@@ -0,0 +1,46 @@
+<resources>
+
+ <Resource id="movieDatabase" type="DataSource">
+ JdbcDriver org.apache.derby.jdbc.EmbeddedXADataSource
+ JdbcUrl jdbc:derby:testdb;create=true
+ UserName admin
+ Password admin
+ ValidationQuery=values 1
+ InitialSize=2
+ MaxActive=128
+ MaxIdle=25
+ MinIdle=10
+ TestWhileIdle=true
+ TestOnBorrow=false
+ TestOnReturn=false
+ AccessToUnderlyingConnectionAllowed=true
+ TimeBetweenEvictionRuns=1 minute
+ MaxWaitTime=0 seconds
+ JtaManaged=true
+ PoolPreparedStatements=true
+ MaxOpenPreparedStatements=1024
+ User=admin
+ DatabaseName=testdb
+ CreateDatabase=true
+ </Resource>
+ <Resource id="movieDatabaseUnmanaged" type="DataSource">
+ JdbcDriver org.apache.derby.jdbc.EmbeddedDriver
+ JdbcUrl jdbc:derby:testdb;create=true
+ UserName admin
+ Password admin
+ ValidationQuery=values 1
+ InitialSize=2
+ MaxActive=128
+ MaxIdle=25
+ MinIdle=10
+ TestWhileIdle=true
+ TestOnBorrow=false
+ TestOnReturn=false
+ AccessToUnderlyingConnectionAllowed=true
+ TimeBetweenEvictionRuns=1 minute
+ MaxWaitTime=0 seconds
+ JtaManaged=false
+ PoolPreparedStatements=true
Review comment:
`PoolPreparedStatements ` and `MaxOpenPreparedStatements` causes the following warnings:
```
18-Jun-2019 13:30:53.360 INFO [main] org.apache.openejb.assembler.classic.Assembler.createRecipe Creating Resource(id=dbtest/movieDatabaseUnmanaged)
18-Jun-2019 13:30:54.272 WARNING [main] org.apache.openejb.assembler.classic.Assembler.unusedProperty unused property 'MaxOpenPreparedStatements' for resource 'dbtest/movieDatabaseUnmanaged'
18-Jun-2019 13:30:54.273 WARNING [main] org.apache.openejb.assembler.classic.Assembler.unusedProperty unused property 'PoolPreparedStatements' for resource 'dbtest/movieDatabaseUnmanaged'
```
As stated in Tomcat 8.x jdbc documentation, both properties are note used:
https://tomcat.apache.org/tomcat-8.0-doc/jdbc-pool.html
I would recomend deleting both properties from this `resources.xml`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services