You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@helix.apache.org by Vinayak Borkar <vi...@apache.org> on 2015/05/22 01:09:18 UTC
Review Request 34573: [HELIX-597] Added dropStateModelDef method to
HelixAdmin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34573/
-----------------------------------------------------------
Review request for helix and Kishore Gopalakrishna.
Repository: helix-git
Description
-------
This patch adds a dropStateModelDef call to HelixAdmin (and ZKHelixAdmin).
Diffs
-----
helix-core/src/main/java/org/apache/helix/HelixAdmin.java 5337cdd
helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixAdmin.java dee343f
Diff: https://reviews.apache.org/r/34573/diff/
Testing
-------
Thanks,
Vinayak Borkar
Re: Review Request 34573: [HELIX-597] Added dropStateModelDef method
to HelixAdmin
Posted by Vinayak Borkar <vi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34573/
-----------------------------------------------------------
(Updated May 22, 2015, 4:57 a.m.)
Review request for helix and Kishore Gopalakrishna.
Changes
-------
Incorporated review comments
Repository: helix-git
Description
-------
This patch adds a dropStateModelDef call to HelixAdmin (and ZKHelixAdmin).
Diffs (updated)
-----
helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixAdmin.java 530bcf9
Diff: https://reviews.apache.org/r/34573/diff/
Testing
-------
Thanks,
Vinayak Borkar
Re: Review Request 34573: [HELIX-597] Added dropStateModelDef method
to HelixAdmin
Posted by Kishore Gopalakrishna <ki...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34573/#review84847
-----------------------------------------------------------
Ship it!
Ship It!
helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixAdmin.java
<https://reviews.apache.org/r/34573/#comment136256>
better to have a log statement here when its deleted.
And if it does not exist, say that stateModelDef does not exist
After deleting, check that it does not exist any more.
- Kishore Gopalakrishna
On May 21, 2015, 11:09 p.m., Vinayak Borkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34573/
> -----------------------------------------------------------
>
> (Updated May 21, 2015, 11:09 p.m.)
>
>
> Review request for helix and Kishore Gopalakrishna.
>
>
> Repository: helix-git
>
>
> Description
> -------
>
> This patch adds a dropStateModelDef call to HelixAdmin (and ZKHelixAdmin).
>
>
> Diffs
> -----
>
> helix-core/src/main/java/org/apache/helix/HelixAdmin.java 5337cdd
> helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixAdmin.java dee343f
>
> Diff: https://reviews.apache.org/r/34573/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Vinayak Borkar
>
>