You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/03/01 22:45:42 UTC

[GitHub] tqchen commented on a change in pull request #9946: [DO NOT MERGE] Start CI docker revamp

tqchen commented on a change in pull request #9946: [DO NOT MERGE] Start CI docker revamp
URL: https://github.com/apache/incubator-mxnet/pull/9946#discussion_r171718429
 
 

 ##########
 File path: tests/ci_build/Dockerfile.cpu_clang
 ##########
 @@ -1,21 +0,0 @@
-FROM ubuntu:16.04
-
-COPY install/ubuntu_install_core.sh /install/
 
 Review comment:
   The problem of putting installation bash into in a centralized location, is that change of a single bash will trigger rebuild of entire docker image. 
   
   Having separate bash script is actually preferred and makes it easier to tweak new installations by putting them in the end to take benefit of the cache

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services