You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2022/07/18 23:15:12 UTC

[GitHub] [netbeans] ratcashdev commented on a diff in pull request #3995: Support JUnit5 nested test classes

ratcashdev commented on code in PR #3995:
URL: https://github.com/apache/netbeans/pull/3995#discussion_r923931497


##########
java/gradle.java/src/org/netbeans/modules/gradle/java/GradleJavaTokenProvider.java:
##########
@@ -99,11 +99,25 @@ private void processSelectedMethod(final Map<String, String> map, Lookup context
         if ((fo != null) && fo.isData()) {
             GradleJavaProject gjp = GradleJavaProject.get(project);
             String className = evaluateClassName(gjp, fo);
-            String selectedMethod = method != null ? className + '.' + method.getMethodName() : className;
+            String selectedMethod = fullyQualifiedMethodName(className, method);
             map.put(SELECTED_METHOD, selectedMethod);
         }
     }
 
+    private String fullyQualifiedMethodName(String className, SingleMethod singleMethod) {
+        if(singleMethod == null) {
+            return className;
+        }
+        StringBuilder sb = new StringBuilder();

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists