You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@storm.apache.org by GitBox <gi...@apache.org> on 2020/06/02 19:50:28 UTC

[GitHub] [storm] agresch commented on a change in pull request #3277: STORM-3641 upgrade metrics API for JCQueue

agresch commented on a change in pull request #3277:
URL: https://github.com/apache/storm/pull/3277#discussion_r434137184



##########
File path: storm-client/src/jvm/org/apache/storm/daemon/worker/WorkerTransfer.java
##########
@@ -65,8 +67,10 @@
                                                + Config.TOPOLOGY_TRANSFER_BUFFER_SIZE + ":" + xferQueueSz);
         }
 
+        List<Integer> taskIds = new ArrayList<>();
+        taskIds.add(-1);
         this.transferQueue = new JCQueue("worker-transfer-queue", xferQueueSz, 0, xferBatchSz, backPressureWaitStrategy,
-            workerState.getTopologyId(), Constants.SYSTEM_COMPONENT_ID, -1, workerState.getPort(),
+            workerState.getTopologyId(), Constants.SYSTEM_COMPONENT_ID, taskIds, workerState.getPort(),

Review comment:
       these changes were all made and squashed




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org