You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2010/10/09 09:16:29 UTC

DO NOT REPLY [Bug 50064] New: bundle-ify the taglibs jars

https://issues.apache.org/bugzilla/show_bug.cgi?id=50064

           Summary: bundle-ify the taglibs jars
           Product: Taglibs
           Version: 1.2.0
          Platform: PC
        OS/Version: Windows XP
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Standard Taglib
        AssignedTo: dev@tomcat.apache.org
        ReportedBy: rwonly@gmail.com


Hi Devs,

Hope tomcat community can consider bundle-ify the jars so that they can be used
in OSGi framework. Currently, we have to make the bundles by ourselves. There
are two approaches to achieve this.
One is bundle-ify the "spec" and "impl" jars directly. 
The other one is make a separate mvn project to do this job and bind the two
jar together as a bundle. As shown in the patch.

Any comments about this idea?

-Rex

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


DO NOT REPLY [Bug 50064] bundle-ify the taglibs jars

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50064

--- Comment #4 from Rex Wang <rw...@gmail.com> 2010-10-26 02:03:44 EDT ---
Created an attachment (id=26211)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=26211)
the patch for impl and spec

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


DO NOT REPLY [Bug 50064] bundle-ify the taglibs jars

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50064

--- Comment #10 from Rex Wang <rw...@gmail.com> 2010-12-21 21:43:05 EST ---
hi 

should we also remove the dependency in jstlel and compat?
    <dependency>
      <groupId>xalan</groupId>
      <artifactId>xalan</artifactId>
      <version>2.7.1</version>
      <scope>provided</scope>
    </dependency>


I did not find any class import the packages from xalan in these two projects.

-Rex

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


DO NOT REPLY [Bug 50064] bundle-ify the taglibs jars

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50064

Bug 50064 depends on bug 50414, which changed state.

Bug 50414 Summary: tlv package cause another split package issue in impl and jstlel bundles
https://issues.apache.org/bugzilla/show_bug.cgi?id=50414

           What    |Old Value                   |New Value
----------------------------------------------------------------------------
             Status|NEEDINFO                    |RESOLVED
         Resolution|                            |FIXED

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


DO NOT REPLY [Bug 50064] bundle-ify the taglibs jars

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50064

--- Comment #2 from Jeremy Boynes <jb...@apache.org> 2010-10-16 14:51:08 EDT ---
Should we add the meta-data to all jars anyway (option 1)? Could you provide a
patch to the POMs to run the OSGi plugins?

If we produce a bundle of spec and impl, would it just expose the spec API and
keep the impl internal? Would this work with a standalone JSP container where
the JSTL library would be in the webapp rather than the container classpath?

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


DO NOT REPLY [Bug 50064] bundle-ify the taglibs jars

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50064

--- Comment #8 from Jeremy Boynes <jb...@apache.org> 2010-11-13 12:12:24 EST ---
I'm seeing the following warning for the compat and jstlel modules:

[WARNING] Warning building bundle
org.apache.taglibs:taglibs-standard-compat:bundle:1.2-SNAPSHOT : Did not find
matching referal for org.apache.x*

Do we need to add something to their configuration?

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


DO NOT REPLY [Bug 50064] bundle-ify the taglibs jars

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50064

--- Comment #1 from Rex Wang <rw...@gmail.com> 2010-10-09 03:20:20 EDT ---
Created an attachment (id=26145)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=26145)
A patch for approach #2

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


DO NOT REPLY [Bug 50064] bundle-ify the taglibs jars

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50064

Bug 50064 depends on bug 50462, which changed state.

Bug 50462 Summary: xalan import should not be optional in maven-bundle-plugin
https://issues.apache.org/bugzilla/show_bug.cgi?id=50462

           What    |Old Value                   |New Value
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: [taglibs] [Bug 50064] bundle-ify the taglibs jars

Posted by Rex Wang <rw...@gmail.com>.
Thank you very much!

I will pull in the bundles to Geronimo to have a try.

-Rex

2010/11/4 Jeremy Boynes <jb...@apache.org>

> On Nov 1, 2010, at 9:15 PM, Jeremy Boynes wrote:
>
> > On Nov 1, 2010, at 7:42 PM, Rex Wang wrote:
> >
> >> Thanks Jeremy,
> >>
> >> Is that because the group id dose not start with org.apache.tomcat...?
> >
> > I think so. I opened the issue asking for org.apache.taglibs to be added
> as that's the current group id.
> >       https://issues.apache.org/jira/browse/INFRA-3129
> >
>
> Group has been enabled. A build of r1030841 to the snapshot repo. Hope it
> works :-)
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
>


-- 
Lei Wang (Rex)
rwonly AT apache.org

Re: [taglibs] [Bug 50064] bundle-ify the taglibs jars

Posted by Rex Wang <rw...@gmail.com>.
Ok, thanks all for the comments, I will pull them into trunk.

Hi Rick, the tomcat taglibs has been bundlized based on our requirements.
But they don't tie the spec and impl into one bundle like the jstl bundle we
made. I have try the separate bundles in our build, and it works fine.

-Rex

2010/11/8 Rick McGuire <ri...@gmail.com>

> On 11/8/2010 1:34 AM, David Jencks wrote:
>
>> I agree.
>>
>> Thanks for getting these bundlized!
>>
>
> I agree also.  Is there any chance we can get the Tomcat community to
> create these as bundles directly rather than creating our own?  Either way,
> I think we should attempt the switch.


> Rick
>
>
>  david jencks
>>
>> On Nov 7, 2010, at 6:42 PM, Shawn Jiang wrote:
>>
>>  We should try it.
>>>
>>> If there's anything wrong that we could not fix in a short term, we
>>> can always revert it from m2 release.
>>>
>>> On Mon, Nov 8, 2010 at 9:37 AM, Rex Wang<rw...@gmail.com>  wrote:
>>>
>>>> Hi devs,
>>>>
>>>> Tomcat has deployed their first taglibs jars to apache.snapshot. I am
>>>> thinking if we should pull in the bundles to trunk to replace the our
>>>> internal jstl build. The only concern is if this work might impact the
>>>> M2
>>>> release. Any thoughts?
>>>>
>>>> -Rex
>>>>
>>>>
>>>> ---------- Forwarded message ----------
>>>> From: Jeremy Boynes<jb...@apache.org>
>>>> Date: 2010/11/4
>>>> Subject: Re: [taglibs] [Bug 50064] bundle-ify the taglibs jars
>>>> To: Tomcat Developers List<de...@tomcat.apache.org>
>>>>
>>>>
>>>> On Nov 1, 2010, at 9:15 PM, Jeremy Boynes wrote:
>>>>
>>>>  On Nov 1, 2010, at 7:42 PM, Rex Wang wrote:
>>>>>
>>>>>  Thanks Jeremy,
>>>>>>
>>>>>> Is that because the group id dose not start with org.apache.tomcat...?
>>>>>>
>>>>> I think so. I opened the issue asking for org.apache.taglibs to be
>>>>> added
>>>>> as that's the current group id.
>>>>>       https://issues.apache.org/jira/browse/INFRA-3129
>>>>>
>>>>>  Group has been enabled. A build of r1030841 to the snapshot repo. Hope
>>>> it
>>>> works :-)
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
>>>> For additional commands, e-mail: dev-help@tomcat.apache.org
>>>>
>>>>
>>>>
>>>>
>>>> --
>>>> Lei Wang (Rex)
>>>> rwonly AT apache.org
>>>>
>>>>
>>>
>>> --
>>> Shawn
>>>
>>
>>
>


-- 
Lei Wang (Rex)
rwonly AT apache.org

Re: [taglibs] [Bug 50064] bundle-ify the taglibs jars

Posted by Rick McGuire <ri...@gmail.com>.
On 11/8/2010 1:34 AM, David Jencks wrote:
> I agree.
>
> Thanks for getting these bundlized!

I agree also.  Is there any chance we can get the Tomcat community to 
create these as bundles directly rather than creating our own?  Either 
way, I think we should attempt the switch.

Rick

> david jencks
>
> On Nov 7, 2010, at 6:42 PM, Shawn Jiang wrote:
>
>> We should try it.
>>
>> If there's anything wrong that we could not fix in a short term, we
>> can always revert it from m2 release.
>>
>> On Mon, Nov 8, 2010 at 9:37 AM, Rex Wang<rw...@gmail.com>  wrote:
>>> Hi devs,
>>>
>>> Tomcat has deployed their first taglibs jars to apache.snapshot. I am
>>> thinking if we should pull in the bundles to trunk to replace the our
>>> internal jstl build. The only concern is if this work might impact the M2
>>> release. Any thoughts?
>>>
>>> -Rex
>>>
>>>
>>> ---------- Forwarded message ----------
>>> From: Jeremy Boynes<jb...@apache.org>
>>> Date: 2010/11/4
>>> Subject: Re: [taglibs] [Bug 50064] bundle-ify the taglibs jars
>>> To: Tomcat Developers List<de...@tomcat.apache.org>
>>>
>>>
>>> On Nov 1, 2010, at 9:15 PM, Jeremy Boynes wrote:
>>>
>>>> On Nov 1, 2010, at 7:42 PM, Rex Wang wrote:
>>>>
>>>>> Thanks Jeremy,
>>>>>
>>>>> Is that because the group id dose not start with org.apache.tomcat...?
>>>> I think so. I opened the issue asking for org.apache.taglibs to be added
>>>> as that's the current group id.
>>>>        https://issues.apache.org/jira/browse/INFRA-3129
>>>>
>>> Group has been enabled. A build of r1030841 to the snapshot repo. Hope it
>>> works :-)
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
>>> For additional commands, e-mail: dev-help@tomcat.apache.org
>>>
>>>
>>>
>>>
>>> --
>>> Lei Wang (Rex)
>>> rwonly AT apache.org
>>>
>>
>>
>> -- 
>> Shawn
>


Re: [taglibs] [Bug 50064] bundle-ify the taglibs jars

Posted by David Jencks <da...@yahoo.com>.
I agree.

Thanks for getting these bundlized!

david jencks

On Nov 7, 2010, at 6:42 PM, Shawn Jiang wrote:

> We should try it.
> 
> If there's anything wrong that we could not fix in a short term, we
> can always revert it from m2 release.
> 
> On Mon, Nov 8, 2010 at 9:37 AM, Rex Wang <rw...@gmail.com> wrote:
>> Hi devs,
>> 
>> Tomcat has deployed their first taglibs jars to apache.snapshot. I am
>> thinking if we should pull in the bundles to trunk to replace the our
>> internal jstl build. The only concern is if this work might impact the M2
>> release. Any thoughts?
>> 
>> -Rex
>> 
>> 
>> ---------- Forwarded message ----------
>> From: Jeremy Boynes <jb...@apache.org>
>> Date: 2010/11/4
>> Subject: Re: [taglibs] [Bug 50064] bundle-ify the taglibs jars
>> To: Tomcat Developers List <de...@tomcat.apache.org>
>> 
>> 
>> On Nov 1, 2010, at 9:15 PM, Jeremy Boynes wrote:
>> 
>>> On Nov 1, 2010, at 7:42 PM, Rex Wang wrote:
>>> 
>>>> Thanks Jeremy,
>>>> 
>>>> Is that because the group id dose not start with org.apache.tomcat...?
>>> 
>>> I think so. I opened the issue asking for org.apache.taglibs to be added
>>> as that's the current group id.
>>>       https://issues.apache.org/jira/browse/INFRA-3129
>>> 
>> 
>> Group has been enabled. A build of r1030841 to the snapshot repo. Hope it
>> works :-)
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
>> For additional commands, e-mail: dev-help@tomcat.apache.org
>> 
>> 
>> 
>> 
>> --
>> Lei Wang (Rex)
>> rwonly AT apache.org
>> 
> 
> 
> 
> -- 
> Shawn


Re: [taglibs] [Bug 50064] bundle-ify the taglibs jars

Posted by Shawn Jiang <ge...@gmail.com>.
We should try it.

 If there's anything wrong that we could not fix in a short term, we
can always revert it from m2 release.

On Mon, Nov 8, 2010 at 9:37 AM, Rex Wang <rw...@gmail.com> wrote:
> Hi devs,
>
> Tomcat has deployed their first taglibs jars to apache.snapshot. I am
> thinking if we should pull in the bundles to trunk to replace the our
> internal jstl build. The only concern is if this work might impact the M2
> release. Any thoughts?
>
> -Rex
>
>
> ---------- Forwarded message ----------
> From: Jeremy Boynes <jb...@apache.org>
> Date: 2010/11/4
> Subject: Re: [taglibs] [Bug 50064] bundle-ify the taglibs jars
> To: Tomcat Developers List <de...@tomcat.apache.org>
>
>
> On Nov 1, 2010, at 9:15 PM, Jeremy Boynes wrote:
>
>> On Nov 1, 2010, at 7:42 PM, Rex Wang wrote:
>>
>>> Thanks Jeremy,
>>>
>>> Is that because the group id dose not start with org.apache.tomcat...?
>>
>> I think so. I opened the issue asking for org.apache.taglibs to be added
>> as that's the current group id.
>>       https://issues.apache.org/jira/browse/INFRA-3129
>>
>
> Group has been enabled. A build of r1030841 to the snapshot repo. Hope it
> works :-)
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
>
>
>
> --
> Lei Wang (Rex)
> rwonly AT apache.org
>



-- 
Shawn

Fwd: [taglibs] [Bug 50064] bundle-ify the taglibs jars

Posted by Rex Wang <rw...@gmail.com>.
Hi devs,

Tomcat has deployed their first taglibs jars to apache.snapshot. I am
thinking if we should pull in the bundles to trunk to replace the our
internal jstl build. The only concern is if this work might impact the M2
release. Any thoughts?

-Rex


---------- Forwarded message ----------
From: Jeremy Boynes <jb...@apache.org>
Date: 2010/11/4
Subject: Re: [taglibs] [Bug 50064] bundle-ify the taglibs jars
To: Tomcat Developers List <de...@tomcat.apache.org>


On Nov 1, 2010, at 9:15 PM, Jeremy Boynes wrote:

> On Nov 1, 2010, at 7:42 PM, Rex Wang wrote:
>
>> Thanks Jeremy,
>>
>> Is that because the group id dose not start with org.apache.tomcat...?
>
> I think so. I opened the issue asking for org.apache.taglibs to be added
as that's the current group id.
>       https://issues.apache.org/jira/browse/INFRA-3129
>

Group has been enabled. A build of r1030841 to the snapshot repo. Hope it
works :-)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org




-- 
Lei Wang (Rex)
rwonly AT apache.org

Re: [taglibs] [Bug 50064] bundle-ify the taglibs jars

Posted by Jeremy Boynes <jb...@apache.org>.
On Nov 1, 2010, at 9:15 PM, Jeremy Boynes wrote:

> On Nov 1, 2010, at 7:42 PM, Rex Wang wrote:
> 
>> Thanks Jeremy,
>> 
>> Is that because the group id dose not start with org.apache.tomcat...?
> 
> I think so. I opened the issue asking for org.apache.taglibs to be added as that's the current group id.
> 	https://issues.apache.org/jira/browse/INFRA-3129
> 

Group has been enabled. A build of r1030841 to the snapshot repo. Hope it works :-)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: [taglibs] [Bug 50064] bundle-ify the taglibs jars

Posted by Jeremy Boynes <jb...@apache.org>.
On Nov 1, 2010, at 7:42 PM, Rex Wang wrote:

> Thanks Jeremy,
> 
> Is that because the group id dose not start with org.apache.tomcat...?

I think so. I opened the issue asking for org.apache.taglibs to be added as that's the current group id.
	https://issues.apache.org/jira/browse/INFRA-3129


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: [taglibs] [Bug 50064] bundle-ify the taglibs jars

Posted by Rex Wang <rw...@gmail.com>.
Thanks Jeremy,

Is that because the group id dose not start with org.apache.tomcat...?

2010/11/1 Jeremy Boynes <jb...@apache.org>

> Patch applied but unable to deploy to the snapshot repository.
> I don't see an entry for taglibs in Nexus so opening a issue with them to
> get us created.
>
> On Oct 31, 2010, at 11:26 AM, bugzilla@apache.org wrote:
>
> > https://issues.apache.org/bugzilla/show_bug.cgi?id=50064
> >
> > --- Comment #7 from Jeremy Boynes <jb...@apache.org> 2010-10-31
> 14:26:45 EDT ---
> > Patches applied, thanks.
> >
> > --
> > Configure bugmail:
> https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
> > ------- You are receiving this mail because: -------
> > You are the assignee for the bug.
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> > For additional commands, e-mail: dev-help@tomcat.apache.org
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
>


-- 
Lei Wang (Rex)
rwonly AT apache.org

[taglibs] [Bug 50064] bundle-ify the taglibs jars

Posted by Jeremy Boynes <jb...@apache.org>.
Patch applied but unable to deploy to the snapshot repository.
I don't see an entry for taglibs in Nexus so opening a issue with them to get us created.

On Oct 31, 2010, at 11:26 AM, bugzilla@apache.org wrote:

> https://issues.apache.org/bugzilla/show_bug.cgi?id=50064
> 
> --- Comment #7 from Jeremy Boynes <jb...@apache.org> 2010-10-31 14:26:45 EDT ---
> Patches applied, thanks.
> 
> -- 
> Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
> ------- You are receiving this mail because: -------
> You are the assignee for the bug.
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


DO NOT REPLY [Bug 50064] bundle-ify the taglibs jars

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50064

--- Comment #7 from Jeremy Boynes <jb...@apache.org> 2010-10-31 14:26:45 EDT ---
Patches applied, thanks.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


DO NOT REPLY [Bug 50064] bundle-ify the taglibs jars

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50064

--- Comment #5 from Rex Wang <rw...@gmail.com> 2010-10-26 02:04:30 EDT ---
Created an attachment (id=26212)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=26212)
the patch for parent pom

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


DO NOT REPLY [Bug 50064] bundle-ify the taglibs jars

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50064

--- Comment #6 from Rex Wang <rw...@gmail.com> 2010-10-26 02:08:12 EDT ---
Hi Jeremy,

If you decide apply the patches. Could you please deploy the build artifacts to
Apache snapshot site after that? Then we can run the TCK to test the jstl
bundles in the Geronimo community.

regards,

-Rex

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


DO NOT REPLY [Bug 50064] bundle-ify the taglibs jars

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50064

--- Comment #3 from Rex Wang <rw...@gmail.com> 2010-10-26 02:02:05 EDT ---


(In reply to comment #2)
> Should we add the meta-data to all jars anyway (option 1)? Could you provide a
> patch to the POMs to run the OSGi plugins?

Hi Jeremy,
Sure, the attachment are the 2 patches for option #1.
One for impl and spec;
One for parent.

> 
> If we produce a bundle of spec and impl, would it just expose the spec API and
> keep the impl internal? Would this work with a standalone JSP container where
> the JSTL library would be in the webapp rather than the container classpath?

I not sure I understand the situation. A OSGi bundle is a normal jar with some
special metadatas in MANIFEST.MF, so I think the EXPORT header won't take any
effect when the bundle is put in normal Java class path. It will just be
considered as a normal jar.


thanks
-Rex

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


DO NOT REPLY [Bug 50064] bundle-ify the taglibs jars

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50064

Jeremy Boynes <jb...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #11 from Jeremy Boynes <jb...@apache.org> 2010-12-31 18:33:39 EST ---
Resolving now #50462 has been fixed.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


DO NOT REPLY [Bug 50064] bundle-ify the taglibs jars

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50064

--- Comment #9 from Rex Wang <rw...@gmail.com> 2010-11-14 22:21:51 EST ---
(In reply to comment #8)
> I'm seeing the following warning for the compat and jstlel modules:
> 
> [WARNING] Warning building bundle
> org.apache.taglibs:taglibs-standard-compat:bundle:1.2-SNAPSHOT : Did not find
> matching referal for org.apache.x*
> 
> Do we need to add something to their configuration?

I think that because the jstlel and compat don't need the dependency:
    <dependency>
      <groupId>xalan</groupId>
      <artifactId>xalan</artifactId>
      <version>2.7.1</version>
      <scope>provided</scope>
    </dependency>

you can remove it and also the
    <Import-Package>org.apache.x*;resolution:=optional,*</Import-Package>
in maven-bundle-plugin instructions.

-Rex

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


DO NOT REPLY [Bug 50064] bundle-ify the taglibs jars

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50064

Jeremy Boynes <jb...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |50414, 50462

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org