[GitHub] [incubator-superset] etr2460 commented on pull request #9764: feat: add replace option to hive csv upload

[GitBox <gi...@apache.org>]

etr2460 commented on pull request #9764:
URL: https://github.com/apache/incubator-superset/pull/9764#issuecomment-641582780


   @john-bodley @villebro @willbarrett, this is working and ready for review now.
   
   Unfortunately, it doesn't look like sqlalchemy supports params for structural components of sql (as noted in the stack overflow comment) so I don't think there's anything i can do about this. I've also added one small test to hive_tests, but since this is all untested already (and relies on an s3 url and a bunch of other stuff) I'm not sure how else to add tests here


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org