You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/06/30 12:23:09 UTC

[GitHub] [doris] yinzhijian opened a new pull request, #10530: [fix](nereids) expr.accept(visitor) should be called instead of visitor.visit(expr)

yinzhijian opened a new pull request, #10530:
URL: https://github.com/apache/doris/pull/10530

   # Proposed changes
   
   Issue Number: close #xxx
   
   ## Problem Summary:
   
   1. because visitor.visit is the default method and not the actual handler, expr.accept(visitor) should be called instead of visitor.visit(expr)
   2. fix ut：check bound should be called recursively on the plan node
   
   ## Checklist(Required)
   
   1. Does it affect the original behavior: (No)
   3. Has unit tests been added: (No Need)
   4. Has document been added or modified: (No Need)
   5. Does it need to update dependencies: (No)
   6. Are there any changes that cannot be rolled back: (No)
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] EmmyMiao87 merged pull request #10530: [fix](nereids) fix ut,check bound should be called recursively on the plan node

Posted by GitBox <gi...@apache.org>.
EmmyMiao87 merged PR #10530:
URL: https://github.com/apache/doris/pull/10530


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org