You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ofbiz.apache.org by GitBox <gi...@apache.org> on 2022/01/21 14:46:25 UTC
[GitHub] [ofbiz-framework] PierreSmits opened a new pull request #466: Improved: List and Grid (OFBIZ-11345)
PierreSmits opened a new pull request #466:
URL: https://github.com/apache/ofbiz-framework/pull/466
According to the definition in widget-form.xsd the
use of a combination of a form with type="list" is
deprecated in favour of a grid.
Refactor various list forms into grids.
Refactor various list form references in screens.
modified:
RecruitmentForms.xml: from form definition with list
ref to grid definition with list ref, additional clean-up
Recruitmentcreens.xml: from form ref to grid ref , additional cleanup
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ofbiz-framework] mbrohl commented on pull request #466: Improved: List and Grid (OFBIZ-11345)
Posted by GitBox <gi...@apache.org>.
mbrohl commented on pull request #466:
URL: https://github.com/apache/ofbiz-framework/pull/466#issuecomment-1023328912
@PierreSmits please stop putting words in my mouth which I never said, e.g. "hard coded titles.. are good enough for the project". They aren't.
But trying to fix a bad state with another bad solution is also not good enough for the project.
Introducing common or unspecific labels all over the place without context is simply wrong, as several other contributors pointed out in the past and recent code reviews and Jiras.
They are wrong in the aspect of differences of meaning between languages where context often matters and they also cut functionality by removing the possibility to change labels throughout applications and contexts. They making it harder for users to adjust OFBiz to their individual terminology which can be even different between divisions in the same company.
Those changes are not acceptable for the project. This is not only my personal viewpoint or "dictate" but the view of several others and I have not seen a single other contributor who is in favour of replacing specific labels with common labels in this broad approach.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ofbiz-framework] PierreSmits commented on pull request #466: Improved: List and Grid (OFBIZ-11345)
Posted by GitBox <gi...@apache.org>.
PierreSmits commented on pull request #466:
URL: https://github.com/apache/ofbiz-framework/pull/466#issuecomment-1018633810
Hi @danwatford<
Thanks for the comment. You mentioned that you created some test data to be used with this. Could you share that with the community, so that we can make an even better case why one should use OFBiz?
This may be the root cause of that error:
` <field name="approverPartyId" field-name="partyId">
<display-entity entity-name="PartyNameView" description="${firstName} ${lastName}">
<sub-hyperlink target="/partymgr/control/viewprofile" target-type="inter-app" description="${approverPartyId}" link-style="buttontext">
<parameter param-name="partyId" from-field="approverPartyId"/>
</sub-hyperlink>
</display-entity>
</field>`
Which can be found around line 366 in https://github.com/apache/ofbiz-framework/blob/trunk/applications/humanres/widget/forms/RecruitmentForms.xml
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ofbiz-framework] PierreSmits commented on pull request #466: Improved: List and Grid (OFBIZ-11345)
Posted by GitBox <gi...@apache.org>.
PierreSmits commented on pull request #466:
URL: https://github.com/apache/ofbiz-framework/pull/466#issuecomment-1018687095
My apologies for that, Daniel.
I have put in an amendment to correct that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ofbiz-framework] sonarcloud[bot] removed a comment on pull request #466: Improved: List and Grid (OFBIZ-11345)
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] removed a comment on pull request #466:
URL: https://github.com/apache/ofbiz-framework/pull/466#issuecomment-1018688124
Kudos, SonarCloud Quality Gate passed! 
[](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=466&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=466&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=466&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=466&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=466&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=466&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=466&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=466&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=466&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=466&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=466&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=466&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=466) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=466&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=466&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ofbiz-framework] danwatford commented on a change in pull request #466: Improved: List and Grid (OFBIZ-11345)
Posted by GitBox <gi...@apache.org>.
danwatford commented on a change in pull request #466:
URL: https://github.com/apache/ofbiz-framework/pull/466#discussion_r789783148
##########
File path: applications/humanres/widget/forms/RecruitmentForms.xml
##########
@@ -427,14 +425,14 @@ under the License.
<field-map field-name="viewSize" from-field="viewSize"/>
</service>
</actions>
- <field name="partyId" title="Employee Name">
+ <field name="partyId" title="${UiLabelMap.CommonParty}">
<display-entity entity-name="PartyNameView" description="${firstName} ${middleName} ${lastName} ${groupName}">
<sub-hyperlink target="/partymgr/control/viewprofile" target-type="inter-app" description="${partyId}" link-style="buttontext">
<parameter param-name="partyId" from-field="partyId"/>
</sub-hyperlink>
</display-entity>
</field>
- <field name="emplPositionId" title="${uiLabelMap.HumanResEmployeePositionId}" widget-style="linktext">
+ <field name="emplPositionId" title="${uiLabelMap.CommonPosition" widget-style="linktext">
Review comment:
Missing closing brace following CommonPosition.
##########
File path: applications/humanres/widget/RecruitmentScreens.xml
##########
@@ -302,7 +302,7 @@ under the License.
<include-form name="FindRelocation" location="component://humanres/widget/forms/RecruitmentForms.xml"/>
</decorator-section>
<decorator-section name="search-results">
- <include-form name="ListRelocation" location="component://humanres/widget/forms/RecruitmentForms.xml"/>
+ <include-grid name="ListRelocation" location="component://humanres/widget/forms/RecruitmentForms.xml"/>
Review comment:
With this PR applied, the column header for search results on screen https://localhost:8443/humanres/control/FindRelocation is displayed as `${UILABELMAP.COMMONPOSITION`.
On trunk it is displayed as `EMPLOYEE NAME`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ofbiz-framework] danwatford commented on pull request #466: Improved: List and Grid (OFBIZ-11345)
Posted by GitBox <gi...@apache.org>.
danwatford commented on pull request #466:
URL: https://github.com/apache/ofbiz-framework/pull/466#issuecomment-1018639162
I just created a few dummy records as I went - but I can add something to the demo data, assuming that I properly understand the intent of the fields. Leave it with me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ofbiz-framework] JacquesLeRoux commented on pull request #466: Improved: List and Grid (OFBIZ-11345)
Posted by GitBox <gi...@apache.org>.
JacquesLeRoux commented on pull request #466:
URL: https://github.com/apache/ofbiz-framework/pull/466#issuecomment-1023259680
> <field name="partyId" title="Employee Name"
That's indeed wrong in any cases (in RecruitmentForms.xml), and dates from Jira OFBIZ-2205
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ofbiz-framework] danwatford commented on pull request #466: Improved: List and Grid (OFBIZ-11345)
Posted by GitBox <gi...@apache.org>.
danwatford commented on pull request #466:
URL: https://github.com/apache/ofbiz-framework/pull/466#issuecomment-1023262012
Hi Pierre,
So my difficulty is assessing this PR is that it is changing two different levels of implementation.
The first category of changes are the switch from list forms to grids. This is a technical change where the same pattern of changes can be applied again and again with low risk, allowing the committer to easily comprehend intent.
As soon as we consider the second category of label changes, i.e. the application level, we then need the committer to understand the intention of the application - in this case the HR application and how job requisitions, applications, interviews and relocations work. I personally do not have a good knowledge of that application and have to spend a long time trying to figure out what the original intention was behind the application, and whether the application is broken in some way or whether there is a misunderstanding on the part of the contributor. See rules 1 and 2 here - https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Committers+Roles+and+Responsibilities
The application intent also applies to labels. In the case of position as pertaining to employment, this is similar to the meaning of role. But in English position can also refer to location, status, etc. I only speak one language so have to err on the side of caution when generalising labels as I don't know if it will cause trouble for other languages.
In this specific case I thought it better to return to the hard-coded title, Employee Name, since it seemed the safest way of not breaking the intention of the HR application - or at least not making the intention any worse.
You mentioned the use of ${groupName} being an indicator that groups, in addition to individuals, can be provided relocation. I wouldn't have expected that to be the intention of the HR application in this case, so it may be the case that use of ${groupName} is incorrect in this case, rather than the use of the title 'Employee Name', accepting that hard-coded values are not great. I don't know which is the case and would need to investigate further.
Getting up to speed on the HR application will take time, therefore moving and discussing application intent changes to a different jira ticket or the mailing list would be my preference, hence my reverting of the labelling changes on this PR where there is the potential for ambiguity across languages.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ofbiz-framework] danwatford commented on a change in pull request #466: Improved: List and Grid (OFBIZ-11345)
Posted by GitBox <gi...@apache.org>.
danwatford commented on a change in pull request #466:
URL: https://github.com/apache/ofbiz-framework/pull/466#discussion_r789766578
##########
File path: applications/humanres/widget/RecruitmentScreens.xml
##########
@@ -249,7 +249,7 @@ under the License.
<include-form name="FindApprovals" location="component://humanres/widget/forms/RecruitmentForms.xml"/>
</decorator-section>
<decorator-section name="search-results">
- <include-form name="ListApprovals" location="component://humanres/widget/forms/RecruitmentForms.xml"/>
+ <include-grid name="ListApprovals" location="component://humanres/widget/forms/RecruitmentForms.xml"/>
Review comment:
When testing with data from .`/gradlew loadAll`, plus some job requisitions created while testing earlier screens, I get the following error when searching from https://localhost:8443/humanres/control/FindApprovals.
Note: This error is not related to your PR, @PierreSmits , just mentioning it in case you knew the cause.
```
2022-01-21 15:38:55,042 |sse-nio-8443-exec-16 |ControlServlet |E| Error in request handler:
java.lang.RuntimeException: Error rendering included form named [ListApprovals] at location [component://humanres/widget/forms/RecruitmentForms.xml]: java.lang.NullPointerExceptionjava.lang.NullPointerException
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #466: Improved: List and Grid (OFBIZ-11345)
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #466:
URL: https://github.com/apache/ofbiz-framework/pull/466#issuecomment-1018575036
Kudos, SonarCloud Quality Gate passed! 
[](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=466&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=466&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=466&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=466&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=466&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=466&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=466&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=466&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=466&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=466&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=466&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=466&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=466) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=466&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=466&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #466: Improved: List and Grid (OFBIZ-11345)
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #466:
URL: https://github.com/apache/ofbiz-framework/pull/466#issuecomment-1023121789
Kudos, SonarCloud Quality Gate passed! 
[](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=466&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=466&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=466&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=466&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=466&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=466&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=466&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=466&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=466&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=466&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=466&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=466&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=466) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=466&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=466&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ofbiz-framework] danwatford merged pull request #466: Improved: List and Grid (OFBIZ-11345)
Posted by GitBox <gi...@apache.org>.
danwatford merged pull request #466:
URL: https://github.com/apache/ofbiz-framework/pull/466
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [GitHub] [ofbiz-framework] JacquesLeRoux edited a comment on pull request #466: Improved: List and Grid (OFBIZ-11345)
Posted by Jacques Le Roux <ja...@les7arts.com>.
Le 27/01/2022 à 15:57, Pierre Smits a écrit :
> Playing the 'blame' game is detrimental to the success of the project, and
> thus to all using, contributing, making a living with...
Hi Pierre,
It seems you don't understand why I put "is broken by" references from and in Jiras and GH. It's not at all to play the "blame game".
It to actually allow us to better understand what is happening from where in the past that can be useful in the future.
OFBIZ-7024 and OFBIZ-5341 are related examples that helped me in the task for OFBIZ-12548 that was eventually
https://github.com/apache/ofbiz-framework/commit/7562476e1e7c6cf6bac2be96c74fcc2bf754a58d
HTH
Jacques
Re: [GitHub] [ofbiz-framework] JacquesLeRoux edited a comment on pull request #466: Improved: List and Grid (OFBIZ-11345)
Posted by Pierre Smits <pi...@apache.org>.
Playing the 'blame' game is detrimental to the success of the project, and
thus to all using, contributing, making a living with...
Met vriendelijke groet,
Pierre Smits
*Proud* *contributor** of* Apache OFBiz <https://ofbiz.apache.org/> since
2008 (without privileges)
Proud contributor to the ASF since 2006
*Apache Directory <https://directory.apache.org>, PMC Member*
Anyone could have been you, whereas I've always been anyone.
On Thu, Jan 27, 2022 at 3:55 PM Pierre Smits <pi...@apache.org> wrote:
> Jacques,
>
> It is of lesser importance of from when it dated or who provided the code
> improvement and who merged it in the codebase. What is more important how
> many hulrdles are brought into play to get it improved.
>
>
> Met vriendelijke groet,
>
> Pierre Smits
> *Proud* *contributor** of* Apache OFBiz <https://ofbiz.apache.org/> since
> 2008 (without privileges)
> Proud contributor to the ASF since 2006
> *Apache Directory <https://directory.apache.org>, PMC Member*
>
> Anyone could have been you, whereas I've always been anyone.
>
>
> On Thu, Jan 27, 2022 at 3:21 PM GitBox <gi...@apache.org> wrote:
>
>>
>> JacquesLeRoux edited a comment on pull request #466:
>> URL:
>> https://github.com/apache/ofbiz-framework/pull/466#issuecomment-1023259680
>>
>>
>> > <field name="partyId" title="Employee Name"
>>
>> That's indeed wrong in any cases (in RecruitmentForms.xml), and dates
>> from Jira OFBIZ-2205
>>
>>
>> --
>> This is an automated message from the Apache Git Service.
>> To respond to the message, please log on to GitHub and use the
>> URL above to go to the specific comment.
>>
>> To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
>>
>> For queries about this service, please contact Infrastructure at:
>> users@infra.apache.org
>>
>>
>>
Re: [GitHub] [ofbiz-framework] JacquesLeRoux edited a comment on pull request #466: Improved: List and Grid (OFBIZ-11345)
Posted by Pierre Smits <pi...@apache.org>.
Jacques,
It is of lesser importance of from when it dated or who provided the code
improvement and who merged it in the codebase. What is more important how
many hulrdles are brought into play to get it improved.
Met vriendelijke groet,
Pierre Smits
*Proud* *contributor** of* Apache OFBiz <https://ofbiz.apache.org/> since
2008 (without privileges)
Proud contributor to the ASF since 2006
*Apache Directory <https://directory.apache.org>, PMC Member*
Anyone could have been you, whereas I've always been anyone.
On Thu, Jan 27, 2022 at 3:21 PM GitBox <gi...@apache.org> wrote:
>
> JacquesLeRoux edited a comment on pull request #466:
> URL:
> https://github.com/apache/ofbiz-framework/pull/466#issuecomment-1023259680
>
>
> > <field name="partyId" title="Employee Name"
>
> That's indeed wrong in any cases (in RecruitmentForms.xml), and dates
> from Jira OFBIZ-2205
>
>
> --
> This is an automated message from the Apache Git Service.
> To respond to the message, please log on to GitHub and use the
> URL above to go to the specific comment.
>
> To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
>
> For queries about this service, please contact Infrastructure at:
> users@infra.apache.org
>
>
>
[GitHub] [ofbiz-framework] JacquesLeRoux edited a comment on pull request #466: Improved: List and Grid (OFBIZ-11345)
Posted by GitBox <gi...@apache.org>.
JacquesLeRoux edited a comment on pull request #466:
URL: https://github.com/apache/ofbiz-framework/pull/466#issuecomment-1023259680
> <field name="partyId" title="Employee Name"
That's indeed wrong in any cases (in RecruitmentForms.xml), and dates from Jira OFBIZ-2205
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ofbiz-framework] sonarcloud[bot] removed a comment on pull request #466: Improved: List and Grid (OFBIZ-11345)
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] removed a comment on pull request #466:
URL: https://github.com/apache/ofbiz-framework/pull/466#issuecomment-1018575036
Kudos, SonarCloud Quality Gate passed! 
[](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=466&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=466&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=466&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=466&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=466&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=466&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=466&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=466&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=466&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=466&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=466&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=466&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=466) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=466&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=466&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #466: Improved: List and Grid (OFBIZ-11345)
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #466:
URL: https://github.com/apache/ofbiz-framework/pull/466#issuecomment-1018688124
Kudos, SonarCloud Quality Gate passed! 
[](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=466&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=466&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=466&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=466&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=466&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=466&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=466&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=466&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=466&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=466&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=466&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=466&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=466) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=466&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=466&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ofbiz-framework] PierreSmits commented on pull request #466: Improved: List and Grid (OFBIZ-11345)
Posted by GitBox <gi...@apache.org>.
PierreSmits commented on pull request #466:
URL: https://github.com/apache/ofbiz-framework/pull/466#issuecomment-1023246619
Hi @danwatford ,
As you can see from line item 429 the display entity for the field also show ${groupName}, meaning that also party groups may be referenced. Thus having CommonParty is a valid choice for the title. But more importantly the existing title of the field is **hard-coded**, not an existing label. So that is wrong.
Additionally when data is available in the appropriate records, the value shown is a combination of **name** and **id** of the party.
Hence also warranting an improvement. We also have to keep in mind that it is totally acceptable that external people through subcontracting can be in an employee position and a falling in a reporting structure.
As to change on line item 435, as a value a positionId is shown, but it is by implication a position. A generic label for position (as it also can be used with lat and long, locations in warehouses etc) would make sense.
That Michael believes that hard coded titles or even field specific labels are good enough for the project, is his prerogative. He may think and believe so.
But that does **NOT** imply that he can dictate to other contributors to throw out common sense and to do as he tells (as a suggestion, of course) and not apply that common sense to make OFBiz a better product.
The application of a common label has been around since day one of the project, and has been applied across all applications to be able to reduce the load on system, contributor, developer and network. If fields are used in forms across application then a common label is warranted to be preferred over a component specific, eg CommonProduct in grids and lookup fields, instead of productId.
Do a search/find in the labels for <property*productId", and you'll see I have a point (for improvement). And there are plenty more of such examples.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ofbiz-framework] mbrohl commented on pull request #466: Improved: List and Grid (OFBIZ-11345)
Posted by GitBox <gi...@apache.org>.
mbrohl commented on pull request #466:
URL: https://github.com/apache/ofbiz-framework/pull/466#issuecomment-1023322125
Thanks Daniel,
for your thorough description of the problem with common labels, I appreciate your time explaining it!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org