[GitHub] [incubator-doris] xiepengcheng01 commented on a diff in pull request #9666: [Refactor][Bug-Fix][Load Vec] Refactor code of basescanner and vjson/vparquet/vbroker scanner

[GitBox <gi...@apache.org>]

xiepengcheng01 commented on code in PR #9666:
URL: https://github.com/apache/incubator-doris/pull/9666#discussion_r876574860


##########
be/src/exec/base_scanner.cpp:
##########
@@ -272,59 +293,132 @@ Status BaseScanner::_fill_dest_tuple(Tuple* dest_tuple, MemPool* mem_pool) {
         }
         void* slot = dest_tuple->get_slot(slot_desc->tuple_offset());
         RawValue::write(value, slot, slot_desc->type(), mem_pool);
-        continue;
     }
     _success = true;
     return Status::OK();
 }
 
-Status BaseScanner::filter_block(vectorized::Block* temp_block, size_t slot_num) {
+Status BaseScanner::_filter_src_block() {
+    auto origin_column_num = _src_block.columns();
     // filter block
     if (!_vpre_filter_ctxs.empty()) {
         for (auto _vpre_filter_ctx : _vpre_filter_ctxs) {
-            auto old_rows = temp_block->rows();
-            RETURN_IF_ERROR(
-                    vectorized::VExprContext::filter_block(_vpre_filter_ctx, temp_block, slot_num));
-            _counter->num_rows_unselected += old_rows - temp_block->rows();
+            auto old_rows = _src_block.rows();
+            RETURN_IF_ERROR(vectorized::VExprContext::filter_block(_vpre_filter_ctx, &_src_block,
+                                                                   origin_column_num));
+            _counter->num_rows_unselected += old_rows - _src_block.rows();
         }
     }
     return Status::OK();
 }
 
-Status BaseScanner::execute_exprs(vectorized::Block* output_block, vectorized::Block* temp_block) {
+Status BaseScanner::_materialize_dest_block(vectorized::Block* dest_block) {
     // Do vectorized expr here
-    Status status;
-    if (!_dest_vexpr_ctx.empty()) {
-        *output_block = vectorized::VExprContext::get_output_block_after_execute_exprs(
-                _dest_vexpr_ctx, *temp_block, status);
-        if (UNLIKELY(output_block->rows() == 0)) {
-            return status;
+    int ctx_idx = 0;
+    size_t rows = _src_block.rows();
+    auto filter_column = vectorized::ColumnUInt8::create(rows, 1);
+    auto& filter_map = filter_column->get_data();
+
+    for (auto slot_desc : _dest_tuple_desc->slots()) {
+        if (!slot_desc->is_materialized()) {
+            continue;
+        }
+        int dest_index = ctx_idx++;
+
+        auto* ctx = _dest_vexpr_ctx[dest_index];
+        int result_column_id = 0;
+        // PT1 => dest primitive type
+        RETURN_IF_ERROR(ctx->execute(&_src_block, &result_column_id));
+        auto column_ptr = _src_block.get_by_position(result_column_id).column;
+
+        if (column_ptr->is_nullable()) {
+            auto nullable_column =
+                    reinterpret_cast<const vectorized::ColumnNullable*>(column_ptr.get());
+            for (int i = 0; i < rows; ++i) {
+                if (filter_map[i] && nullable_column->is_null_at(i)) {
+                    if (_strict_mode && (_src_slot_descs_order_by_dest[ctx_idx]) &&
+                        !_src_block.get_by_position(ctx_idx).column->is_null_at(i)) {
+                        RETURN_IF_ERROR(_state->append_error_msg_to_file(
+                                [&]() -> std::string {
+                                    return _src_block.dump_one_line(i, _num_of_columns_from_file);
+                                },
+                                [&]() -> std::string {
+                                    // Type of the slot is must be Varchar in _temp_block.

Review Comment:
   should modify this note?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org