You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/09/20 21:16:16 UTC
[GitHub] [flink] afedulov commented on a diff in pull request #20865: [FLINK-14896][connectors/kinesis] Shade and relocate Jackson dependen…
afedulov commented on code in PR #20865:
URL: https://github.com/apache/flink/pull/20865#discussion_r975820738
##########
flink-connectors/flink-connector-kinesis/src/main/resources/META-INF/NOTICE:
##########
@@ -17,6 +17,10 @@ This project bundles the following dependencies under the Apache Software Licens
- com.amazonaws:aws-java-sdk-cloudwatch:1.12.276
- com.amazonaws:dynamodb-streams-kinesis-adapter:1.5.3
- com.amazonaws:jmespath-java:1.12.276
+- com.fasterxml.jackson.core:jackson-annotations:jar:2.13.2
Review Comment:
I believe the `:jar` bit at the end is redundant and causes the build to fail because of the NOTICE checker.
```
Dependency com.fasterxml.jackson.core:jackson-core:2.13.2 is not listed.
Dependency com.fasterxml.jackson.core:jackson-annotations:2.13.2 is not listed.
Dependency com.fasterxml.jackson.core:jackson-databind:2.13.2.2 is not listed.
...
Dependency com.fasterxml.jackson.core:jackson-core:jar:2.13.2 is not bundled, but listed.
Dependency com.fasterxml.jackson.core:jackson-annotations:jar:2.13.2 is not bundled, but listed.
Dependency com.fasterxml.jackson.core:jackson-databind:jar:2.13.2.2 is not bundled, but listed.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org