You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Martin Ritchie (JIRA)" <qp...@incubator.apache.org> on 2008/10/29 15:01:44 UTC
[jira] Created: (QPID-1410)
MessageTokenizerTest.testOK_WithRandomNUmberOfMessages failing on build
system
MessageTokenizerTest.testOK_WithRandomNUmberOfMessages failing on build system
------------------------------------------------------------------------------
Key: QPID-1410
URL: https://issues.apache.org/jira/browse/QPID-1410
Project: Qpid
Issue Type: Bug
Affects Versions: M4
Reporter: Martin Ritchie
Priority: Critical
Fix For: M4
This test has failed a number of times on our continuous build system.
testOK_WithRandomNUmberOfMessages
org.apache.qpid.management.domain.services.MessageTokenizerTest
junit.framework.AssertionFailedError: expected:<3705> but was:<3706>
at org.apache.qpid.management.domain.services.MessageTokenizerTest.testOK_WithRandomNUmberOfMessages(MessageTokenizerTest.java:95)
Will attach logs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (QPID-1410)
MessageTokenizerTest.testOK_WithRandomNUmberOfMessages failing on build
system
Posted by "Martin Ritchie (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12650944#action_12650944 ]
Martin Ritchie commented on QPID-1410:
--------------------------------------
Committed patch for coding standards.
> MessageTokenizerTest.testOK_WithRandomNUmberOfMessages failing on build system
> ------------------------------------------------------------------------------
>
> Key: QPID-1410
> URL: https://issues.apache.org/jira/browse/QPID-1410
> Project: Qpid
> Issue Type: Bug
> Components: Java Management : QMan
> Affects Versions: M4
> Reporter: Martin Ritchie
> Assignee: Martin Ritchie
> Priority: Critical
> Fix For: M4
>
> Attachments: qman_message_tokenizer_test_04112008.patch, qman_message_tokenizer_test_fix.patch
>
>
> This test has failed a number of times on our continuous build system.
> testOK_WithRandomNUmberOfMessages
> org.apache.qpid.management.domain.services.MessageTokenizerTest
> junit.framework.AssertionFailedError: expected:<3705> but was:<3706>
> at org.apache.qpid.management.domain.services.MessageTokenizerTest.testOK_WithRandomNUmberOfMessages(MessageTokenizerTest.java:95)
> Will attach logs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (QPID-1410)
MessageTokenizerTest.testOK_WithRandomNUmberOfMessages failing on build
system
Posted by "Andrea Gazzarini (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrea Gazzarini updated QPID-1410:
-----------------------------------
Attachment: qman_message_tokenizer_test_fix.patch
Hi, this patch should be applied to QMan in order to fix this issue.
The affected tests was trying to create a compound message with a random number of messages inside.
The content of each message was already random and the problem was that the content sometimes (randomly) contained the "AM2" magic number...
Regards,
Andrea
> MessageTokenizerTest.testOK_WithRandomNUmberOfMessages failing on build system
> ------------------------------------------------------------------------------
>
> Key: QPID-1410
> URL: https://issues.apache.org/jira/browse/QPID-1410
> Project: Qpid
> Issue Type: Bug
> Affects Versions: M4
> Reporter: Martin Ritchie
> Priority: Critical
> Fix For: M4
>
> Attachments: qman_message_tokenizer_test_fix.patch
>
>
> This test has failed a number of times on our continuous build system.
> testOK_WithRandomNUmberOfMessages
> org.apache.qpid.management.domain.services.MessageTokenizerTest
> junit.framework.AssertionFailedError: expected:<3705> but was:<3706>
> at org.apache.qpid.management.domain.services.MessageTokenizerTest.testOK_WithRandomNUmberOfMessages(MessageTokenizerTest.java:95)
> Will attach logs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (QPID-1410)
MessageTokenizerTest.testOK_WithRandomNUmberOfMessages failing on build
system
Posted by "Andrea Gazzarini (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12643494#action_12643494 ]
Andrea Gazzarini commented on QPID-1410:
----------------------------------------
Hi Martin, I will take care about that.
Regards,
Andrea
> MessageTokenizerTest.testOK_WithRandomNUmberOfMessages failing on build system
> ------------------------------------------------------------------------------
>
> Key: QPID-1410
> URL: https://issues.apache.org/jira/browse/QPID-1410
> Project: Qpid
> Issue Type: Bug
> Affects Versions: M4
> Reporter: Martin Ritchie
> Priority: Critical
> Fix For: M4
>
>
> This test has failed a number of times on our continuous build system.
> testOK_WithRandomNUmberOfMessages
> org.apache.qpid.management.domain.services.MessageTokenizerTest
> junit.framework.AssertionFailedError: expected:<3705> but was:<3706>
> at org.apache.qpid.management.domain.services.MessageTokenizerTest.testOK_WithRandomNUmberOfMessages(MessageTokenizerTest.java:95)
> Will attach logs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (QPID-1410)
MessageTokenizerTest.testOK_WithRandomNUmberOfMessages failing on build
system
Posted by "Martin Ritchie (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Ritchie updated QPID-1410:
---------------------------------
Assignee: Arnaud Simon (was: Martin Ritchie)
Status: Open (was: Ready To Review)
Arnaud,
This patch does not meet our coding standards.
Can you get Andrea to resubmit a patch or can you correct this please.
See:
http://cwiki.apache.org/confluence/display/qpid/Java+Coding+Standards
The if statement must always have the braces.
Thanks
> MessageTokenizerTest.testOK_WithRandomNUmberOfMessages failing on build system
> ------------------------------------------------------------------------------
>
> Key: QPID-1410
> URL: https://issues.apache.org/jira/browse/QPID-1410
> Project: Qpid
> Issue Type: Bug
> Affects Versions: M4
> Reporter: Martin Ritchie
> Assignee: Arnaud Simon
> Priority: Critical
> Fix For: M4
>
> Attachments: qman_message_tokenizer_test_fix.patch
>
>
> This test has failed a number of times on our continuous build system.
> testOK_WithRandomNUmberOfMessages
> org.apache.qpid.management.domain.services.MessageTokenizerTest
> junit.framework.AssertionFailedError: expected:<3705> but was:<3706>
> at org.apache.qpid.management.domain.services.MessageTokenizerTest.testOK_WithRandomNUmberOfMessages(MessageTokenizerTest.java:95)
> Will attach logs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (QPID-1410)
MessageTokenizerTest.testOK_WithRandomNUmberOfMessages failing on build
system
Posted by "Martin Ritchie (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Ritchie resolved QPID-1410.
----------------------------------
Resolution: Fixed
Patches were good and thanks for correcting the style issues.
> MessageTokenizerTest.testOK_WithRandomNUmberOfMessages failing on build system
> ------------------------------------------------------------------------------
>
> Key: QPID-1410
> URL: https://issues.apache.org/jira/browse/QPID-1410
> Project: Qpid
> Issue Type: Bug
> Components: Java Management : QMan
> Affects Versions: M4
> Reporter: Martin Ritchie
> Assignee: Martin Ritchie
> Priority: Critical
> Fix For: M4
>
> Attachments: qman_message_tokenizer_test_04112008.patch, qman_message_tokenizer_test_fix.patch
>
>
> This test has failed a number of times on our continuous build system.
> testOK_WithRandomNUmberOfMessages
> org.apache.qpid.management.domain.services.MessageTokenizerTest
> junit.framework.AssertionFailedError: expected:<3705> but was:<3706>
> at org.apache.qpid.management.domain.services.MessageTokenizerTest.testOK_WithRandomNUmberOfMessages(MessageTokenizerTest.java:95)
> Will attach logs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (QPID-1410)
MessageTokenizerTest.testOK_WithRandomNUmberOfMessages failing on build
system
Posted by "Martin Ritchie (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Ritchie reassigned QPID-1410:
------------------------------------
Assignee: Martin Ritchie (was: Arnaud Simon)
> MessageTokenizerTest.testOK_WithRandomNUmberOfMessages failing on build system
> ------------------------------------------------------------------------------
>
> Key: QPID-1410
> URL: https://issues.apache.org/jira/browse/QPID-1410
> Project: Qpid
> Issue Type: Bug
> Components: Java Management : QMan
> Affects Versions: M4
> Reporter: Martin Ritchie
> Assignee: Martin Ritchie
> Priority: Critical
> Fix For: M4
>
> Attachments: qman_message_tokenizer_test_04112008.patch, qman_message_tokenizer_test_fix.patch
>
>
> This test has failed a number of times on our continuous build system.
> testOK_WithRandomNUmberOfMessages
> org.apache.qpid.management.domain.services.MessageTokenizerTest
> junit.framework.AssertionFailedError: expected:<3705> but was:<3706>
> at org.apache.qpid.management.domain.services.MessageTokenizerTest.testOK_WithRandomNUmberOfMessages(MessageTokenizerTest.java:95)
> Will attach logs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (QPID-1410)
MessageTokenizerTest.testOK_WithRandomNUmberOfMessages failing on build
system
Posted by "Arnaud Simon (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arnaud Simon reassigned QPID-1410:
----------------------------------
Assignee: Arnaud Simon
> MessageTokenizerTest.testOK_WithRandomNUmberOfMessages failing on build system
> ------------------------------------------------------------------------------
>
> Key: QPID-1410
> URL: https://issues.apache.org/jira/browse/QPID-1410
> Project: Qpid
> Issue Type: Bug
> Affects Versions: M4
> Reporter: Martin Ritchie
> Assignee: Arnaud Simon
> Priority: Critical
> Fix For: M4
>
> Attachments: qman_message_tokenizer_test_fix.patch
>
>
> This test has failed a number of times on our continuous build system.
> testOK_WithRandomNUmberOfMessages
> org.apache.qpid.management.domain.services.MessageTokenizerTest
> junit.framework.AssertionFailedError: expected:<3705> but was:<3706>
> at org.apache.qpid.management.domain.services.MessageTokenizerTest.testOK_WithRandomNUmberOfMessages(MessageTokenizerTest.java:95)
> Will attach logs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (QPID-1410)
MessageTokenizerTest.testOK_WithRandomNUmberOfMessages failing on build
system
Posted by "Martin Ritchie (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Ritchie updated QPID-1410:
---------------------------------
Component/s: Java Management : QMan
> MessageTokenizerTest.testOK_WithRandomNUmberOfMessages failing on build system
> ------------------------------------------------------------------------------
>
> Key: QPID-1410
> URL: https://issues.apache.org/jira/browse/QPID-1410
> Project: Qpid
> Issue Type: Bug
> Components: Java Management : QMan
> Affects Versions: M4
> Reporter: Martin Ritchie
> Assignee: Arnaud Simon
> Priority: Critical
> Fix For: M4
>
> Attachments: qman_message_tokenizer_test_fix.patch
>
>
> This test has failed a number of times on our continuous build system.
> testOK_WithRandomNUmberOfMessages
> org.apache.qpid.management.domain.services.MessageTokenizerTest
> junit.framework.AssertionFailedError: expected:<3705> but was:<3706>
> at org.apache.qpid.management.domain.services.MessageTokenizerTest.testOK_WithRandomNUmberOfMessages(MessageTokenizerTest.java:95)
> Will attach logs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (QPID-1410)
MessageTokenizerTest.testOK_WithRandomNUmberOfMessages failing on build
system
Posted by "Martin Ritchie (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Ritchie updated QPID-1410:
---------------------------------
Status: Ready To Review (was: In Progress)
> MessageTokenizerTest.testOK_WithRandomNUmberOfMessages failing on build system
> ------------------------------------------------------------------------------
>
> Key: QPID-1410
> URL: https://issues.apache.org/jira/browse/QPID-1410
> Project: Qpid
> Issue Type: Bug
> Affects Versions: M4
> Reporter: Martin Ritchie
> Assignee: Martin Ritchie
> Priority: Critical
> Fix For: M4
>
> Attachments: qman_message_tokenizer_test_fix.patch
>
>
> This test has failed a number of times on our continuous build system.
> testOK_WithRandomNUmberOfMessages
> org.apache.qpid.management.domain.services.MessageTokenizerTest
> junit.framework.AssertionFailedError: expected:<3705> but was:<3706>
> at org.apache.qpid.management.domain.services.MessageTokenizerTest.testOK_WithRandomNUmberOfMessages(MessageTokenizerTest.java:95)
> Will attach logs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (QPID-1410)
MessageTokenizerTest.testOK_WithRandomNUmberOfMessages failing on build
system
Posted by "Andrea Gazzarini (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrea Gazzarini updated QPID-1410:
-----------------------------------
Attachment: qman_message_tokenizer_test_04112008.patch
Hi Martin, this is the patch (qman_message_tokenizer_test_04112008.patch) that corrects the coding convention issue.
Regards & thanks for code reviewing,
Andrea
> MessageTokenizerTest.testOK_WithRandomNUmberOfMessages failing on build system
> ------------------------------------------------------------------------------
>
> Key: QPID-1410
> URL: https://issues.apache.org/jira/browse/QPID-1410
> Project: Qpid
> Issue Type: Bug
> Components: Java Management : QMan
> Affects Versions: M4
> Reporter: Martin Ritchie
> Assignee: Arnaud Simon
> Priority: Critical
> Fix For: M4
>
> Attachments: qman_message_tokenizer_test_04112008.patch, qman_message_tokenizer_test_fix.patch
>
>
> This test has failed a number of times on our continuous build system.
> testOK_WithRandomNUmberOfMessages
> org.apache.qpid.management.domain.services.MessageTokenizerTest
> junit.framework.AssertionFailedError: expected:<3705> but was:<3706>
> at org.apache.qpid.management.domain.services.MessageTokenizerTest.testOK_WithRandomNUmberOfMessages(MessageTokenizerTest.java:95)
> Will attach logs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (QPID-1410)
MessageTokenizerTest.testOK_WithRandomNUmberOfMessages failing on build
system
Posted by "Martin Ritchie (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Ritchie updated QPID-1410:
---------------------------------
Status: Ready To Review (was: In Progress)
> MessageTokenizerTest.testOK_WithRandomNUmberOfMessages failing on build system
> ------------------------------------------------------------------------------
>
> Key: QPID-1410
> URL: https://issues.apache.org/jira/browse/QPID-1410
> Project: Qpid
> Issue Type: Bug
> Components: Java Management : QMan
> Affects Versions: M4
> Reporter: Martin Ritchie
> Assignee: Martin Ritchie
> Priority: Critical
> Fix For: M4
>
> Attachments: qman_message_tokenizer_test_04112008.patch, qman_message_tokenizer_test_fix.patch
>
>
> This test has failed a number of times on our continuous build system.
> testOK_WithRandomNUmberOfMessages
> org.apache.qpid.management.domain.services.MessageTokenizerTest
> junit.framework.AssertionFailedError: expected:<3705> but was:<3706>
> at org.apache.qpid.management.domain.services.MessageTokenizerTest.testOK_WithRandomNUmberOfMessages(MessageTokenizerTest.java:95)
> Will attach logs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (QPID-1410)
MessageTokenizerTest.testOK_WithRandomNUmberOfMessages failing on build
system
Posted by "Martin Ritchie (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12643490#action_12643490 ]
Martin Ritchie commented on QPID-1410:
--------------------------------------
mmh log doesn't have much in it.
Testsuite: org.apache.qpid.management.domain.services.MessageTokenizerTest
Tests run: 3, Failures: 1, Errors: 0, Time elapsed: 0.028 sec
------------- Standard Output ---------------
main 2008-10-29 12:24:58,100 DEBUG [management.domain.services.MessageTokenizer] <QMAN-200031> : Incoming compound message contains 1 message(s).
main 2008-10-29 12:24:58,101 DEBUG [management.domain.services.MessageTokenizer] <QMAN-200031> : Incoming compound message contains 1 message(s).
main 2008-10-29 12:24:58,118 DEBUG [management.domain.services.MessageTokenizer] <QMAN-200031> : Incoming compound message contains 3706 message(s).
------------- ---------------- ---------------
Testcase: testOK_WithNoMessage took 0 sec
Testcase: testOK_WithOneMessage took 0 sec
Testcase: testOK_WithRandomNUmberOfMessages took 0.02 sec
FAILED
expected:<3705> but was:<3706>
junit.framework.AssertionFailedError: expected:<3705> but was:<3706>
at org.apache.qpid.management.domain.services.MessageTokenizerTest.testOK_WithRandomNUmberOfMessages(MessageTokenizerTest.java:95)
> MessageTokenizerTest.testOK_WithRandomNUmberOfMessages failing on build system
> ------------------------------------------------------------------------------
>
> Key: QPID-1410
> URL: https://issues.apache.org/jira/browse/QPID-1410
> Project: Qpid
> Issue Type: Bug
> Affects Versions: M4
> Reporter: Martin Ritchie
> Priority: Critical
> Fix For: M4
>
>
> This test has failed a number of times on our continuous build system.
> testOK_WithRandomNUmberOfMessages
> org.apache.qpid.management.domain.services.MessageTokenizerTest
> junit.framework.AssertionFailedError: expected:<3705> but was:<3706>
> at org.apache.qpid.management.domain.services.MessageTokenizerTest.testOK_WithRandomNUmberOfMessages(MessageTokenizerTest.java:95)
> Will attach logs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (QPID-1410)
MessageTokenizerTest.testOK_WithRandomNUmberOfMessages failing on build
system
Posted by "Arnaud Simon (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arnaud Simon reassigned QPID-1410:
----------------------------------
Assignee: Martin Ritchie (was: Arnaud Simon)
Marin, can you close this issue once you have confirmed that thisissue is solved on your build system.
Thanks
> MessageTokenizerTest.testOK_WithRandomNUmberOfMessages failing on build system
> ------------------------------------------------------------------------------
>
> Key: QPID-1410
> URL: https://issues.apache.org/jira/browse/QPID-1410
> Project: Qpid
> Issue Type: Bug
> Affects Versions: M4
> Reporter: Martin Ritchie
> Assignee: Martin Ritchie
> Priority: Critical
> Fix For: M4
>
> Attachments: qman_message_tokenizer_test_fix.patch
>
>
> This test has failed a number of times on our continuous build system.
> testOK_WithRandomNUmberOfMessages
> org.apache.qpid.management.domain.services.MessageTokenizerTest
> junit.framework.AssertionFailedError: expected:<3705> but was:<3706>
> at org.apache.qpid.management.domain.services.MessageTokenizerTest.testOK_WithRandomNUmberOfMessages(MessageTokenizerTest.java:95)
> Will attach logs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.