You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2025/12/26 21:19:41 UTC
(commons-pool) branch POOL_2_X updated (af753455 -> c406b018)
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a change to branch POOL_2_X
in repository https://gitbox.apache.org/repos/asf/commons-pool.git
from af753455 Add @Override
new 380d8afe Normalize spelling
new 43a54301 Comment: Normalize spelling
new fb691baa Javadoc: Fix Spelling
new c406b018 Fix spelling of package-private method name
The 4 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
src/main/java/org/apache/commons/pool2/KeyedPooledObjectFactory.java | 2 +-
src/main/java/org/apache/commons/pool2/impl/EvictionTimer.java | 4 ++--
.../java/org/apache/commons/pool2/impl/GenericKeyedObjectPool.java | 2 +-
src/main/java/org/apache/commons/pool2/impl/GenericObjectPool.java | 2 +-
src/main/java/org/apache/commons/pool2/impl/LinkedBlockingDeque.java | 2 +-
src/test/java/org/apache/commons/pool2/impl/TestEvictionTimer.java | 4 ++--
6 files changed, 8 insertions(+), 8 deletions(-)
(commons-pool) 04/04: Fix spelling of package-private method name
Posted by gg...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch POOL_2_X
in repository https://gitbox.apache.org/repos/asf/commons-pool.git
commit c406b01856daaa83a57c04eed4ee4e565f89e677
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Fri Dec 26 16:19:36 2025 -0500
Fix spelling of package-private method name
---
src/main/java/org/apache/commons/pool2/impl/GenericKeyedObjectPool.java | 2 +-
src/main/java/org/apache/commons/pool2/impl/GenericObjectPool.java | 2 +-
src/main/java/org/apache/commons/pool2/impl/LinkedBlockingDeque.java | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/main/java/org/apache/commons/pool2/impl/GenericKeyedObjectPool.java b/src/main/java/org/apache/commons/pool2/impl/GenericKeyedObjectPool.java
index 494ca291..b088cab9 100644
--- a/src/main/java/org/apache/commons/pool2/impl/GenericKeyedObjectPool.java
+++ b/src/main/java/org/apache/commons/pool2/impl/GenericKeyedObjectPool.java
@@ -789,7 +789,7 @@ public class GenericKeyedObjectPool<K, T> extends BaseGenericObjectPool<T>
jmxUnregister();
// Release any threads that were waiting for an object
- poolMap.values().forEach(e -> e.getIdleObjects().interuptTakeWaiters());
+ poolMap.values().forEach(e -> e.getIdleObjects().interruptTakeWaiters());
// This clear cleans up the keys now any waiting threads have been
// interrupted
clear();
diff --git a/src/main/java/org/apache/commons/pool2/impl/GenericObjectPool.java b/src/main/java/org/apache/commons/pool2/impl/GenericObjectPool.java
index 78be17e4..f193b0bf 100644
--- a/src/main/java/org/apache/commons/pool2/impl/GenericObjectPool.java
+++ b/src/main/java/org/apache/commons/pool2/impl/GenericObjectPool.java
@@ -484,7 +484,7 @@ public class GenericObjectPool<T> extends BaseGenericObjectPool<T>
jmxUnregister();
// Release any threads that were waiting for an object
- idleObjects.interuptTakeWaiters();
+ idleObjects.interruptTakeWaiters();
}
}
diff --git a/src/main/java/org/apache/commons/pool2/impl/LinkedBlockingDeque.java b/src/main/java/org/apache/commons/pool2/impl/LinkedBlockingDeque.java
index 3c7898e1..88cce10d 100644
--- a/src/main/java/org/apache/commons/pool2/impl/LinkedBlockingDeque.java
+++ b/src/main/java/org/apache/commons/pool2/impl/LinkedBlockingDeque.java
@@ -605,7 +605,7 @@ final class LinkedBlockingDeque<E> extends AbstractQueue<E>
* Interrupts the threads currently waiting to take an object from the pool. See disclaimer on accuracy in
* {@link java.util.concurrent.locks.ReentrantLock#getWaitingThreads(Condition)}.
*/
- void interuptTakeWaiters() {
+ void interruptTakeWaiters() {
lock.lock();
try {
lock.interruptWaiters(notEmpty);
(commons-pool) 03/04: Javadoc: Fix Spelling
Posted by gg...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch POOL_2_X
in repository https://gitbox.apache.org/repos/asf/commons-pool.git
commit fb691baa016b0acc8d0850ca88d9074f702f1756
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Fri Dec 26 16:08:22 2025 -0500
Javadoc: Fix Spelling
---
src/main/java/org/apache/commons/pool2/KeyedPooledObjectFactory.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/main/java/org/apache/commons/pool2/KeyedPooledObjectFactory.java b/src/main/java/org/apache/commons/pool2/KeyedPooledObjectFactory.java
index 01a6f11a..e5358ad8 100644
--- a/src/main/java/org/apache/commons/pool2/KeyedPooledObjectFactory.java
+++ b/src/main/java/org/apache/commons/pool2/KeyedPooledObjectFactory.java
@@ -62,7 +62,7 @@ package org.apache.commons.pool2;
* While clients of a {@link KeyedObjectPool} borrow and return instances of
* the underlying value type V, the factory methods act on instances of
* {@link PooledObject PooledObject<V>}. These are the object wrappers that
- * pools use to track and maintain state informations about the objects that
+ * pools use to track and maintain state information about the objects that
* they manage.
* </p>
*
(commons-pool) 02/04: Comment: Normalize spelling
Posted by gg...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch POOL_2_X
in repository https://gitbox.apache.org/repos/asf/commons-pool.git
commit 43a54301c8d1e20f50fd5666f10eda33cfac2e20
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Fri Dec 26 16:07:55 2025 -0500
Comment: Normalize spelling
---
src/test/java/org/apache/commons/pool2/impl/TestEvictionTimer.java | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/test/java/org/apache/commons/pool2/impl/TestEvictionTimer.java b/src/test/java/org/apache/commons/pool2/impl/TestEvictionTimer.java
index e7680200..24853b64 100644
--- a/src/test/java/org/apache/commons/pool2/impl/TestEvictionTimer.java
+++ b/src/test/java/org/apache/commons/pool2/impl/TestEvictionTimer.java
@@ -84,7 +84,7 @@ class TestEvictionTimer {
EvictionTimer.cancel(evictor1, BaseObjectPoolConfig.DEFAULT_EVICTOR_SHUTDOWN_TIMEOUT, false);
// Assert that eviction objects are correctly cleaned
- // 1 - the evictor timer task is cancelled
+ // 1 - the evictor timer task is canceled
sf = (ScheduledFuture<?>) evictorTaskFutureField.get(evictor1);
assertTrue(sf.isCancelled());
// 2- and, the eviction action is removed from executor thread pool
@@ -96,7 +96,7 @@ class TestEvictionTimer {
EvictionTimer.cancel(evictor2, BaseObjectPoolConfig.DEFAULT_EVICTOR_SHUTDOWN_TIMEOUT, false);
// Assert that eviction objects are correctly cleaned
- // 1 - the evictor timer task is cancelled
+ // 1 - the evictor timer task is canceled
sf = (ScheduledFuture<?>) evictorTaskFutureField.get(evictor2);
assertTrue(sf.isCancelled());
// 2- and, the eviction thread pool executor is freed
(commons-pool) 01/04: Normalize spelling
Posted by gg...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch POOL_2_X
in repository https://gitbox.apache.org/repos/asf/commons-pool.git
commit 380d8afe1f18e0b234e36dac7d6777e4739980a1
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Fri Dec 26 16:02:26 2025 -0500
Normalize spelling
---
src/main/java/org/apache/commons/pool2/impl/EvictionTimer.java | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/main/java/org/apache/commons/pool2/impl/EvictionTimer.java b/src/main/java/org/apache/commons/pool2/impl/EvictionTimer.java
index 808c9a8d..c932cea0 100644
--- a/src/main/java/org/apache/commons/pool2/impl/EvictionTimer.java
+++ b/src/main/java/org/apache/commons/pool2/impl/EvictionTimer.java
@@ -33,7 +33,7 @@ import java.util.concurrent.TimeUnit;
* <p>
* This class is currently implemented using {@link ScheduledThreadPoolExecutor}. This implementation may change in any
* future release. This class keeps track of how many pools are using it. If no pools are using the timer, it is
- * cancelled. This prevents a thread being left running which, in application server environments, can lead to memory
+ * canceled. This prevents a thread being left running which, in application server environments, can lead to memory
* leads and/or prevent applications from shutting down or reloading cleanly.
* </p>
* <p>
@@ -139,7 +139,7 @@ final class EvictionTimer {
/**
* Removes the specified eviction task from the timer.
*
- * @param evictor Task to be cancelled.
+ * @param evictor Task to be canceled.
* @param timeout If the associated executor is no longer required, how
* long should this thread wait for the executor to
* terminate?