You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2022/03/14 19:57:01 UTC

[GitHub] [pinot] jtao15 commented on pull request #8345: Add controller metrics for the segments excluding replaced segments

jtao15 commented on pull request #8345:
URL: https://github.com/apache/pinot/pull/8345#issuecomment-1067227093


   > I think for `NUMBER_OF_REPLICAS`, `PERCENT_OF_REPLICAS`, `SEGMENTS_IN_ERROR_STATE` and `PERCENT_SEGMENTS_AVAILABLE` we should by default exclude the replaced segments. Adding 2 sets of metrics can cause confusion and unnecessary overhead. For `SEGMENT_COUNT`, I'd suggest also excluding the replaced segments by default, but add one `SEGMENT_COUNT_INCLUDING_REPLACED` for debugging and tracking purpose.
   
   Make sense, will update the pr soon.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org