[GitHub] [incubator-streampark] 1996fanrui commented on issue #1857: [Proposal] Unify flink configuration

[GitBox <gi...@apache.org>]

1996fanrui commented on issue #1857:
URL: https://github.com/apache/incubator-streampark/issues/1857#issuecomment-1282492326

   Hi @wolfboys , thanks for your great proposal. 
   
   I have some questions:
   
   1. Why do you write the sql content in the config file? As I understand, the proposal want to unify the table config, right?
   2. For the table config, could we use `env.table-property` as the prefix? In other word, I don't think the `env.property.table` is a good idea. Because all configs under `env.property` will pass to Flink Env.
   
   I use the `table.exec.mini-batch.enabled` as an example.
   
   ```
   env:
     option: #cli opiton args
       target: yarn-application # yarn-application, yarn-perjob
       shutdownOnAttachedExit:
       jobmanager:
       ...
     property: 
       ${StreamExecutionEnvironment.key} : $value
       ...
     table-property: 
       table.exec.mini-batch.enabled : true
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org