You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@atlas.apache.org by Sarath Subramanian <sa...@apache.org> on 2018/08/03 07:19:34 UTC

Review Request 68183: ATLAS-2807: Re-evaluate classification propagation during entity delete

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68183/
-----------------------------------------------------------

Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Madhan Neethiraj.


Bugs: ATLAS-2807
    https://issues.apache.org/jira/browse/ATLAS-2807


Repository: atlas


Description
-------

The current behavior - when we delete an entity f1, all tags associate to f1 which got propagated

to downstream entities are removed – PII tag propagated to process1 and t1 is removed

Proposed Change

Soft Delete:

When entity f1 is deleted, retain the propagated classification edges, so the downstream entities

– process1 and t1 continue to have PII classification associated to them

Hard Delete:

In cases of hard delete, the source entity (f1) is deleted from atlas, but its classification vertex

(PII) continue to exist and will continue propagating to process1 and t1.


Diffs
-----

  common/src/main/java/org/apache/atlas/repository/Constants.java 7988d1d81 
  intg/src/main/java/org/apache/atlas/model/instance/AtlasClassification.java 3132379b9 
  repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java d328873f1 
  repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java 4a0924bbe 
  repository/src/main/java/org/apache/atlas/repository/store/graph/v1/HardDeleteHandlerV1.java a95e6898e 
  repository/src/main/java/org/apache/atlas/repository/store/graph/v1/SoftDeleteHandlerV1.java 41e65d4a3 
  repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java 1b709e48e 
  repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java f57ce99f7 
  repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java 448d03bc0 


Diff: https://reviews.apache.org/r/68183/diff/1/


Testing
-------

Validated basic cases using REST clirnt.

PreCommit: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/531/console


Thanks,

Sarath Subramanian