Re: [PR] chore(dist): add deploy-release.sh to download & start services [incubator-hugegraph-doc]

["imbajin (via GitHub)" <gi...@apache.org>]

imbajin commented on code in PR #330:
URL: https://github.com/apache/incubator-hugegraph-doc/pull/330#discussion_r1518803951


##########
dist/deploy-release.sh:
##########
@@ -0,0 +1,51 @@
+#!/usr/bin/env bash
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#    http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+# Download hugegraph-server and hugegraph-toolcahain, then start them:
+# hugegraph-server and hugegraph-hubble
+
+set -e
+
+RELEASE_VERSION=$1 # like 1.2.0
+RELEASE_VERSION=${RELEASE_VERSION:?"Please input the release version, like 1.2.0"}
+
+DOWNLOAD_URL_PREFIX="https://downloads.apache.org/incubator/hugegraph"
+SERVER_TAR="apache-hugegraph-incubating-${RELEASE_VERSION}.tar.gz"
+TOOLCHAIN_TAR="apache-hugegraph-toolchain-incubating-${RELEASE_VERSION}.tar.gz"
+
+echo "download hugegraph tars from $DOWNLOAD_URL_PREFIX..."
+if [[ ! -f "${SERVER_TAR}" ]]; then
+  wget "${DOWNLOAD_URL_PREFIX}/${RELEASE_VERSION}/${SERVER_TAR}"
+  tar -xzvf "${SERVER_TAR}"
+fi
+if [[ ! -f "${TOOLCHAIN_TAR}" ]]; then
+  wget "${DOWNLOAD_URL_PREFIX}/${RELEASE_VERSION}/${TOOLCHAIN_TAR}"
+  tar -xzvf ${TOOLCHAIN_TAR}
+fi
+
+echo "start hugegraph-server..."
+cd $(echo "./*hugegraph-incubating*${RELEASE_VERSION}")
+bin/stop-hugegraph.sh

Review Comment:
   > stop-hugegraph is just for stop the service also deployed by dist/deploy-release.sh
   
   if someone already download & start the server/hubble processes with the deploy script,
   
   why they need **restart** them with `deploy-*.sh` rather than restart the **server/hubble** directly(with their own script)?
   
   In another case, if a user downloaded & ran the old version `1.0.0` before & now they want to upgrade `1.2.0`, the download/running **path shall be different** & the old processes couldn't be killed in the new path?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org