[GitHub] [groovy] danielsun1106 commented on a change in pull request #1339: Support coerce for @NamedVariant

[GitBox <gi...@apache.org>]

danielsun1106 commented on a change in pull request #1339:
URL: https://github.com/apache/groovy/pull/1339#discussion_r467682355



##########
File path: src/test/groovy/transform/NamedVariantTest.groovy
##########
@@ -0,0 +1,83 @@
+/*
+ *  Licensed to the Apache Software Foundation (ASF) under one
+ *  or more contributor license agreements.  See the NOTICE file
+ *  distributed with this work for additional information
+ *  regarding copyright ownership.  The ASF licenses this file
+ *  to you under the Apache License, Version 2.0 (the
+ *  "License"); you may not use this file except in compliance
+ *  with the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ *  Unless required by applicable law or agreed to in writing,
+ *  software distributed under the License is distributed on an
+ *  "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ *  KIND, either express or implied.  See the License for the
+ *  specific language governing permissions and limitations
+ *  under the License.
+ */
+package groovy.transform
+
+import java.lang.reflect.Modifier
+import groovy.test.GroovyTestCase
+
+/**
+ * Unit tests for the NamedVariant annotation
+ */
+class NamedVariantTest extends GroovyTestCase {
+    void testMethod() {
+        def tester = new GroovyClassLoader().parseClass(
+                '''class MyClass {
+                  |    @groovy.transform.NamedVariant
+                  |    void run(int number) {
+                  |    }
+                  |}'''.stripMargin())
+        // Should have such method `void run(Map)`
+        def method = tester.getDeclaredMethod("run", Map)
+        assert method
+        assert Modifier.isPublic(method.modifiers)
+        assert method.returnType == void.class
+    }
+
+    void testMethodCall() {
+        def tester = new GroovyClassLoader().parseClass(
+                '''class MyClass {
+                  |    @groovy.transform.NamedVariant
+                  |    void run(int number) {
+                  |    }
+                  |}'''.stripMargin()).getConstructor().newInstance()
+
+        tester.run(number: 123)
+        try {
+            tester.run(number: "123")
+        } catch (MissingMethodException ignored) {
+            return
+        }
+        fail("Should have thrown MissingMethodException")
+    }
+
+    void testCoerceMethodCall() {
+        def tester = new GroovyClassLoader().parseClass(
+                '''class MyClass {
+                  |    @groovy.transform.NamedVariant(coerce = true)
+                  |    void run(int number) {
+                  |    }
+                  |}'''.stripMargin()).getConstructor().newInstance()
+
+        tester.run(number: 123)
+        tester.run(number: "123")
+    }
+
+    void testStaticCoerceMethodCall() {
+        def tester = new GroovyClassLoader().parseClass(
+                '''@groovy.transform.CompileStatic
+                  |class MyClass {
+                  |    @groovy.transform.NamedVariant(coerce = true)
+                  |    void run(int number) {
+                  |    }
+                  |}'''.stripMargin()).getConstructor().newInstance()
+
+        tester.run(number: 123)
+        tester.run(number: "123")

Review comment:
       It's better to use `assert` statements here.
   Given `run` method return `number` directly:
   ```
   void run(int number) { number }
   ```
   We could tweak the test as follows:
   `assert 123 == tester.run(number: 123)`
   `assert 123 == tester.run(number: "123")`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org