[jira] [Commented] (OAK-6516) Consider reordering the index-update-hook to reside with other post-commit-hooks

["Chetan Mehrotra (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OAK-6516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16112407#comment-16112407 ] 

Chetan Mehrotra commented on OAK-6516:
--------------------------------------

Current list of hooks in a typical setup
{noformat}
- CompositeHook
   - ResetCommitAttributeHook
   - CompositeHook
     - VersionHook
     - ConflictHook
     - EditorHook
       - ItemSaveValidatorProvider
       - NameValidatorProvider
       - NamespaceEditorProvider
       - TypeEditorProvider
       - ConflictValidatorProvider
       - ChangeCollectorProvider
     - RepoStateCheckHook
     - EditorHook
       - IndexUpdateProvider
           - ReferenceEditorProvider
           - PropertyIndexEditorProvider
           - NodeCounterEditorProvider
           - OrderedPropertyIndexEditorProvider
   - VersionablePathHook
   - EditorHook
     - PermissionStoreValidatorProvider
     - PermissionValidatorProvider
     - AccessControlValidatorProvider
     - PrivilegeValidatorProvider
     - UserValidatorProvider
     - CacheValidatorProvider
     - TokenValidatorProvider
   - PermissionHook
   - JcrAllCommitHook
{noformat}

> Consider reordering the index-update-hook to reside with other post-commit-hooks
> --------------------------------------------------------------------------------
>
>                 Key: OAK-6516
>                 URL: https://issues.apache.org/jira/browse/OAK-6516
>             Project: Jackrabbit Oak
>          Issue Type: Task
>          Components: core, indexing
>            Reporter: angela
>
> Currently the index-update hook is located together with other commit validators and is followed by the security related validators that are plugged to the final commit hook upon each call to {{Root.commit}} to allow for proper pluggability of security modules.
> Consequently a given commit may fail with some security related validation only after the index updated has been proceeded already. 
> I would like to discuss the possibility to treat the index-update like a post-commit-hook that is only executed after all validation has been performed. In the security area this is achieved by collecting the validator separately from the post-commit-hooks.
> [~stillalex], [~tmueller], I would appreciate if we could discuss this topic as well as possible implications/regressions that might be associated with it.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)