You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Greg Solovyev (Code Review)" <ge...@cloudera.org> on 2018/08/23 21:08:06 UTC
[kudu-CR] Add protobuf generated files to Eclipse project classpath. With this change Eclipse can compile all Java projects and allows to can run JUnit tests from Eclipse
Hello Grant Henke,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/11307
to review the following change.
Change subject: Add protobuf generated files to Eclipse project classpath. With this change Eclipse can compile all Java projects and allows to can run JUnit tests from Eclipse
......................................................................
Add protobuf generated files to Eclipse project classpath. With this change Eclipse can compile all Java projects and allows to can run JUnit tests from Eclipse
Change-Id: I3f322bc080838f99096b7e5b17f4c313a2ca1a54
---
M java/gradle/protobuf.gradle
1 file changed, 13 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/07/11307/1
--
To view, visit http://gerrit.cloudera.org:8080/11307
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3f322bc080838f99096b7e5b17f4c313a2ca1a54
Gerrit-Change-Number: 11307
Gerrit-PatchSet: 1
Gerrit-Owner: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
[kudu-CR] Add protobuf generated files to Eclipse project classpath. With this change Eclipse can compile all Java projects and allows to can run JUnit tests from Eclipse
Posted by "Greg Solovyev (Code Review)" <ge...@cloudera.org>.
Greg Solovyev has abandoned this change. ( http://gerrit.cloudera.org:8080/11307 )
Change subject: Add protobuf generated files to Eclipse project classpath. With this change Eclipse can compile all Java projects and allows to can run JUnit tests from Eclipse
......................................................................
Abandoned
--
To view, visit http://gerrit.cloudera.org:8080/11307
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I3f322bc080838f99096b7e5b17f4c313a2ca1a54
Gerrit-Change-Number: 11307
Gerrit-PatchSet: 1
Gerrit-Owner: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] Add protobuf generated files to Eclipse project classpath. With this change Eclipse can compile all Java projects and allows to can run JUnit tests from Eclipse
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11307 )
Change subject: Add protobuf generated files to Eclipse project classpath. With this change Eclipse can compile all Java projects and allows to can run JUnit tests from Eclipse
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/11307/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/11307/1//COMMIT_MSG@7
PS1, Line 7: Add protobuf generated files to Eclipse project classpath. With this change Eclipse can compile all Java projects and allows to can run JUnit tests from Eclipse
Nit: Line breaks. With a short summary and then detailed message.
http://gerrit.cloudera.org:8080/#/c/11307/1/java/gradle/protobuf.gradle
File java/gradle/protobuf.gradle:
http://gerrit.cloudera.org:8080/#/c/11307/1/java/gradle/protobuf.gradle@42
PS1, Line 42: entries += new SourceFolder('target/generated-sources/protobuf/java', null)
This is pointing to the files generated by the maven build. To ensure you are not mixing builds run `mvn clean` to clear out the target directories.
I think you should use "${protobuf.generatedFilesBaseDir}/main/java" which is effectively "build/generated/source/proto/main/java"
--
To view, visit http://gerrit.cloudera.org:8080/11307
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3f322bc080838f99096b7e5b17f4c313a2ca1a54
Gerrit-Change-Number: 11307
Gerrit-PatchSet: 1
Gerrit-Owner: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Thu, 23 Aug 2018 21:17:42 +0000
Gerrit-HasComments: Yes