You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "kohrar (via GitHub)" <gi...@apache.org> on 2024/01/26 00:48:16 UTC
[PR] Fix cloudstack-ui package: bad directory permissions and missing WEB-INF [cloudstack]
kohrar opened a new pull request, #8568:
URL: https://github.com/apache/cloudstack/pull/8568
### Description
The cloudstack-ui package contains a copy of the webapp. However, the package (for both CentOS 7 and CentOS 8) have two issues:
1. Bad permissions on directories. The 'cloud' user cannot read and serve assets from subdirectories
2. WEB-INF/web.xml is missing. This breaks the API as the web routes are not defined.
Fixes #8558
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [x] build/CI
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [x] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [x] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
Rebuilt the RPM packages under Rocky Linux 8 / CentOS 8 using Docker.
New cloudstack-ui packages now have the proper permissions:
```
```
#### How did you try to break this feature and the system with this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix cloudstack-ui package: bad directory permissions and missing WEB-INF [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8568:
URL: https://github.com/apache/cloudstack/pull/8568#issuecomment-1916445419
@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix cloudstack-ui package: bad directory permissions and missing WEB-INF [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8568:
URL: https://github.com/apache/cloudstack/pull/8568#issuecomment-1926733631
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8522
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix cloudstack-ui package: bad directory permissions and missing WEB-INF [cloudstack]
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on PR #8568:
URL: https://github.com/apache/cloudstack/pull/8568#issuecomment-1926470834
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix cloudstack-ui package: bad directory permissions and missing WEB-INF [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #8568:
URL: https://github.com/apache/cloudstack/pull/8568#issuecomment-1916443425
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix cloudstack-ui package: bad directory permissions and missing WEB-INF [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8568:
URL: https://github.com/apache/cloudstack/pull/8568#issuecomment-1916467960
UI build: :heavy_check_mark:
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/8568 (QA-JID-271)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix cloudstack-ui package: bad directory permissions and missing WEB-INF [cloudstack]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #8568:
URL: https://github.com/apache/cloudstack/pull/8568#issuecomment-1911935564
## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8568?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Comparison is base [(`33bb92a`)](https://app.codecov.io/gh/apache/cloudstack/commit/33bb92acce2dd2f3b8acccc4c0d81fcc37a4714f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 13.16% compared to head [(`9d07d3a`)](https://app.codecov.io/gh/apache/cloudstack/pull/8568?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 13.16%.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## 4.18 #8568 +/- ##
=========================================
Coverage 13.16% 13.16%
- Complexity 9201 9203 +2
=========================================
Files 2724 2724
Lines 258077 258077
Branches 40224 40224
=========================================
+ Hits 33981 33986 +5
+ Misses 219790 219784 -6
- Partials 4306 4307 +1
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/8568?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix cloudstack-ui package: bad directory permissions and missing WEB-INF [cloudstack]
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on PR #8568:
URL: https://github.com/apache/cloudstack/pull/8568#issuecomment-1914483269
@kohrar the cloudstack-ui package is for advanced user wherein we assume it's not being served from the cloudstack management server host. The cloudstack-management already bundles the UI.
cloudstack-ui can be used for adv customisation/multi-mgmt server serving (http://docs.cloudstack.apache.org/en/4.18.1.0/adminguide/ui.html#advanced-ui-customisation) or even nginx-reverse proxy use-cases https://github.com/apache/cloudstack/tree/main/ui#production
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix cloudstack-ui package: bad directory permissions and missing WEB-INF [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #8568:
URL: https://github.com/apache/cloudstack/pull/8568#issuecomment-1916472749
it seems to have installed correctly in qa, so I think this is ready for merge. Not sure if I miss some corner case there that should be covered as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix cloudstack-ui package: bad directory permissions and missing WEB-INF [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8568:
URL: https://github.com/apache/cloudstack/pull/8568#issuecomment-1926472313
@rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix cloudstack-ui package: bad directory permissions and missing WEB-INF [cloudstack]
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud merged PR #8568:
URL: https://github.com/apache/cloudstack/pull/8568
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix cloudstack-ui package: bad directory permissions and missing WEB-INF [cloudstack]
Posted by "kohrar (via GitHub)" <gi...@apache.org>.
kohrar commented on PR #8568:
URL: https://github.com/apache/cloudstack/pull/8568#issuecomment-1912377499
> clgtm, it seems that the ui can now be deployed as any user (something outside the diff may force user 'cloud', not sure). is that right @kohrar ?
Out of the box, CloudStack serves the UI (via the cloudstack-management service) as the 'cloud' user, as defined by the [cloudstack-management service file](https://github.com/apache/cloudstack/blob/19250403e645c76f60b17aa4aeb4dc915f5ca206/packaging/systemd/cloudstack-management.service#L33). An operator could in theory change the daemon user to something other than cloud. I don't see anything in the CloudStack documentation about changing this.
Regardless of what user cloudstack-management runs as (cloud or otherwise), this PR will fix the case where the UI and API breaks if a CloudStack operator tries to install the cloudstack-ui package and configures the CloudStack management service to use that webapp directory with `webapp.dir=/usr/share/cloudstack-ui` (in `/etc/cloudstack/management/server.properties`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org