[jira] Commented: (HADOOP-5700) INode.getPathComponents throws NPE when given a non-absolute path

["Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-5700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12713679#action_12713679 ] 

Tsz Wo (Nicholas), SZE commented on HADOOP-5700:
------------------------------------------------

Questions:
- How to reproduce the problem?  It seems to me that getPathComponents(..) will return null but not throwing NPE before the patch.

- Did anyone measure the performance impact on the patch?  The check (!path.startsWith("/")) introduced by the patch seems to be redundant since getPathNames(..) has the same check.

- After the patch, calling getPathComponents(null) will get a NPE but it was not before the patch.  Is it a bug?

> INode.getPathComponents throws NPE when given a non-absolute path
> -----------------------------------------------------------------
>
>                 Key: HADOOP-5700
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5700
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Minor
>             Fix For: 0.21.0
>
>         Attachments: HADOOP-5700.txt
>
>
> If you pass a path that doesn't start with '/' to INode.getPathComponents, it throws a NullPointerException. Instead it should throw IllegalArgumentException to make it clear that absolute paths are required in this code.
> The attached patch fixes this, clarifies, the javadoc, and adds a test case.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.