You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@groovy.apache.org by su...@apache.org on 2022/05/10 17:37:45 UTC

[groovy] branch GROOVY_4_0_X updated: Trivial refactoring: extract constant

This is an automated email from the ASF dual-hosted git repository.

sunlan pushed a commit to branch GROOVY_4_0_X
in repository https://gitbox.apache.org/repos/asf/groovy.git


The following commit(s) were added to refs/heads/GROOVY_4_0_X by this push:
     new a5a2a4d8dd Trivial refactoring: extract constant
a5a2a4d8dd is described below

commit a5a2a4d8dd3eee41d8b0bc806b7afdf90c1f79a8
Author: Daniel Sun <su...@apache.org>
AuthorDate: Wed May 11 01:34:29 2022 +0800

    Trivial refactoring: extract constant
    
    (cherry picked from commit 86cf83d71dfa3110c4f1db50a6cccbcd6df4e671)
---
 src/main/java/org/codehaus/groovy/vmplugin/v8/Selector.java | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/main/java/org/codehaus/groovy/vmplugin/v8/Selector.java b/src/main/java/org/codehaus/groovy/vmplugin/v8/Selector.java
index 5a0ccd516a..3301c18225 100644
--- a/src/main/java/org/codehaus/groovy/vmplugin/v8/Selector.java
+++ b/src/main/java/org/codehaus/groovy/vmplugin/v8/Selector.java
@@ -378,6 +378,7 @@ public abstract class Selector {
     }
 
     private static class InitSelector extends MethodSelector {
+        private static final MethodType MT_OBJECT = MethodType.methodType(Object.class);
         private boolean beanConstructor;
 
         public InitSelector(MutableCallSite callSite, Class<?> sender, String methodName, CallType callType, boolean safeNavigation, boolean thisCall, boolean spreadCall, Object[] arguments) {
@@ -448,7 +449,7 @@ public abstract class Selector {
                 // to do this we first bind the values to #setBeanProperties
                 MethodHandle con = BEAN_CONSTRUCTOR_PROPERTY_SETTER.bindTo(mc);
                 // inner class case
-                MethodType foldTargetType = MethodType.methodType(Object.class);
+                MethodType foldTargetType = MT_OBJECT;
                 if (args.length == 3) {
                     con = MethodHandles.dropArguments(con, 1, targetType.parameterType(1));
                     foldTargetType = foldTargetType.insertParameterTypes(0, targetType.parameterType(1));