You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mahout.apache.org by "Benson Margulies (JIRA)" <ji...@apache.org> on 2009/12/23 22:50:29 UTC
[jira] Created: (MAHOUT-229) Clean up and templatize the primitive
list containers
Clean up and templatize the primitive list containers
-----------------------------------------------------
Key: MAHOUT-229
URL: https://issues.apache.org/jira/browse/MAHOUT-229
Project: Mahout
Issue Type: Improvement
Components: Matrix
Affects Versions: 0.4
Reporter: Benson Margulies
Clean up the code in org.apache.mahout.math.list, including some testing and cleanup of some things that it calls.
This includes:
1) More features in the Velocity code generator, including code to avoid generating a shadow of a checked-in file, and code to allow explicit suppression of individual outputs. Also an extra macro or two to make the template neater in some cases.
2) The stack of code from AbstractList to AbstractXxxList to XxxArrayList generated with templates. AbstractCollection eliminated. ObjectArrayList preserved for now until the maps can be weaned from it.
3) Removed 2 broken functions from the Sorting class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAHOUT-229) Clean up and templatize the
primitive list containers
Posted by "Sean Owen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12794423#action_12794423 ]
Sean Owen commented on MAHOUT-229:
----------------------------------
No this is in the generated .java files in generated-sources. There are some other compile errors too but this is the most obvious one. Also files like ByteArrayList.java are generated as empty.
> Clean up and templatize the primitive list containers
> -----------------------------------------------------
>
> Key: MAHOUT-229
> URL: https://issues.apache.org/jira/browse/MAHOUT-229
> Project: Mahout
> Issue Type: Improvement
> Components: Math
> Affects Versions: 0.4
> Reporter: Benson Margulies
> Fix For: 0.4
>
> Attachments: array_list_patch.diff
>
>
> Clean up the code in org.apache.mahout.math.list, including some testing and cleanup of some things that it calls.
> This includes:
> 1) More features in the Velocity code generator, including code to avoid generating a shadow of a checked-in file, and code to allow explicit suppression of individual outputs. Also an extra macro or two to make the template neater in some cases.
> 2) The stack of code from AbstractList to AbstractXxxList to XxxArrayList generated with templates. AbstractCollection eliminated. ObjectArrayList preserved for now until the maps can be weaned from it.
> 3) Removed 2 broken functions from the Sorting class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAHOUT-229) Clean up and templatize the
primitive list containers
Posted by "Sean Owen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12796000#action_12796000 ]
Sean Owen commented on MAHOUT-229:
----------------------------------
OK, shall I commit? a combination of patch #2 and/or #3?
Or would anyone else care to since I seem to have had problems with the patch.
> Clean up and templatize the primitive list containers
> -----------------------------------------------------
>
> Key: MAHOUT-229
> URL: https://issues.apache.org/jira/browse/MAHOUT-229
> Project: Mahout
> Issue Type: Improvement
> Components: Math
> Affects Versions: 0.4
> Reporter: Benson Margulies
> Fix For: 0.4
>
> Attachments: array_list_patch2.diff, array_list_patch3.diff
>
>
> Clean up the code in org.apache.mahout.math.list, including some testing and cleanup of some things that it calls.
> This includes:
> 1) More features in the Velocity code generator, including code to avoid generating a shadow of a checked-in file, and code to allow explicit suppression of individual outputs. Also an extra macro or two to make the template neater in some cases.
> 2) The stack of code from AbstractList to AbstractXxxList to XxxArrayList generated with templates. AbstractCollection eliminated. ObjectArrayList preserved for now until the maps can be weaned from it.
> 3) Removed 2 broken functions from the Sorting class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAHOUT-229) Clean up and templatize the
primitive list containers
Posted by "Benson Margulies (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12794422#action_12794422 ]
Benson Margulies commented on MAHOUT-229:
-----------------------------------------
Yes, that's a template?
You need to
a) apply the patch
b) run mvn in the codegen directory
c) run mvn in the math directory
d) tell your IDE about target/generated-sources
and target/generated-test-sources
> Clean up and templatize the primitive list containers
> -----------------------------------------------------
>
> Key: MAHOUT-229
> URL: https://issues.apache.org/jira/browse/MAHOUT-229
> Project: Mahout
> Issue Type: Improvement
> Components: Math
> Affects Versions: 0.4
> Reporter: Benson Margulies
> Fix For: 0.4
>
> Attachments: array_list_patch.diff
>
>
> Clean up the code in org.apache.mahout.math.list, including some testing and cleanup of some things that it calls.
> This includes:
> 1) More features in the Velocity code generator, including code to avoid generating a shadow of a checked-in file, and code to allow explicit suppression of individual outputs. Also an extra macro or two to make the template neater in some cases.
> 2) The stack of code from AbstractList to AbstractXxxList to XxxArrayList generated with templates. AbstractCollection eliminated. ObjectArrayList preserved for now until the maps can be weaned from it.
> 3) Removed 2 broken functions from the Sorting class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAHOUT-229) Clean up and templatize the primitive
list containers
Posted by "Benson Margulies (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benson Margulies updated MAHOUT-229:
------------------------------------
Attachment: array_list_patch2.diff
Restore old copy of patch.
> Clean up and templatize the primitive list containers
> -----------------------------------------------------
>
> Key: MAHOUT-229
> URL: https://issues.apache.org/jira/browse/MAHOUT-229
> Project: Mahout
> Issue Type: Improvement
> Components: Math
> Affects Versions: 0.4
> Reporter: Benson Margulies
> Fix For: 0.4
>
> Attachments: array_list_patch2.diff, array_list_patch3.diff
>
>
> Clean up the code in org.apache.mahout.math.list, including some testing and cleanup of some things that it calls.
> This includes:
> 1) More features in the Velocity code generator, including code to avoid generating a shadow of a checked-in file, and code to allow explicit suppression of individual outputs. Also an extra macro or two to make the template neater in some cases.
> 2) The stack of code from AbstractList to AbstractXxxList to XxxArrayList generated with templates. AbstractCollection eliminated. ObjectArrayList preserved for now until the maps can be weaned from it.
> 3) Removed 2 broken functions from the Sorting class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAHOUT-229) Clean up and templatize the
primitive list containers
Posted by "Benson Margulies (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12796004#action_12796004 ]
Benson Margulies commented on MAHOUT-229:
-----------------------------------------
Anil committed it, but didn't close.
> Clean up and templatize the primitive list containers
> -----------------------------------------------------
>
> Key: MAHOUT-229
> URL: https://issues.apache.org/jira/browse/MAHOUT-229
> Project: Mahout
> Issue Type: Improvement
> Components: Math
> Affects Versions: 0.4
> Reporter: Benson Margulies
> Fix For: 0.4
>
> Attachments: array_list_patch2.diff, array_list_patch3.diff
>
>
> Clean up the code in org.apache.mahout.math.list, including some testing and cleanup of some things that it calls.
> This includes:
> 1) More features in the Velocity code generator, including code to avoid generating a shadow of a checked-in file, and code to allow explicit suppression of individual outputs. Also an extra macro or two to make the template neater in some cases.
> 2) The stack of code from AbstractList to AbstractXxxList to XxxArrayList generated with templates. AbstractCollection eliminated. ObjectArrayList preserved for now until the maps can be weaned from it.
> 3) Removed 2 broken functions from the Sorting class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAHOUT-229) Clean up and templatize the primitive
list containers
Posted by "Benson Margulies (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benson Margulies updated MAHOUT-229:
------------------------------------
Attachment: array_list_patch3.diff
Fix whining in the buffer consumer template, fix for Windows.
> Clean up and templatize the primitive list containers
> -----------------------------------------------------
>
> Key: MAHOUT-229
> URL: https://issues.apache.org/jira/browse/MAHOUT-229
> Project: Mahout
> Issue Type: Improvement
> Components: Math
> Affects Versions: 0.4
> Reporter: Benson Margulies
> Fix For: 0.4
>
> Attachments: array_list_patch3.diff
>
>
> Clean up the code in org.apache.mahout.math.list, including some testing and cleanup of some things that it calls.
> This includes:
> 1) More features in the Velocity code generator, including code to avoid generating a shadow of a checked-in file, and code to allow explicit suppression of individual outputs. Also an extra macro or two to make the template neater in some cases.
> 2) The stack of code from AbstractList to AbstractXxxList to XxxArrayList generated with templates. AbstractCollection eliminated. ObjectArrayList preserved for now until the maps can be weaned from it.
> 3) Removed 2 broken functions from the Sorting class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAHOUT-229) Clean up and templatize the primitive
list containers
Posted by "Sean Owen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sean Owen updated MAHOUT-229:
-----------------------------
Resolution: Fixed
Fix Version/s: (was: 0.4)
0.3
Status: Resolved (was: Patch Available)
> Clean up and templatize the primitive list containers
> -----------------------------------------------------
>
> Key: MAHOUT-229
> URL: https://issues.apache.org/jira/browse/MAHOUT-229
> Project: Mahout
> Issue Type: Improvement
> Components: Math
> Affects Versions: 0.2
> Reporter: Benson Margulies
> Fix For: 0.3
>
> Attachments: array_list_patch2.diff, array_list_patch3.diff
>
>
> Clean up the code in org.apache.mahout.math.list, including some testing and cleanup of some things that it calls.
> This includes:
> 1) More features in the Velocity code generator, including code to avoid generating a shadow of a checked-in file, and code to allow explicit suppression of individual outputs. Also an extra macro or two to make the template neater in some cases.
> 2) The stack of code from AbstractList to AbstractXxxList to XxxArrayList generated with templates. AbstractCollection eliminated. ObjectArrayList preserved for now until the maps can be weaned from it.
> 3) Removed 2 broken functions from the Sorting class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAHOUT-229) Clean up and templatize the primitive
list containers
Posted by "Benson Margulies (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benson Margulies updated MAHOUT-229:
------------------------------------
Attachment: forSean.log
Here is a log of the results of applying the patch to a clean checkout and then running mvn clean install on my machine.
> Clean up and templatize the primitive list containers
> -----------------------------------------------------
>
> Key: MAHOUT-229
> URL: https://issues.apache.org/jira/browse/MAHOUT-229
> Project: Mahout
> Issue Type: Improvement
> Components: Math
> Affects Versions: 0.4
> Reporter: Benson Margulies
> Fix For: 0.4
>
> Attachments: array_list_patch.diff, forSean.log
>
>
> Clean up the code in org.apache.mahout.math.list, including some testing and cleanup of some things that it calls.
> This includes:
> 1) More features in the Velocity code generator, including code to avoid generating a shadow of a checked-in file, and code to allow explicit suppression of individual outputs. Also an extra macro or two to make the template neater in some cases.
> 2) The stack of code from AbstractList to AbstractXxxList to XxxArrayList generated with templates. AbstractCollection eliminated. ObjectArrayList preserved for now until the maps can be weaned from it.
> 3) Removed 2 broken functions from the Sorting class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAHOUT-229) Clean up and templatize the
primitive list containers
Posted by "Benson Margulies (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12794391#action_12794391 ]
Benson Margulies commented on MAHOUT-229:
-----------------------------------------
Right. And then you'll have to add the generated directories to your IDE's source lists. One for code, one for test.
> Clean up and templatize the primitive list containers
> -----------------------------------------------------
>
> Key: MAHOUT-229
> URL: https://issues.apache.org/jira/browse/MAHOUT-229
> Project: Mahout
> Issue Type: Improvement
> Components: Math
> Affects Versions: 0.4
> Reporter: Benson Margulies
> Fix For: 0.4
>
> Attachments: array_list_patch.diff
>
>
> Clean up the code in org.apache.mahout.math.list, including some testing and cleanup of some things that it calls.
> This includes:
> 1) More features in the Velocity code generator, including code to avoid generating a shadow of a checked-in file, and code to allow explicit suppression of individual outputs. Also an extra macro or two to make the template neater in some cases.
> 2) The stack of code from AbstractList to AbstractXxxList to XxxArrayList generated with templates. AbstractCollection eliminated. ObjectArrayList preserved for now until the maps can be weaned from it.
> 3) Removed 2 broken functions from the Sorting class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAHOUT-229) Clean up and templatize the
primitive list containers
Posted by "Sean Owen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12794389#action_12794389 ]
Sean Owen commented on MAHOUT-229:
----------------------------------
Oh, wait. So I would have to run the build with Maven I guess. Oops I just patched in the IDE and didn't think that through when I noticed compile errors.
> Clean up and templatize the primitive list containers
> -----------------------------------------------------
>
> Key: MAHOUT-229
> URL: https://issues.apache.org/jira/browse/MAHOUT-229
> Project: Mahout
> Issue Type: Improvement
> Components: Math
> Affects Versions: 0.4
> Reporter: Benson Margulies
> Fix For: 0.4
>
> Attachments: array_list_patch.diff
>
>
> Clean up the code in org.apache.mahout.math.list, including some testing and cleanup of some things that it calls.
> This includes:
> 1) More features in the Velocity code generator, including code to avoid generating a shadow of a checked-in file, and code to allow explicit suppression of individual outputs. Also an extra macro or two to make the template neater in some cases.
> 2) The stack of code from AbstractList to AbstractXxxList to XxxArrayList generated with templates. AbstractCollection eliminated. ObjectArrayList preserved for now until the maps can be weaned from it.
> 3) Removed 2 broken functions from the Sorting class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAHOUT-229) Clean up and templatize the primitive
list containers
Posted by "Sean Owen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sean Owen updated MAHOUT-229:
-----------------------------
Affects Version/s: (was: 0.4)
0.2
Assignee: Benson Margulies
> Clean up and templatize the primitive list containers
> -----------------------------------------------------
>
> Key: MAHOUT-229
> URL: https://issues.apache.org/jira/browse/MAHOUT-229
> Project: Mahout
> Issue Type: Improvement
> Components: Math
> Affects Versions: 0.2
> Reporter: Benson Margulies
> Assignee: Benson Margulies
> Fix For: 0.3
>
> Attachments: array_list_patch2.diff, array_list_patch3.diff
>
>
> Clean up the code in org.apache.mahout.math.list, including some testing and cleanup of some things that it calls.
> This includes:
> 1) More features in the Velocity code generator, including code to avoid generating a shadow of a checked-in file, and code to allow explicit suppression of individual outputs. Also an extra macro or two to make the template neater in some cases.
> 2) The stack of code from AbstractList to AbstractXxxList to XxxArrayList generated with templates. AbstractCollection eliminated. ObjectArrayList preserved for now until the maps can be weaned from it.
> 3) Removed 2 broken functions from the Sorting class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAHOUT-229) Clean up and templatize the
primitive list containers
Posted by "Benson Margulies (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12794425#action_12794425 ]
Benson Margulies commented on MAHOUT-229:
-----------------------------------------
That could result from failing to rebuild the code generator itself.
> Clean up and templatize the primitive list containers
> -----------------------------------------------------
>
> Key: MAHOUT-229
> URL: https://issues.apache.org/jira/browse/MAHOUT-229
> Project: Mahout
> Issue Type: Improvement
> Components: Math
> Affects Versions: 0.4
> Reporter: Benson Margulies
> Fix For: 0.4
>
> Attachments: array_list_patch.diff
>
>
> Clean up the code in org.apache.mahout.math.list, including some testing and cleanup of some things that it calls.
> This includes:
> 1) More features in the Velocity code generator, including code to avoid generating a shadow of a checked-in file, and code to allow explicit suppression of individual outputs. Also an extra macro or two to make the template neater in some cases.
> 2) The stack of code from AbstractList to AbstractXxxList to XxxArrayList generated with templates. AbstractCollection eliminated. ObjectArrayList preserved for now until the maps can be weaned from it.
> 3) Removed 2 broken functions from the Sorting class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAHOUT-229) Clean up and templatize the
primitive list containers
Posted by "Sean Owen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12794431#action_12794431 ]
Sean Owen commented on MAHOUT-229:
----------------------------------
Could still be doing something wrong but I rebuilt the codegen bit "mvn clean install" and tried "mvn clean compile" again, and got the same result.
> Clean up and templatize the primitive list containers
> -----------------------------------------------------
>
> Key: MAHOUT-229
> URL: https://issues.apache.org/jira/browse/MAHOUT-229
> Project: Mahout
> Issue Type: Improvement
> Components: Math
> Affects Versions: 0.4
> Reporter: Benson Margulies
> Fix For: 0.4
>
> Attachments: array_list_patch.diff
>
>
> Clean up the code in org.apache.mahout.math.list, including some testing and cleanup of some things that it calls.
> This includes:
> 1) More features in the Velocity code generator, including code to avoid generating a shadow of a checked-in file, and code to allow explicit suppression of individual outputs. Also an extra macro or two to make the template neater in some cases.
> 2) The stack of code from AbstractList to AbstractXxxList to XxxArrayList generated with templates. AbstractCollection eliminated. ObjectArrayList preserved for now until the maps can be weaned from it.
> 3) Removed 2 broken functions from the Sorting class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAHOUT-229) Clean up and templatize the primitive
list containers
Posted by "Benson Margulies (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benson Margulies updated MAHOUT-229:
------------------------------------
Attachment: array_list_patch2.diff
> Clean up and templatize the primitive list containers
> -----------------------------------------------------
>
> Key: MAHOUT-229
> URL: https://issues.apache.org/jira/browse/MAHOUT-229
> Project: Mahout
> Issue Type: Improvement
> Components: Math
> Affects Versions: 0.4
> Reporter: Benson Margulies
> Fix For: 0.4
>
> Attachments: array_list_patch2.diff, forSean.log
>
>
> Clean up the code in org.apache.mahout.math.list, including some testing and cleanup of some things that it calls.
> This includes:
> 1) More features in the Velocity code generator, including code to avoid generating a shadow of a checked-in file, and code to allow explicit suppression of individual outputs. Also an extra macro or two to make the template neater in some cases.
> 2) The stack of code from AbstractList to AbstractXxxList to XxxArrayList generated with templates. AbstractCollection eliminated. ObjectArrayList preserved for now until the maps can be weaned from it.
> 3) Removed 2 broken functions from the Sorting class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAHOUT-229) Clean up and templatize the
primitive list containers
Posted by "Benson Margulies (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12794388#action_12794388 ]
Benson Margulies commented on MAHOUT-229:
-----------------------------------------
DoubleArrayList should be generated. I'll check into it.
> Clean up and templatize the primitive list containers
> -----------------------------------------------------
>
> Key: MAHOUT-229
> URL: https://issues.apache.org/jira/browse/MAHOUT-229
> Project: Mahout
> Issue Type: Improvement
> Components: Math
> Affects Versions: 0.4
> Reporter: Benson Margulies
> Fix For: 0.4
>
> Attachments: array_list_patch.diff
>
>
> Clean up the code in org.apache.mahout.math.list, including some testing and cleanup of some things that it calls.
> This includes:
> 1) More features in the Velocity code generator, including code to avoid generating a shadow of a checked-in file, and code to allow explicit suppression of individual outputs. Also an extra macro or two to make the template neater in some cases.
> 2) The stack of code from AbstractList to AbstractXxxList to XxxArrayList generated with templates. AbstractCollection eliminated. ObjectArrayList preserved for now until the maps can be weaned from it.
> 3) Removed 2 broken functions from the Sorting class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAHOUT-229) Clean up and templatize the
primitive list containers
Posted by "Robin Anil (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12794935#action_12794935 ]
Robin Anil commented on MAHOUT-229:
-----------------------------------
Path applies cleanly. Tests passes on both windows and linux
> Clean up and templatize the primitive list containers
> -----------------------------------------------------
>
> Key: MAHOUT-229
> URL: https://issues.apache.org/jira/browse/MAHOUT-229
> Project: Mahout
> Issue Type: Improvement
> Components: Math
> Affects Versions: 0.4
> Reporter: Benson Margulies
> Fix For: 0.4
>
> Attachments: array_list_patch2.diff, array_list_patch3.diff
>
>
> Clean up the code in org.apache.mahout.math.list, including some testing and cleanup of some things that it calls.
> This includes:
> 1) More features in the Velocity code generator, including code to avoid generating a shadow of a checked-in file, and code to allow explicit suppression of individual outputs. Also an extra macro or two to make the template neater in some cases.
> 2) The stack of code from AbstractList to AbstractXxxList to XxxArrayList generated with templates. AbstractCollection eliminated. ObjectArrayList preserved for now until the maps can be weaned from it.
> 3) Removed 2 broken functions from the Sorting class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAHOUT-229) Clean up and templatize the
primitive list containers
Posted by "Sean Owen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12794397#action_12794397 ]
Sean Owen commented on MAHOUT-229:
----------------------------------
I'm seeing things like this, in AbstractByteList for instance:
/** Returns a <code>ArrayList</code> containing all the elements in the receiver. */
public List<${valueObjectType}> toList() {
int mySize = size();
List<${valueObjectType}> list = new ArrayList<${valueObjectType}>(mySize);
for (int i = 0; i < mySize; i++) {
list.add(get(i));
}
return list;
}
> Clean up and templatize the primitive list containers
> -----------------------------------------------------
>
> Key: MAHOUT-229
> URL: https://issues.apache.org/jira/browse/MAHOUT-229
> Project: Mahout
> Issue Type: Improvement
> Components: Math
> Affects Versions: 0.4
> Reporter: Benson Margulies
> Fix For: 0.4
>
> Attachments: array_list_patch.diff
>
>
> Clean up the code in org.apache.mahout.math.list, including some testing and cleanup of some things that it calls.
> This includes:
> 1) More features in the Velocity code generator, including code to avoid generating a shadow of a checked-in file, and code to allow explicit suppression of individual outputs. Also an extra macro or two to make the template neater in some cases.
> 2) The stack of code from AbstractList to AbstractXxxList to XxxArrayList generated with templates. AbstractCollection eliminated. ObjectArrayList preserved for now until the maps can be weaned from it.
> 3) Removed 2 broken functions from the Sorting class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAHOUT-229) Clean up and templatize the primitive
list containers
Posted by "Benson Margulies (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benson Margulies updated MAHOUT-229:
------------------------------------
Attachment: (was: array_list_patch2.diff)
> Clean up and templatize the primitive list containers
> -----------------------------------------------------
>
> Key: MAHOUT-229
> URL: https://issues.apache.org/jira/browse/MAHOUT-229
> Project: Mahout
> Issue Type: Improvement
> Components: Math
> Affects Versions: 0.4
> Reporter: Benson Margulies
> Fix For: 0.4
>
> Attachments: array_list_patch3.diff
>
>
> Clean up the code in org.apache.mahout.math.list, including some testing and cleanup of some things that it calls.
> This includes:
> 1) More features in the Velocity code generator, including code to avoid generating a shadow of a checked-in file, and code to allow explicit suppression of individual outputs. Also an extra macro or two to make the template neater in some cases.
> 2) The stack of code from AbstractList to AbstractXxxList to XxxArrayList generated with templates. AbstractCollection eliminated. ObjectArrayList preserved for now until the maps can be weaned from it.
> 3) Removed 2 broken functions from the Sorting class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAHOUT-229) Clean up and templatize the primitive
list containers
Posted by "Benson Margulies (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benson Margulies updated MAHOUT-229:
------------------------------------
Attachment: array_list_patch.diff
Lots of changes.
> Clean up and templatize the primitive list containers
> -----------------------------------------------------
>
> Key: MAHOUT-229
> URL: https://issues.apache.org/jira/browse/MAHOUT-229
> Project: Mahout
> Issue Type: Improvement
> Components: Matrix
> Affects Versions: 0.4
> Reporter: Benson Margulies
> Fix For: 0.4
>
> Attachments: array_list_patch.diff
>
>
> Clean up the code in org.apache.mahout.math.list, including some testing and cleanup of some things that it calls.
> This includes:
> 1) More features in the Velocity code generator, including code to avoid generating a shadow of a checked-in file, and code to allow explicit suppression of individual outputs. Also an extra macro or two to make the template neater in some cases.
> 2) The stack of code from AbstractList to AbstractXxxList to XxxArrayList generated with templates. AbstractCollection eliminated. ObjectArrayList preserved for now until the maps can be weaned from it.
> 3) Removed 2 broken functions from the Sorting class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAHOUT-229) Clean up and templatize the
primitive list containers
Posted by "Sean Owen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12794380#action_12794380 ]
Sean Owen commented on MAHOUT-229:
----------------------------------
This isn't compiling for me -- for example DoubleArrayList is deleted but still used?
> Clean up and templatize the primitive list containers
> -----------------------------------------------------
>
> Key: MAHOUT-229
> URL: https://issues.apache.org/jira/browse/MAHOUT-229
> Project: Mahout
> Issue Type: Improvement
> Components: Math
> Affects Versions: 0.4
> Reporter: Benson Margulies
> Fix For: 0.4
>
> Attachments: array_list_patch.diff
>
>
> Clean up the code in org.apache.mahout.math.list, including some testing and cleanup of some things that it calls.
> This includes:
> 1) More features in the Velocity code generator, including code to avoid generating a shadow of a checked-in file, and code to allow explicit suppression of individual outputs. Also an extra macro or two to make the template neater in some cases.
> 2) The stack of code from AbstractList to AbstractXxxList to XxxArrayList generated with templates. AbstractCollection eliminated. ObjectArrayList preserved for now until the maps can be weaned from it.
> 3) Removed 2 broken functions from the Sorting class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAHOUT-229) Clean up and templatize the
primitive list containers
Posted by "Benson Margulies (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12794436#action_12794436 ]
Benson Margulies commented on MAHOUT-229:
-----------------------------------------
Hmm. I'll apply the patch to a clean tree and see what I get.
> Clean up and templatize the primitive list containers
> -----------------------------------------------------
>
> Key: MAHOUT-229
> URL: https://issues.apache.org/jira/browse/MAHOUT-229
> Project: Mahout
> Issue Type: Improvement
> Components: Math
> Affects Versions: 0.4
> Reporter: Benson Margulies
> Fix For: 0.4
>
> Attachments: array_list_patch.diff
>
>
> Clean up the code in org.apache.mahout.math.list, including some testing and cleanup of some things that it calls.
> This includes:
> 1) More features in the Velocity code generator, including code to avoid generating a shadow of a checked-in file, and code to allow explicit suppression of individual outputs. Also an extra macro or two to make the template neater in some cases.
> 2) The stack of code from AbstractList to AbstractXxxList to XxxArrayList generated with templates. AbstractCollection eliminated. ObjectArrayList preserved for now until the maps can be weaned from it.
> 3) Removed 2 broken functions from the Sorting class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAHOUT-229) Clean up and templatize the primitive
list containers
Posted by "Benson Margulies (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benson Margulies updated MAHOUT-229:
------------------------------------
Attachment: (was: forSean.log)
> Clean up and templatize the primitive list containers
> -----------------------------------------------------
>
> Key: MAHOUT-229
> URL: https://issues.apache.org/jira/browse/MAHOUT-229
> Project: Mahout
> Issue Type: Improvement
> Components: Math
> Affects Versions: 0.4
> Reporter: Benson Margulies
> Fix For: 0.4
>
> Attachments: array_list_patch3.diff
>
>
> Clean up the code in org.apache.mahout.math.list, including some testing and cleanup of some things that it calls.
> This includes:
> 1) More features in the Velocity code generator, including code to avoid generating a shadow of a checked-in file, and code to allow explicit suppression of individual outputs. Also an extra macro or two to make the template neater in some cases.
> 2) The stack of code from AbstractList to AbstractXxxList to XxxArrayList generated with templates. AbstractCollection eliminated. ObjectArrayList preserved for now until the maps can be weaned from it.
> 3) Removed 2 broken functions from the Sorting class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAHOUT-229) Clean up and templatize the primitive
list containers
Posted by "Benson Margulies (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benson Margulies updated MAHOUT-229:
------------------------------------
Fix Version/s: 0.4
Status: Patch Available (was: Open)
> Clean up and templatize the primitive list containers
> -----------------------------------------------------
>
> Key: MAHOUT-229
> URL: https://issues.apache.org/jira/browse/MAHOUT-229
> Project: Mahout
> Issue Type: Improvement
> Components: Matrix
> Affects Versions: 0.4
> Reporter: Benson Margulies
> Fix For: 0.4
>
> Attachments: array_list_patch.diff
>
>
> Clean up the code in org.apache.mahout.math.list, including some testing and cleanup of some things that it calls.
> This includes:
> 1) More features in the Velocity code generator, including code to avoid generating a shadow of a checked-in file, and code to allow explicit suppression of individual outputs. Also an extra macro or two to make the template neater in some cases.
> 2) The stack of code from AbstractList to AbstractXxxList to XxxArrayList generated with templates. AbstractCollection eliminated. ObjectArrayList preserved for now until the maps can be weaned from it.
> 3) Removed 2 broken functions from the Sorting class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAHOUT-229) Clean up and templatize the
primitive list containers
Posted by "Benson Margulies (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12794934#action_12794934 ]
Benson Margulies commented on MAHOUT-229:
-----------------------------------------
Deleted file list.
D math/src/main/java/org/apache/mahout/math/function/CharComparator.java
D math/src/main/java/org/apache/mahout/math/function/ShortProcedure.java
D math/src/main/java/org/apache/mahout/math/function/LongProcedure.java
D math/src/main/java/org/apache/mahout/math/function/ByteProcedure.java
D math/src/main/java/org/apache/mahout/math/function/FloatProcedure.java
D math/src/main/java/org/apache/mahout/math/function/IntComparator.java
D math/src/main/java/org/apache/mahout/math/function/ShortComparator.java
D math/src/main/java/org/apache/mahout/math/function/LongComparator.java
D math/src/main/java/org/apache/mahout/math/function/ByteComparator.java
D math/src/main/java/org/apache/mahout/math/function/FloatComparator.java
D math/src/main/java/org/apache/mahout/math/function/DoubleComparator.java
D math/src/main/java/org/apache/mahout/math/function/IntProcedure.java
D math/src/main/java/org/apache/mahout/math/function/DoubleProcedure.java
D math/src/main/java/org/apache/mahout/math/function/CharProcedure.java
D math/src/main/java/org/apache/mahout/math/buffer/IntBufferConsumer.java
D math/src/main/java/org/apache/mahout/math/buffer/DoubleBufferConsumer.java
D math/src/main/java/org/apache/mahout/math/list/AbstractBooleanList.java
D math/src/main/java/org/apache/mahout/math/list/adapter/ObjectListAdapter.java
D math/src/main/java/org/apache/mahout/math/list/FloatArrayList.java
D math/src/main/java/org/apache/mahout/math/list/DoubleArrayList.java
D math/src/main/java/org/apache/mahout/math/list/CharArrayList.java
D math/src/main/java/org/apache/mahout/math/list/AbstractIntList.java
D math/src/main/java/org/apache/mahout/math/list/BooleanArrayList.java
D math/src/main/java/org/apache/mahout/math/list/AbstractCollection.java
D math/src/main/java/org/apache/mahout/math/list/AbstractLongList.java
D math/src/main/java/org/apache/mahout/math/list/AbstractShortList.java
D math/src/main/java/org/apache/mahout/math/list/AbstractByteList.java
D math/src/main/java/org/apache/mahout/math/list/AbstractFloatList.java
D math/src/main/java/org/apache/mahout/math/list/IntArrayList.java
D math/src/main/java/org/apache/mahout/math/list/AbstractDoubleList.java
D math/src/main/java/org/apache/mahout/math/list/LongArrayList.java
D math/src/main/java/org/apache/mahout/math/list/ShortArrayList.java
D math/src/main/java/org/apache/mahout/math/list/AbstractCharList.java
D math/src/main/java/org/apache/mahout/math/list/ByteArrayList.java
> Clean up and templatize the primitive list containers
> -----------------------------------------------------
>
> Key: MAHOUT-229
> URL: https://issues.apache.org/jira/browse/MAHOUT-229
> Project: Mahout
> Issue Type: Improvement
> Components: Math
> Affects Versions: 0.4
> Reporter: Benson Margulies
> Fix For: 0.4
>
> Attachments: array_list_patch2.diff, array_list_patch3.diff
>
>
> Clean up the code in org.apache.mahout.math.list, including some testing and cleanup of some things that it calls.
> This includes:
> 1) More features in the Velocity code generator, including code to avoid generating a shadow of a checked-in file, and code to allow explicit suppression of individual outputs. Also an extra macro or two to make the template neater in some cases.
> 2) The stack of code from AbstractList to AbstractXxxList to XxxArrayList generated with templates. AbstractCollection eliminated. ObjectArrayList preserved for now until the maps can be weaned from it.
> 3) Removed 2 broken functions from the Sorting class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAHOUT-229) Clean up and templatize the primitive
list containers
Posted by "Benson Margulies (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benson Margulies updated MAHOUT-229:
------------------------------------
Attachment: (was: array_list_patch.diff)
> Clean up and templatize the primitive list containers
> -----------------------------------------------------
>
> Key: MAHOUT-229
> URL: https://issues.apache.org/jira/browse/MAHOUT-229
> Project: Mahout
> Issue Type: Improvement
> Components: Math
> Affects Versions: 0.4
> Reporter: Benson Margulies
> Fix For: 0.4
>
> Attachments: array_list_patch2.diff, forSean.log
>
>
> Clean up the code in org.apache.mahout.math.list, including some testing and cleanup of some things that it calls.
> This includes:
> 1) More features in the Velocity code generator, including code to avoid generating a shadow of a checked-in file, and code to allow explicit suppression of individual outputs. Also an extra macro or two to make the template neater in some cases.
> 2) The stack of code from AbstractList to AbstractXxxList to XxxArrayList generated with templates. AbstractCollection eliminated. ObjectArrayList preserved for now until the maps can be weaned from it.
> 3) Removed 2 broken functions from the Sorting class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAHOUT-229) Clean up and templatize the
primitive list containers
Posted by "Benson Margulies (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12794512#action_12794512 ]
Benson Margulies commented on MAHOUT-229:
-----------------------------------------
Note there was a minor conflict in the math pom.xml; I can repost the patch with the conflict resolved.
> Clean up and templatize the primitive list containers
> -----------------------------------------------------
>
> Key: MAHOUT-229
> URL: https://issues.apache.org/jira/browse/MAHOUT-229
> Project: Mahout
> Issue Type: Improvement
> Components: Math
> Affects Versions: 0.4
> Reporter: Benson Margulies
> Fix For: 0.4
>
> Attachments: array_list_patch.diff, forSean.log
>
>
> Clean up the code in org.apache.mahout.math.list, including some testing and cleanup of some things that it calls.
> This includes:
> 1) More features in the Velocity code generator, including code to avoid generating a shadow of a checked-in file, and code to allow explicit suppression of individual outputs. Also an extra macro or two to make the template neater in some cases.
> 2) The stack of code from AbstractList to AbstractXxxList to XxxArrayList generated with templates. AbstractCollection eliminated. ObjectArrayList preserved for now until the maps can be weaned from it.
> 3) Removed 2 broken functions from the Sorting class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.