You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Greg Hudson <gh...@MIT.EDU> on 2004/09/18 22:16:22 UTC
Re: [PATCH] Fix cross-library installation dependencies for
libsvn_fs and libsvn_fs_base
The attached patch only seems to contain the diff against gen_make.py.
More importantly, though, what problem are you trying to solve here?
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Allow JavaHL to be installed separately from main Subversion package (was: Re: [PATCH] Fix cross-library installation dependencies for libsvn_fs and libsvn_fs_base)
Posted by David James <st...@gmail.com>.
> I'm actually interested in the methodology of your first patch, which
> split up the install rules into one rule for each file. Obviously we
> can't use the timestamps of what's in the installed area, but having a
> separate install rule for each library would mean that (a) we could get
> rid of the five separate library types in favor of a single "lib" type,
> and (b) we could stop relying on "make" evaluating dependencies in
> order, so that our Makefile would have a hope of operating in parallel
> mode. (Not that one would ever really want to use "make -j install",
> but it's still more elegant not to rely on dependency order.)
>
> Since we can't use files from the install area as rule targets, the
> separate rule for each file would have to be a fake target name like
> install-<filename>.
Great idea. Anyone opposed to me implementing this?
Cheers,
David
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Allow JavaHL to be installed separately from main
Subversion package (was: Re: [PATCH] Fix cross-library installation
dependencies for libsvn_fs and libsvn_fs_base)
Posted by Greg Hudson <gh...@MIT.EDU>.
On Sun, 2004-09-19 at 04:33, David James wrote:
> This patch fixes the JavaHL installation process so that you can
> install JavaHL separately from the base subversion package. It does
> this by keeping track of the installation dependencies for the
> libsvn_fs and libsvn_ra libraries.
Committed, thanks.
I'm actually interested in the methodology of your first patch, which
split up the install rules into one rule for each file. Obviously we
can't use the timestamps of what's in the installed area, but having a
separate install rule for each library would mean that (a) we could get
rid of the five separate library types in favor of a single "lib" type,
and (b) we could stop relying on "make" evaluating dependencies in
order, so that our Makefile would have a hope of operating in parallel
mode. (Not that one would ever really want to use "make -j install",
but it's still more elegant not to rely on dependency order.)
Since we can't use files from the install area as rule targets, the
separate rule for each file would have to be a fake target name like
install-<filename>.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
[PATCH] Allow JavaHL to be installed separately from main Subversion package (was: Re: [PATCH] Fix cross-library installation dependencies for libsvn_fs and libsvn_fs_base)
Posted by David James <st...@gmail.com>.
(This patch is identical to my prior patch. I've reformatted the log
message of my patch to match the desired Subversion style,.as
requested by Jani Averbach)
This patch fixes the JavaHL installation process so that you can
install JavaHL separately from the base subversion package. It does
this by keeping track of the installation dependencies for the
libsvn_fs and libsvn_ra libraries.
* configure.in
(libsvn_fs, libsvn_ra): Added SVN_RA_LIB_INSTALL_DEPS and
SVN_FS_LIB_INSTALL_DEPS to keep track of installation dependencies
for libsvn_ra and libsvn_fs
* Makefile.in
(libsvn_fs, libsvn_ra): Added SVN_RA_LIB_INSTALL_DEPS and
SVN_FS_LIB_INSTALL_DEPS to keep track of installation dependencies
for libsvn_ra and libsvn_fs
* build.conf:
(libsvn_fs): Added $(SVN_FS_LIB_INSTALL_DEPS) to install deps of
libsvn_fs
(libsvn_ra): Added $(SVN_RA_LIB_INSTALL_DEPS) to install deps of
libsvn_fs_base
* build/generator/gen_base.py
(gen_base.Target): Added 'add-install-deps' option for build.conf to
list additional installation dependencies
* build/generator/gen_make.py
(gen_make.Generator.write): Upgraded dependency checker to support
manual cross-library installation dependencies
Re: [PATCH] Fix cross-library installation dependencies for libsvn_fs and libsvn_fs_base
Posted by David James <st...@gmail.com>.
I've redesigned my patch to fix the issues mentioned by Greg Hudson at
<http://www.contactor.se/~dast/svn/archive-2004-09/0644.shtml>. This
new patch is also substantially simpler and easier to understand.
LOG MESSAGE:
* configure.in
(libsvn_fs, libsvn_ra): Added SVN_RA_LIB_INSTALL_DEPS and
SVN_FS_LIB_INSTALL_DEPS to keep track of installation dependences for
libsvn_ra and libsvn_fs
* Makefile.in
(libsvn_fs, libsvn_ra): Added SVN_RA_LIB_INSTALL_DEPS and
SVN_FS_LIB_INSTALL_DEPS to keep track of installation dependences for
libsvn_ra and libsvn_fs
* build.conf:
(libsvn_fs): Added $(SVN_FS_LIB_INSTALL_DEPS) to install deps of libsvn_fs
(libsvn_ra): Added $(SVN_RA_LIB_INSTALL_DEPS) to install deps of libsvn_fs_base
* build/generator/gen_base.py
(gen_base.Target): Added 'add-install-deps' option for build.conf to
list additional installation dependencies
* build/generator/gen_make.py
(gen_make.Generator.write): Upgraded dependency checker to support
manual cross-library installation dependencies
PURPOSE OF PATCH:
I'm trying to make the following pattern work:
1. ./configure [with appropriate options]
2. make javahl
3. make install-javahl
Unfortunately, when you type those three commands, the build fails
with a mysterious error about libsvn_ra-1.la being missing. This patch
fixes that bug by fixing the dependencies for the libsvn_fs and
libsvn_ra libraries. The complete patch is attached.
Cheers,
David
On Sat, 18 Sep 2004 18:51:41 -0400, David James <st...@gmail.com> wrote:
> I'm trying to make the following pattern work:
> 1. ./configure [with appropriate options]
> 2. make javahl
> 3. make install-javahl
>
> Unfortunately, when you type those three commands, the build fails
> with a mysterious error about libsvn_ra-1.la being missing. This patch
> fixes that bug by fixing the dependencies for the libsvn_fs and
> libsvn_fs_base libraries. The complete patch is attached.
>
> Cheers,
>
> David
>
>
>
>
Re: [PATCH] Fix cross-library installation dependencies for libsvn_fs and libsvn_fs_base
Posted by David James <st...@gmail.com>.
I'm trying to make the following pattern work:
1. ./configure [with appropriate options]
2. make javahl
3. make install-javahl
Unfortunately, when you type those three commands, the build fails
with a mysterious error about libsvn_ra-1.la being missing. This patch
fixes that bug by fixing the dependencies for the libsvn_fs and
libsvn_fs_base libraries. The complete patch is attached.
Cheers,
David