You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/09/08 07:33:56 UTC
[GitHub] [spark] wzhfy opened a new pull request #29671: [SPARK-32817] DPP throws error when broadcast side is empty
wzhfy opened a new pull request #29671:
URL: https://github.com/apache/spark/pull/29671
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
In `SubqueryBroadcastExec.relationFuture`, if the `broadcastRelation` is an `EmptyHashedRelation`, then `broadcastRelation.keys()` will throw `UnsupportedOperationException`.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
To fix a bug.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
Added a new test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29671: [SPARK-32817] DPP throws error when broadcast side is empty
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29671:
URL: https://github.com/apache/spark/pull/29671#issuecomment-688683381
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wzhfy commented on a change in pull request #29671: [SPARK-32817][SQL] DPP throws error when broadcast side is empty
Posted by GitBox <gi...@apache.org>.
wzhfy commented on a change in pull request #29671:
URL: https://github.com/apache/spark/pull/29671#discussion_r484735376
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/SubqueryBroadcastExec.scala
##########
@@ -75,17 +75,21 @@ case class SubqueryBroadcastExec(
val beforeCollect = System.nanoTime()
val broadcastRelation = child.executeBroadcast[HashedRelation]().value
- val (iter, expr) = if (broadcastRelation.isInstanceOf[LongHashedRelation]) {
- (broadcastRelation.keys(), HashJoin.extractKeyExprAt(buildKeys, index))
- } else {
- (broadcastRelation.keys(),
- BoundReference(index, buildKeys(index).dataType, buildKeys(index).nullable))
+ val rows = broadcastRelation match {
+ case EmptyHashedRelation =>
+ Array.empty[InternalRow]
Review comment:
also cc @cloud-fan and the original author @leanken
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29671: [SPARK-32817][SQL] DPP throws error when broadcast side is empty
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29671:
URL: https://github.com/apache/spark/pull/29671#issuecomment-688965646
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29671: [SPARK-32817][SQL] DPP throws error when broadcast side is empty
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29671:
URL: https://github.com/apache/spark/pull/29671#issuecomment-688833818
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] leanken commented on a change in pull request #29671: [SPARK-32817][SQL] DPP throws error when broadcast side is empty
Posted by GitBox <gi...@apache.org>.
leanken commented on a change in pull request #29671:
URL: https://github.com/apache/spark/pull/29671#discussion_r484740226
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/SubqueryBroadcastExec.scala
##########
@@ -75,17 +75,21 @@ case class SubqueryBroadcastExec(
val beforeCollect = System.nanoTime()
val broadcastRelation = child.executeBroadcast[HashedRelation]().value
- val (iter, expr) = if (broadcastRelation.isInstanceOf[LongHashedRelation]) {
- (broadcastRelation.keys(), HashJoin.extractKeyExprAt(buildKeys, index))
- } else {
- (broadcastRelation.keys(),
- BoundReference(index, buildKeys(index).dataType, buildKeys(index).nullable))
+ val rows = broadcastRelation match {
+ case EmptyHashedRelation =>
+ Array.empty[InternalRow]
Review comment:
it's originally throws an exception because it's supposed not to be called. But since you found a exception case here, i think it should return a empty iterator instead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29671: [SPARK-32817][SQL] DPP throws error when broadcast side is empty
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29671:
URL: https://github.com/apache/spark/pull/29671#issuecomment-688833818
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #29671: [SPARK-32817][SQL] DPP throws error when broadcast side is empty
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #29671:
URL: https://github.com/apache/spark/pull/29671#issuecomment-688837799
GA passed, so merged to mater. Thanks, @wzhfy !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #29671: [SPARK-32817] DPP throws error when broadcast side is empty
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #29671:
URL: https://github.com/apache/spark/pull/29671#discussion_r484719996
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/SubqueryBroadcastExec.scala
##########
@@ -75,17 +75,21 @@ case class SubqueryBroadcastExec(
val beforeCollect = System.nanoTime()
val broadcastRelation = child.executeBroadcast[HashedRelation]().value
- val (iter, expr) = if (broadcastRelation.isInstanceOf[LongHashedRelation]) {
- (broadcastRelation.keys(), HashJoin.extractKeyExprAt(buildKeys, index))
- } else {
- (broadcastRelation.keys(),
- BoundReference(index, buildKeys(index).dataType, buildKeys(index).nullable))
+ val rows = broadcastRelation match {
+ case EmptyHashedRelation =>
+ Array.empty[InternalRow]
Review comment:
Ah, nice catch. We cannot just return an empty row in `EmptyHashedRelation.keys()`?
```
case object EmptyHashedRelation extends HashedRelation {
...
override def keys(): Iterator[InternalRow] = {
Iterator.empty[InternalRow]
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29671: [SPARK-32817][SQL] DPP throws error when broadcast side is empty
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29671:
URL: https://github.com/apache/spark/pull/29671#issuecomment-688962506
**[Test build #128398 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128398/testReport)** for PR 29671 at commit [`eca9d0b`](https://github.com/apache/spark/commit/eca9d0b865203841235890ba8d488baf08d5fd04).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29671: [SPARK-32817][SQL] DPP throws error when broadcast side is empty
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29671:
URL: https://github.com/apache/spark/pull/29671#issuecomment-688756381
**[Test build #128398 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128398/testReport)** for PR 29671 at commit [`eca9d0b`](https://github.com/apache/spark/commit/eca9d0b865203841235890ba8d488baf08d5fd04).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29671: [SPARK-32817][SQL] DPP throws error when broadcast side is empty
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29671:
URL: https://github.com/apache/spark/pull/29671#issuecomment-688832563
**[Test build #128390 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128390/testReport)** for PR 29671 at commit [`0eea2e8`](https://github.com/apache/spark/commit/0eea2e8e268bb43a6d6f3cc59b43528bc1a992a0).
* This patch **fails PySpark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wzhfy commented on a change in pull request #29671: [SPARK-32817][SQL] DPP throws error when broadcast side is empty
Posted by GitBox <gi...@apache.org>.
wzhfy commented on a change in pull request #29671:
URL: https://github.com/apache/spark/pull/29671#discussion_r484734168
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/SubqueryBroadcastExec.scala
##########
@@ -75,17 +75,21 @@ case class SubqueryBroadcastExec(
val beforeCollect = System.nanoTime()
val broadcastRelation = child.executeBroadcast[HashedRelation]().value
- val (iter, expr) = if (broadcastRelation.isInstanceOf[LongHashedRelation]) {
- (broadcastRelation.keys(), HashJoin.extractKeyExprAt(buildKeys, index))
- } else {
- (broadcastRelation.keys(),
- BoundReference(index, buildKeys(index).dataType, buildKeys(index).nullable))
+ val rows = broadcastRelation match {
+ case EmptyHashedRelation =>
+ Array.empty[InternalRow]
Review comment:
I'm also surprised it throws an exception instead of returning an empty iterator. I'm not sure if there is any particular reason to do this. But I'll try to update as your suggestion and see if it works, thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29671: [SPARK-32817][SQL] DPP throws error when broadcast side is empty
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29671:
URL: https://github.com/apache/spark/pull/29671#issuecomment-688833828
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/128390/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] leanken commented on a change in pull request #29671: [SPARK-32817][SQL] DPP throws error when broadcast side is empty
Posted by GitBox <gi...@apache.org>.
leanken commented on a change in pull request #29671:
URL: https://github.com/apache/spark/pull/29671#discussion_r484741162
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/SubqueryBroadcastExec.scala
##########
@@ -75,17 +75,21 @@ case class SubqueryBroadcastExec(
val beforeCollect = System.nanoTime()
val broadcastRelation = child.executeBroadcast[HashedRelation]().value
- val (iter, expr) = if (broadcastRelation.isInstanceOf[LongHashedRelation]) {
- (broadcastRelation.keys(), HashJoin.extractKeyExprAt(buildKeys, index))
- } else {
- (broadcastRelation.keys(),
- BoundReference(index, buildKeys(index).dataType, buildKeys(index).nullable))
+ val rows = broadcastRelation match {
+ case EmptyHashedRelation =>
+ Array.empty[InternalRow]
Review comment:
thanks for catching this. ^_^
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29671: [SPARK-32817] DPP throws error when broadcast side is empty
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29671:
URL: https://github.com/apache/spark/pull/29671#issuecomment-688683381
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29671: [SPARK-32817][SQL] DPP throws error when broadcast side is empty
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29671:
URL: https://github.com/apache/spark/pull/29671#issuecomment-688757224
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29671: [SPARK-32817][SQL] DPP throws error when broadcast side is empty
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29671:
URL: https://github.com/apache/spark/pull/29671#issuecomment-688757224
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wzhfy commented on a change in pull request #29671: [SPARK-32817][SQL] DPP throws error when broadcast side is empty
Posted by GitBox <gi...@apache.org>.
wzhfy commented on a change in pull request #29671:
URL: https://github.com/apache/spark/pull/29671#discussion_r484777353
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/SubqueryBroadcastExec.scala
##########
@@ -75,17 +75,21 @@ case class SubqueryBroadcastExec(
val beforeCollect = System.nanoTime()
val broadcastRelation = child.executeBroadcast[HashedRelation]().value
- val (iter, expr) = if (broadcastRelation.isInstanceOf[LongHashedRelation]) {
- (broadcastRelation.keys(), HashJoin.extractKeyExprAt(buildKeys, index))
- } else {
- (broadcastRelation.keys(),
- BoundReference(index, buildKeys(index).dataType, buildKeys(index).nullable))
+ val rows = broadcastRelation match {
+ case EmptyHashedRelation =>
+ Array.empty[InternalRow]
Review comment:
@leanken Thanks for clarification. I'll update
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29671: [SPARK-32817][SQL] DPP throws error when broadcast side is empty
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29671:
URL: https://github.com/apache/spark/pull/29671#issuecomment-688682637
**[Test build #128390 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128390/testReport)** for PR 29671 at commit [`0eea2e8`](https://github.com/apache/spark/commit/0eea2e8e268bb43a6d6f3cc59b43528bc1a992a0).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29671: [SPARK-32817][SQL] DPP throws error when broadcast side is empty
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29671:
URL: https://github.com/apache/spark/pull/29671#issuecomment-688756381
**[Test build #128398 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128398/testReport)** for PR 29671 at commit [`eca9d0b`](https://github.com/apache/spark/commit/eca9d0b865203841235890ba8d488baf08d5fd04).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29671: [SPARK-32817] DPP throws error when broadcast side is empty
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29671:
URL: https://github.com/apache/spark/pull/29671#issuecomment-688682637
**[Test build #128390 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128390/testReport)** for PR 29671 at commit [`0eea2e8`](https://github.com/apache/spark/commit/0eea2e8e268bb43a6d6f3cc59b43528bc1a992a0).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu closed pull request #29671: [SPARK-32817][SQL] DPP throws error when broadcast side is empty
Posted by GitBox <gi...@apache.org>.
maropu closed pull request #29671:
URL: https://github.com/apache/spark/pull/29671
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29671: [SPARK-32817][SQL] DPP throws error when broadcast side is empty
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29671:
URL: https://github.com/apache/spark/pull/29671#issuecomment-688965646
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org