You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@bugzilla.spamassassin.org on 2008/01/09 11:28:45 UTC

[Bug 5776] New: concatenation errors in Plugin/Check.pm

http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5776

           Summary: concatenation errors in Plugin/Check.pm
           Product: Spamassassin
           Version: 3.2.4
          Platform: Sun
        OS/Version: Solaris
            Status: NEW
          Severity: normal
          Priority: P5
         Component: spamassassin
        AssignedTo: dev@spamassassin.apache.org
        ReportedBy: adam.stephens@bristol.ac.uk


Upgrading to 3.2.4 caused thousands of concatenation errors in the logs:

Jan  9 10:13:53 localhost spamd[16335]: Use of uninitialized value in
concatenation (.) or string at
/usr/local/lib/perl5/site_perl/5.8.8/Mail/SpamAssassin/Plugin/Check.pm line 1026.
Jan  9 10:13:53 localhost last message repeated 329 times

I'm seeing about 7000 lines of this per second:
# grep "Jan  9 10:13:54" /var/adm/spamd | grep -c line\ 1026
7220

Reverting to 3.2.3 fixes the problem.



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug 5776] concatenation errors in Plugin/Check.pm

Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5776


alex.kiernan@gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |alex.kiernan@gmail.com






------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug 5776] concatenation errors in Plugin/Check.pm

Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5776





------- Additional Comments From jm@jmason.org  2008-01-09 02:43 -------
do you use allow_user_rules?

have you additional rules defined in /etc/mail/spamassassin ?

does "spamassassin --lint" pass?



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug 5776] concatenation errors in Plugin/Check.pm

Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5776





------- Additional Comments From adam.stephens@bristol.ac.uk  2008-01-09 07:39 -------
> do you use allow_user_rules?
>
>

No.

> have you additional rules defined in /etc/mail/spamassassin ?
>
>
Yes.

Ah! It seems to be caused by my shortcircuit.cf, modified from the one on the SA
wiki
(http://wiki.apache.org/spamassassin/ShortcircuitingRuleset)

If I comment out the following rule:

# simple, non-network-based whitelists, locally-generated messages,
# messages via a trusted relay chain, simple, non-network based blacklists
meta SC_HAM
(USER_IN_WHITELIST||USER_IN_DEF_WHITELIST||USER_IN_ALL_SPAM_TO||NO_RELAYS||USER_IN_BLACKLIST_TO||USER_IN_BLACKLIST)
priority SC_HAM -1000
shortcircuit SC_HAM ham
score SC_HAM -20

the error stops.

> does "spamassassin --lint" pass?
>
>
Yes




------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug 5776] concatenation errors in Plugin/Check.pm

Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5776





------- Additional Comments From jm@jmason.org  2008-01-09 02:46 -------
oh -- for reference, line 1026 is marked by ### below:


sub hash_line_for_rule {
  my ($self, $pms, $rulename) = @_;
  return "\n".'#line 1 "'.                           ###
        $pms->{conf}->{source_file}->{$rulename}.
        ', rule '.$rulename.',"';
}




------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

Re: [Bug 5776] concatenation errors in Plugin/Check.pm

Posted by Adam Stephens <ad...@bristol.ac.uk>.
bugzilla-daemon@bugzilla.spamassassin.org wrote:
> http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5776
>
>
>
>
>
> ------- Additional Comments From jm@jmason.org  2008-01-09 02:43 -------
> do you use allow_user_rules?
>
>   

No.

> have you additional rules defined in /etc/mail/spamassassin ?
>
>   
Yes.

Ah! It seems to be caused by my shortcircuit.cf, modified from the one 
on the SA wiki
(http://wiki.apache.org/spamassassin/ShortcircuitingRuleset)

If I comment out the following rule:

# simple, non-network-based whitelists, locally-generated messages,
# messages via a trusted relay chain, simple, non-network based blacklists
meta SC_HAM 
(USER_IN_WHITELIST||USER_IN_DEF_WHITELIST||USER_IN_ALL_SPAM_TO||NO_RELAYS||USER_IN_BLACKLIST_TO||USER_IN_BLACKLIST)
priority SC_HAM -1000
shortcircuit SC_HAM ham
score SC_HAM -20

the error stops.

> does "spamassassin --lint" pass?
>
>   
Yes

-- 
--------------------------------
Adam Stephens
Network Specialist - Email & DNS
adam.stephens@bristol.ac.uk