You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/07/10 11:53:37 UTC
[GitHub] [incubator-apisix-dashboard] LiteSun opened a new pull request #304: Feat: added Route Consumer and Upstream
LiteSun opened a new pull request #304:
URL: https://github.com/apache/incubator-apisix-dashboard/pull/304
- [x] feat: added Route
- [x] feat: added Consumer
- [x] feat: added Upstream
- [x] feat: update SSL
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-apisix-dashboard] juzhiyuan commented on a change in pull request #304: Feat: added Route Consumer and Upstream
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #304:
URL: https://github.com/apache/incubator-apisix-dashboard/pull/304#discussion_r453189479
##########
File path: package.json
##########
@@ -33,8 +33,7 @@
},
"husky": {
"hooks": {
- "pre-commit": "npm run lint-staged",
- "commit-msg": "node scripts/verifyCommit.js"
+ "pre-commit": "npm run lint-staged"
Review comment:
The pre-commit command should be kept.
##########
File path: src/pages/Consumer/Create.tsx
##########
@@ -0,0 +1,86 @@
+import React, { useState, useEffect } from 'react';
+import { PageContainer } from '@ant-design/pro-layout';
+import { Card, Steps, notification } from 'antd';
+import { useForm } from 'antd/es/form/util';
+
+import ActionBar from '@/components/ActionBar';
+import PluginPage from '@/components/PluginPage/PluginPage';
Review comment:
We could import it from PluginPage directly?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-apisix-dashboard] juzhiyuan merged pull request #304: Feat: added Route Consumer and Upstream
Posted by GitBox <gi...@apache.org>.
juzhiyuan merged pull request #304:
URL: https://github.com/apache/incubator-apisix-dashboard/pull/304
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org