You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Lars Volker (Code Review)" <ge...@cloudera.org> on 2016/09/16 16:34:16 UTC
[Impala-ASF-CR] IMPALA-4116: Remove 'cdh' from version string again
Lars Volker has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4439
Change subject: IMPALA-4116: Remove 'cdh' from version string again
......................................................................
IMPALA-4116: Remove 'cdh' from version string again
The rebase of another change went wrong and undid the change of
I7754538a23e73dcdebc6e3df509f357cbe03198c so we need to do this one
again. Previous review was at http://gerrit.cloudera.org:8080/4421 .
Change-Id: Ie386d25f2006e2dcebcbfd3d6ae88f70d65efb0f
---
M bin/save-version.sh
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/39/4439/1
--
To view, visit http://gerrit.cloudera.org:8080/4439
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie386d25f2006e2dcebcbfd3d6ae88f70d65efb0f
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
[Impala-ASF-CR] IMPALA-4116: Remove 'cdh' from version string again
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change.
Change subject: IMPALA-4116: Remove 'cdh' from version string again
......................................................................
Patch Set 1: Code-Review+2
Since this already passed GVO, I think it's OK to commit without doing that again.
--
To view, visit http://gerrit.cloudera.org:8080/4439
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie386d25f2006e2dcebcbfd3d6ae88f70d65efb0f
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4116: Remove 'cdh' from version string again
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has submitted this change and it was merged.
Change subject: IMPALA-4116: Remove 'cdh' from version string again
......................................................................
IMPALA-4116: Remove 'cdh' from version string again
The rebase of another change went wrong and undid the change of
I7754538a23e73dcdebc6e3df509f357cbe03198c so we need to do this one
again. Previous review was at http://gerrit.cloudera.org:8080/4421 .
Change-Id: Ie386d25f2006e2dcebcbfd3d6ae88f70d65efb0f
Reviewed-on: http://gerrit.cloudera.org:8080/4439
Reviewed-by: Sailesh Mukil <sa...@cloudera.com>
Reviewed-by: Lars Volker <lv...@cloudera.com>
Reviewed-by: Jim Apple <jb...@cloudera.com>
Tested-by: Sailesh Mukil <sa...@cloudera.com>
---
M bin/save-version.sh
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jim Apple: Looks good to me, approved
Lars Volker: Looks good to me, but someone else must approve
Sailesh Mukil: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/4439
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie386d25f2006e2dcebcbfd3d6ae88f70d65efb0f
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
[Impala-ASF-CR] IMPALA-4116: Remove 'cdh' from version string again
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change.
Change subject: IMPALA-4116: Remove 'cdh' from version string again
......................................................................
Patch Set 1: Code-Review+1
No worries. I think we should merge this right away. The previous attempt was done after full GVO so I don't see why anything could be wrong now.
--
To view, visit http://gerrit.cloudera.org:8080/4439
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie386d25f2006e2dcebcbfd3d6ae88f70d65efb0f
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4116: Remove 'cdh' from version string again
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change.
Change subject: IMPALA-4116: Remove 'cdh' from version string again
......................................................................
Patch Set 1:
As a non-committer I cannot submit this. Can one of you please submit and push it to the asf repo? Thanks a lot.
--
To view, visit http://gerrit.cloudera.org:8080/4439
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie386d25f2006e2dcebcbfd3d6ae88f70d65efb0f
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4116: Remove 'cdh' from version string again
Posted by "Sailesh Mukil (Code Review)" <ge...@cloudera.org>.
Sailesh Mukil has posted comments on this change.
Change subject: IMPALA-4116: Remove 'cdh' from version string again
......................................................................
Patch Set 1: Verified+1
> Since this already passed GVO, I think it's OK to commit without
> doing that again.
Manually verifying as it already went through GVO once before.
--
To view, visit http://gerrit.cloudera.org:8080/4439
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie386d25f2006e2dcebcbfd3d6ae88f70d65efb0f
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4116: Remove 'cdh' from version string again
Posted by "Sailesh Mukil (Code Review)" <ge...@cloudera.org>.
Sailesh Mukil has posted comments on this change.
Change subject: IMPALA-4116: Remove 'cdh' from version string again
......................................................................
Patch Set 1: Code-Review+2
> Uploaded patch set 1.
Really sorry about this. This patch and my patch got committed together and I reverted this on rebase by mistake.
--
To view, visit http://gerrit.cloudera.org:8080/4439
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie386d25f2006e2dcebcbfd3d6ae88f70d65efb0f
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-HasComments: No