You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Alexander Kolbasov <ak...@gmail.com> on 2016/11/18 01:52:41 UTC
Review Request 53872: SENTRY-1525: Provide script to run Sentry
directly from the repo
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53872/
-----------------------------------------------------------
Review request for sentry, Colm O hEigeartaigh, Colin Ma, Hao Hao, Sravya Tirukkovalur, and Vadim Spector.
Repository: sentry
Description
-------
SENTRY-1525: Provide script to run Sentry directly from the repo
Diffs
-----
bin/run_sentry.sh PRE-CREATION
Diff: https://reviews.apache.org/r/53872/diff/
Testing
-------
Thanks,
Alexander Kolbasov
Re: Review Request 53872: SENTRY-1525: Provide script to run Sentry
directly from the repo
Posted by Vamsee Yarlagadda <va...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53872/#review158051
-----------------------------------------------------------
Ship it!
Ship It!
- Vamsee Yarlagadda
On Dec. 3, 2016, 5 a.m., Alexander Kolbasov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53872/
> -----------------------------------------------------------
>
> (Updated Dec. 3, 2016, 5 a.m.)
>
>
> Review request for sentry, Colm O hEigeartaigh, Colin Ma, Hao Hao, kalyan kumar kalvagadda, Vamsee Yarlagadda, and Vadim Spector.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> SENTRY-1525: Provide script to run Sentry directly from the repo
>
>
> Diffs
> -----
>
> bin/run_sentry.sh PRE-CREATION
>
> Diff: https://reviews.apache.org/r/53872/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alexander Kolbasov
>
>
Re: Review Request 53872: SENTRY-1525: Provide script to run Sentry
directly from the repo
Posted by Vamsee Yarlagadda <va...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53872/#review158052
-----------------------------------------------------------
Can we rename the file to say "run_local_sentry" to explictly state it is for developer use rather than getting confused about the use of it.
- Vamsee Yarlagadda
On Dec. 3, 2016, 5 a.m., Alexander Kolbasov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53872/
> -----------------------------------------------------------
>
> (Updated Dec. 3, 2016, 5 a.m.)
>
>
> Review request for sentry, Colm O hEigeartaigh, Colin Ma, Hao Hao, kalyan kumar kalvagadda, Vamsee Yarlagadda, and Vadim Spector.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> SENTRY-1525: Provide script to run Sentry directly from the repo
>
>
> Diffs
> -----
>
> bin/run_sentry.sh PRE-CREATION
>
> Diff: https://reviews.apache.org/r/53872/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alexander Kolbasov
>
>
Re: Review Request 53872: SENTRY-1525: Provide script to run Sentry
directly from the repo
Posted by kalyan kumar kalvagadda <kk...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53872/#review158155
-----------------------------------------------------------
Ship it!
Ship It!
- kalyan kumar kalvagadda
On Dec. 3, 2016, 5 a.m., Alexander Kolbasov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53872/
> -----------------------------------------------------------
>
> (Updated Dec. 3, 2016, 5 a.m.)
>
>
> Review request for sentry, Colm O hEigeartaigh, Colin Ma, Hao Hao, kalyan kumar kalvagadda, Vamsee Yarlagadda, and Vadim Spector.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> SENTRY-1525: Provide script to run Sentry directly from the repo
>
>
> Diffs
> -----
>
> bin/run_sentry.sh PRE-CREATION
>
> Diff: https://reviews.apache.org/r/53872/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alexander Kolbasov
>
>
Re: Review Request 53872: SENTRY-1525: Provide script to run Sentry
directly from the repo
Posted by Alexander Kolbasov <ak...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53872/
-----------------------------------------------------------
(Updated Dec. 3, 2016, 5 a.m.)
Review request for sentry, Colm O hEigeartaigh, Colin Ma, Hao Hao, kalyan kumar kalvagadda, Vamsee Yarlagadda, and Vadim Spector.
Changes
-------
Addressed code review comments. Also made main class configurable via SENTRY_MAIN environment variable
Repository: sentry
Description
-------
SENTRY-1525: Provide script to run Sentry directly from the repo
Diffs (updated)
-----
bin/run_sentry.sh PRE-CREATION
Diff: https://reviews.apache.org/r/53872/diff/
Testing
-------
Thanks,
Alexander Kolbasov
Re: Review Request 53872: SENTRY-1525: Provide script to run Sentry
directly from the repo
Posted by Alexander Kolbasov <ak...@gmail.com>.
> On Nov. 28, 2016, 6:53 p.m., Hao Hao wrote:
> > bin/run_sentry.sh, line 24
> > <https://reviews.apache.org/r/53872/diff/1/?file=1566622#file1566622line24>
> >
> > Should it be configurable?
Configurable in what way? I don't want this script to have any argument since all of them are going to the executable. On the other hand this is checked in a specific branch, so this can be always made branch-specific. I can try to detect this, but it would be error-prone.
> On Nov. 28, 2016, 6:53 p.m., Hao Hao wrote:
> > bin/run_sentry.sh, line 34
> > <https://reviews.apache.org/r/53872/diff/1/?file=1566622#file1566622line34>
> >
> > If mvn is not installed, ask to install and then run?
This is a script for developers, not end users, if they don't have mvn they are not able to compile it in the first place (and this requires mvn install first).
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53872/#review157096
-----------------------------------------------------------
On Dec. 3, 2016, 5 a.m., Alexander Kolbasov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53872/
> -----------------------------------------------------------
>
> (Updated Dec. 3, 2016, 5 a.m.)
>
>
> Review request for sentry, Colm O hEigeartaigh, Colin Ma, Hao Hao, kalyan kumar kalvagadda, Vamsee Yarlagadda, and Vadim Spector.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> SENTRY-1525: Provide script to run Sentry directly from the repo
>
>
> Diffs
> -----
>
> bin/run_sentry.sh PRE-CREATION
>
> Diff: https://reviews.apache.org/r/53872/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alexander Kolbasov
>
>
Re: Review Request 53872: SENTRY-1525: Provide script to run Sentry
directly from the repo
Posted by Hao Hao <ha...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53872/#review157096
-----------------------------------------------------------
bin/run_sentry.sh (line 24)
<https://reviews.apache.org/r/53872/#comment227517>
Should it be configurable?
bin/run_sentry.sh (line 34)
<https://reviews.apache.org/r/53872/#comment227514>
If mvn is not installed, ask to install and then run?
- Hao Hao
On Nov. 18, 2016, 1:52 a.m., Alexander Kolbasov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53872/
> -----------------------------------------------------------
>
> (Updated Nov. 18, 2016, 1:52 a.m.)
>
>
> Review request for sentry, Colm O hEigeartaigh, Colin Ma, Hao Hao, Sravya Tirukkovalur, and Vadim Spector.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> SENTRY-1525: Provide script to run Sentry directly from the repo
>
>
> Diffs
> -----
>
> bin/run_sentry.sh PRE-CREATION
>
> Diff: https://reviews.apache.org/r/53872/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alexander Kolbasov
>
>