You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/06/28 15:31:59 UTC
[GitHub] [kafka] sasukerui opened a new pull request #8942: modify the judgment condition in KafkaApis getTopicMetadata
sasukerui opened a new pull request #8942:
URL: https://github.com/apache/kafka/pull/8942
in the method handleTopicMetadataRequest it has been determined whether authorizedTopics is empty，no need to judge again in the getTopicMetadata method，the method getTopicMetadata should be removed topics.isEmpty. Maybe in the future getTopicMetadata method will use the single judgment condition.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] sasukerui commented on pull request #8942: modify the judgment condition in KafkaApis getTopicMetadata
Posted by GitBox <gi...@apache.org>.
sasukerui commented on pull request #8942:
URL: https://github.com/apache/kafka/pull/8942#issuecomment-651452303
> Thanks for the PR. Is this causing incorrect behavior or is it just a clean-up? Please note that PRs should target the master branch.
it just a clean-up,I have resubmitted a PR target the master branch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] chia7712 commented on pull request #8942: modify the judgment condition in KafkaApis getTopicMetadata
Posted by GitBox <gi...@apache.org>.
chia7712 commented on pull request #8942:
URL: https://github.com/apache/kafka/pull/8942#issuecomment-711591046
> it just a clean-up,I have resubmitted a PR target the master branch.
You had opened #8950 to replace this PR so I'm going to close this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] chia7712 closed pull request #8942: modify the judgment condition in KafkaApis getTopicMetadata
Posted by GitBox <gi...@apache.org>.
chia7712 closed pull request #8942:
URL: https://github.com/apache/kafka/pull/8942
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma commented on pull request #8942: modify the judgment condition in KafkaApis getTopicMetadata
Posted by GitBox <gi...@apache.org>.
ijuma commented on pull request #8942:
URL: https://github.com/apache/kafka/pull/8942#issuecomment-650784697
Thanks for the PR. Is this causing incorrect behavior or is it just a clean-up? Please note that PRs should target the master branch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] sasukerui commented on pull request #8942: modify the judgment condition in KafkaApis getTopicMetadata
Posted by GitBox <gi...@apache.org>.
sasukerui commented on pull request #8942:
URL: https://github.com/apache/kafka/pull/8942#issuecomment-651137328
> Thanks for the PR. Is this causing incorrect behavior or is it just a clean-up? Please note that PRs should target the master branch.
Thanks for your answer, I will pay attention in the future
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org