Re: [DISCUSS] PR review & merge suggests

[Leonard（Lifeng Nie） <ni...@apache.org>]

+1

Carl-Zhou-CN <10...@qq.com.invalid> 于2023年12月29日周五 21:15写道：

> agree&nbsp;
>
>
>
> &nbsp;
> Carl-Zhou-CN
>
>
>
>
> ------------------&nbsp;原始邮件&nbsp;------------------
> 发件人:
>                                                   "dev"
>                                                                 <
> gaojun2048@apache.org&gt;;
> 发送时间:&nbsp;2023年12月27日(星期三) 下午2:08
> 收件人:&nbsp;"dev"<dev@seatunnel.apache.org&gt;;
>
> 主题:&nbsp;Re: [DISCUSS] PR review &amp; merge suggests
>
>
>
> I agree with you.
>
> Jia Fan <fanjiaeminem@qq.com.invalid&gt; 于2023年12月27日周三 14:07写道：
>
> &gt; Thanks hailin for open this discussion. Agree with your point.
> &gt;
> &gt; ________________________
> &gt;
> &gt; Jia Fan
> &gt;
> &gt;
> &gt;
> &gt; &gt; 2023年12月26日 22:05，hailin0 <wanghailin@apache.org&gt; 写道：
> &gt; &gt;
> &gt; &gt; Hi developers,
> &gt; &gt;
> &gt; &gt; In the recent development process, I discovered an issue with PR
> Review &amp;
> &gt; &gt; Merged. The review did not strictly check whether E2E &amp; unit
> test are
> &gt; &gt; included, thus causing the code to run unstable.
> &gt; &gt; e.g:
> &gt; &gt; 1. A bug that has already been fixed reappears
> &gt; &gt; 2. Released feature is broken by new commit
> &gt; &gt; 3. Incomplete changes lead to multiple mentions of patch
> &gt; &gt;
> &gt; &gt; Therefore, I would like to suggest that PR reviews must verify
> that:
> &gt; &gt; 1. Include unit testing &amp; end-to-end testing
> &gt; &gt; 2. Include document changes
> &gt; &gt; 3. Compatibility design and inspection
> &gt; &gt; 4. CI verification passed
> &gt; &gt;
> &gt; &gt; What do you think about this? If you have any advice, please let
> me know.
> &gt; &gt;
> &gt; &gt; hailin0
> &gt;
> &gt;
>
> --
>
> Best Regards
>
> ------------
>
> EricJoy2048
> gaojun2048@gmail.com



-- 
Warm Regards,

Leonard（LiFeng Nie）