You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Hudson (JIRA)" <ji...@apache.org> on 2019/01/31 16:20:00 UTC

[jira] [Commented] (ZOOKEEPER-2826) Code refactoring for `CLI` module

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16757433#comment-16757433 ] 

Hudson commented on ZOOKEEPER-2826:
-----------------------------------

FAILURE: Integrated in Jenkins build Zookeeper-trunk-single-thread #214 (See [https://builds.apache.org/job/Zookeeper-trunk-single-thread/214/])
ZOOKEEPER-2826: Code refactoring for `CLI` module (andor: rev 8f62ee9740c9cdd0e4e3ec5c6d906236fe35a003)
* (edit) zookeeper-server/src/main/java/org/apache/zookeeper/cli/GetConfigCommand.java
* (edit) zookeeper-server/src/main/java/org/apache/zookeeper/cli/ReconfigCommand.java
* (edit) zookeeper-server/src/main/java/org/apache/zookeeper/cli/GetAclCommand.java
* (edit) zookeeper-server/src/main/java/org/apache/zookeeper/cli/RemoveWatchesCommand.java
* (edit) zookeeper-server/src/main/java/org/apache/zookeeper/cli/AddAuthCommand.java
* (edit) zookeeper-server/src/main/java/org/apache/zookeeper/cli/DeleteCommand.java
* (edit) zookeeper-server/src/main/java/org/apache/zookeeper/cli/SetQuotaCommand.java
* (edit) zookeeper-server/src/main/java/org/apache/zookeeper/cli/DelQuotaCommand.java
* (edit) zookeeper-server/src/main/java/org/apache/zookeeper/cli/ListQuotaCommand.java
* (edit) zookeeper-server/src/main/java/org/apache/zookeeper/cli/SetCommand.java
* (edit) zookeeper-server/src/main/java/org/apache/zookeeper/cli/SetAclCommand.java
* (edit) zookeeper-server/src/main/java/org/apache/zookeeper/cli/CliCommand.java
* (edit) zookeeper-server/src/main/java/org/apache/zookeeper/cli/SyncCommand.java
* (edit) zookeeper-server/src/main/java/org/apache/zookeeper/cli/GetCommand.java
* (edit) zookeeper-server/src/main/java/org/apache/zookeeper/cli/LsCommand.java


> Code refactoring for `CLI` module
> ---------------------------------
>
>                 Key: ZOOKEEPER-2826
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2826
>             Project: ZooKeeper
>          Issue Type: Improvement
>          Components: java client
>    Affects Versions: 3.5.3
>            Reporter: Benedict Jin
>            Assignee: Benedict Jin
>            Priority: Minor
>              Labels: pull-request-available
>             Fix For: 3.6.0, 3.5.5
>
>   Original Estimate: 72h
>          Time Spent: 50m
>  Remaining Estimate: 71h 10m
>
> * Fix spell issues
> * Remove unnecessary `import`
> * Make initialization block that related with `options.addOption` into static
> * Standardize `StringBuilder#append` usage
> * Using `try` clause to release the resource of stream



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)